From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:pr/639 4361/24603] drivers/i2c/busses/xen-i2cfront.c:148:5: warning: no previous prototype for function 'i2cfront_xfer'
Date: Thu, 31 Aug 2023 22:33:20 +0800 [thread overview]
Message-ID: <202308312218.flSXKSw8-lkp@intel.com> (raw)
Hi Peng,
FYI, the error/warning still remains.
tree: https://github.com/Freescale/linux-fslc pr/639
head: 857fbf7cebaba3b1ffccc558deee1d13ac0e11d7
commit: 278ca911463717ef3565b97b4e515c0269d6d22b [4361/24603] LF-191-2 i2c: introduce xen i2c paravirtualization driver
config: x86_64-randconfig-r016-20230831 (https://download.01.org/0day-ci/archive/20230831/202308312218.flSXKSw8-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308312218.flSXKSw8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308312218.flSXKSw8-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/i2c/busses/xen-i2cfront.c:148:5: warning: no previous prototype for function 'i2cfront_xfer' [-Wmissing-prototypes]
int i2cfront_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num)
^
drivers/i2c/busses/xen-i2cfront.c:148:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int i2cfront_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num)
^
static
1 warning generated.
vim +/i2cfront_xfer +148 drivers/i2c/busses/xen-i2cfront.c
147
> 148 int i2cfront_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num)
149 {
150 struct i2cfront_info *info = i2c_get_adapdata(adapter);
151 int ret, i;
152
153 if (!info || !info->i2cdev) {
154 dev_err(&adapter->dev, "Not initialized\n");
155 return -EIO;
156 }
157
158 if (info->i2cdev->state != XenbusStateConnected) {
159 dev_err(&adapter->dev, "Not connected\n");
160 return -EIO;
161 }
162
163 for (i = 0; i < num; i++) {
164 if (msgs[i].flags & I2C_M_RD) {
165 ret = i2cfront_do_req(adapter, &msgs[i], 1);
166 } else if ((i + 1 < num) && (msgs[i + 1].flags & I2C_M_RD) &&
167 (msgs[i].addr == msgs[i + 1].addr)) {
168 ret = i2cfront_do_req(adapter, &msgs[i], 2);
169 i++;
170 } else {
171 ret = i2cfront_do_req(adapter, &msgs[i], 1);
172 }
173
174 if (ret < 0)
175 goto err;
176 }
177 err:
178 return (ret < 0) ? ret : num;
179 }
180
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-08-31 14:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308312218.flSXKSw8-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.