All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:pr/639 9878/24603] drivers/clk/imx/clk-imx8mm.c:710:26: warning: unused variable 'delta_k_fops'
Date: Thu, 31 Aug 2023 23:06:16 +0800	[thread overview]
Message-ID: <202308312251.trHHTdPO-lkp@intel.com> (raw)

Hi Jindong,

FYI, the error/warning still remains.

tree:   https://github.com/Freescale/linux-fslc pr/639
head:   857fbf7cebaba3b1ffccc558deee1d13ac0e11d7
commit: e1ab8f0dce3e08b5ec37419160bfc04ef4f438e1 [9878/24603] MA-19046 clk: imx8mm: Support building clk-imx8mm driver as module
config: riscv-randconfig-r015-20230831 (https://download.01.org/0day-ci/archive/20230831/202308312251.trHHTdPO-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230831/202308312251.trHHTdPO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308312251.trHHTdPO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/clk/imx/clk-imx8mm.c:710:26: warning: unused variable 'delta_k_fops' [-Wunused-const-variable]
   DEFINE_DEBUGFS_ATTRIBUTE(delta_k_fops, NULL, pll_delta_k_set, "%lld\n");
                            ^
>> drivers/clk/imx/clk-imx8mm.c:731:1: warning: unused variable 'pll_setting_fops' [-Wunused-const-variable]
   DEFINE_SHOW_ATTRIBUTE(pll_setting);
   ^
   include/linux/seq_file.h:186:37: note: expanded from macro 'DEFINE_SHOW_ATTRIBUTE'
   static const struct file_operations __name ## _fops = {                 \
                                       ^
   <scratch space>:151:1: note: expanded from here
   pll_setting_fops
   ^
   2 warnings generated.


vim +/delta_k_fops +710 drivers/clk/imx/clk-imx8mm.c

85a61310c03536 Jacky Bai 2020-04-07  696  
85a61310c03536 Jacky Bai 2020-04-07  697  static int pll_delta_k_set(void *data, u64 val)
85a61310c03536 Jacky Bai 2020-04-07  698  {
85a61310c03536 Jacky Bai 2020-04-07  699  	struct clk_hw *hw;
85a61310c03536 Jacky Bai 2020-04-07  700  	short int delta_k;
85a61310c03536 Jacky Bai 2020-04-07  701  
85a61310c03536 Jacky Bai 2020-04-07  702  	hw = data;
85a61310c03536 Jacky Bai 2020-04-07  703  	delta_k = (short int) (val & KDIV_MASK);
85a61310c03536 Jacky Bai 2020-04-07  704  
85a61310c03536 Jacky Bai 2020-04-07  705  	clk_set_delta_k(hw, val);
85a61310c03536 Jacky Bai 2020-04-07  706  
85a61310c03536 Jacky Bai 2020-04-07  707  	pr_debug("the delta k is %d\n", delta_k);
85a61310c03536 Jacky Bai 2020-04-07  708  	return 0;
85a61310c03536 Jacky Bai 2020-04-07  709  }
85a61310c03536 Jacky Bai 2020-04-07 @710  DEFINE_DEBUGFS_ATTRIBUTE(delta_k_fops, NULL, pll_delta_k_set, "%lld\n");
85a61310c03536 Jacky Bai 2020-04-07  711  
85a61310c03536 Jacky Bai 2020-04-07  712  static int pll_setting_show(struct seq_file *s, void *data)
85a61310c03536 Jacky Bai 2020-04-07  713  {
85a61310c03536 Jacky Bai 2020-04-07  714  	struct clk_hw *hw;
85a61310c03536 Jacky Bai 2020-04-07  715  	u32 pll_div_ctrl0, pll_div_ctrl1;
85a61310c03536 Jacky Bai 2020-04-07  716  	u32 mdiv, pdiv, sdiv, kdiv;
85a61310c03536 Jacky Bai 2020-04-07  717  
85a61310c03536 Jacky Bai 2020-04-07  718  	hw = s->private;;
85a61310c03536 Jacky Bai 2020-04-07  719  
85a61310c03536 Jacky Bai 2020-04-07  720  	clk_get_pll_setting(hw, &pll_div_ctrl0, &pll_div_ctrl1);
85a61310c03536 Jacky Bai 2020-04-07  721  	mdiv = (pll_div_ctrl0 & MDIV_MASK) >> MDIV_SHIFT;
85a61310c03536 Jacky Bai 2020-04-07  722  	pdiv = (pll_div_ctrl0 & PDIV_MASK) >> PDIV_SHIFT;
85a61310c03536 Jacky Bai 2020-04-07  723  	sdiv = (pll_div_ctrl0 & SDIV_MASK) >> SDIV_SHIFT;
85a61310c03536 Jacky Bai 2020-04-07  724  	kdiv = (pll_div_ctrl1 & KDIV_MASK);
85a61310c03536 Jacky Bai 2020-04-07  725  
85a61310c03536 Jacky Bai 2020-04-07  726  	seq_printf(s, "Mdiv: 0x%x; Pdiv: 0x%x; Sdiv: 0x%x; Kdiv: 0x%x\n",
85a61310c03536 Jacky Bai 2020-04-07  727  		mdiv, pdiv, sdiv, kdiv);
85a61310c03536 Jacky Bai 2020-04-07  728  
85a61310c03536 Jacky Bai 2020-04-07  729  	return 0;
85a61310c03536 Jacky Bai 2020-04-07  730  }
85a61310c03536 Jacky Bai 2020-04-07 @731  DEFINE_SHOW_ATTRIBUTE(pll_setting);
85a61310c03536 Jacky Bai 2020-04-07  732  

:::::: The code at line 710 was first introduced by commit
:::::: 85a61310c03536f1da881cc423ae83dce540ddad MLK-23751 clk: imx: Add audio PLL debug fs for K-divider monitor control

:::::: TO: Jacky Bai <ping.bai@nxp.com>
:::::: CC: Dong Aisheng <aisheng.dong@nxp.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-08-31 15:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202308312251.trHHTdPO-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.