From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:pr/639 200/24603] sound/soc/codecs/rpmsg_wm8960.c:595: warning: Function parameter or member 'wm8960' not described in 'wm8960_configure_sysclk'
Date: Fri, 1 Sep 2023 00:42:24 +0800 [thread overview]
Message-ID: <202309010044.cLdtAGCl-lkp@intel.com> (raw)
tree: https://github.com/Freescale/linux-fslc pr/639
head: 857fbf7cebaba3b1ffccc558deee1d13ac0e11d7
commit: 2774b576cf24b5776af2be2822fc3149999eb569 [200/24603] MLK-17156-4: ASoC: rpmsg_wm8960: add rpmsg_wm8960 codec
config: arc-randconfig-001-20230831 (https://download.01.org/0day-ci/archive/20230901/202309010044.cLdtAGCl-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230901/202309010044.cLdtAGCl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309010044.cLdtAGCl-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> sound/soc/codecs/rpmsg_wm8960.c:595: warning: Function parameter or member 'wm8960' not described in 'wm8960_configure_sysclk'
>> sound/soc/codecs/rpmsg_wm8960.c:595: warning: Excess function parameter 'wm8960_priv' description in 'wm8960_configure_sysclk'
vim +595 sound/soc/codecs/rpmsg_wm8960.c
573
574 /**
575 * wm8960_configure_sysclk - checks if there is a sysclk frequency available
576 * The sysclk must be chosen such that:
577 * - sysclk = MCLK / sysclk_divs
578 * - lrclk = sysclk / dac_divs
579 * - 10 * bclk = sysclk / bclk_divs
580 *
581 * @wm8960_priv: wm8960 codec private data
582 * @mclk: MCLK used to derive sysclk
583 * @sysclk_idx: sysclk_divs index for found sysclk
584 * @dac_idx: dac_divs index for found lrclk
585 * @bclk_idx: bclk_divs index for found bclk
586 *
587 * Returns:
588 * -1, in case no sysclk frequency available found
589 * >=0, in case we could derive bclk and lrclk from sysclk using
590 * (@sysclk_idx, @dac_idx, @bclk_idx) dividers
591 */
592 static
593 int wm8960_configure_sysclk(struct rpmsg_wm8960_priv *wm8960, int mclk,
594 int *sysclk_idx, int *dac_idx, int *bclk_idx)
> 595 {
596 int sysclk, bclk, lrclk;
597 int i, j, k;
598 int diff;
599
600 /* marker for no match */
601 *bclk_idx = -1;
602
603 bclk = wm8960->bclk;
604 lrclk = wm8960->lrclk;
605
606 /* check if the sysclk frequency is available. */
607 for (i = 0; i < ARRAY_SIZE(sysclk_divs); ++i) {
608 if (sysclk_divs[i] == -1)
609 continue;
610 sysclk = mclk / sysclk_divs[i];
611 for (j = 0; j < ARRAY_SIZE(dac_divs); ++j) {
612 if (sysclk != dac_divs[j] * lrclk)
613 continue;
614 for (k = 0; k < ARRAY_SIZE(bclk_divs); ++k) {
615 diff = sysclk - bclk * bclk_divs[k] / 10;
616 if (diff == 0) {
617 *sysclk_idx = i;
618 *dac_idx = j;
619 *bclk_idx = k;
620 break;
621 }
622 }
623 if (k != ARRAY_SIZE(bclk_divs))
624 break;
625 }
626 if (j != ARRAY_SIZE(dac_divs))
627 break;
628 }
629 return *bclk_idx;
630 }
631
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-08-31 16:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309010044.cLdtAGCl-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.