All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Pilkington <simonp.git@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: Simon Pilkington <simonp.git@gmail.com>
Subject: [PATCH] drm/amd: Make fence wait in suballocator uninterruptible
Date: Fri,  1 Sep 2023 03:01:15 +0100	[thread overview]
Message-ID: <20230901020115.2442-1-simonp.git@gmail.com> (raw)

c103a23f2f297c6ab2e5e74e39b655439f3524a6 made the fence wait in
amdgpu_sa_bo_new() interruptible but there is no code to handle an interrupt.
This caused the kernel to randomly explode in high-VRAM-pressure situations
so make it uninterruptible again.

Signed-off-by: Simon Pilkington <simonp.git@gmail.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
index c6b4337eb20c..10df731998b2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
@@ -81,7 +81,7 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
 		     unsigned int size)
 {
 	struct drm_suballoc *sa = drm_suballoc_new(&sa_manager->base, size,
-						   GFP_KERNEL, true, 0);
+						   GFP_KERNEL, false, 0);
 
 	if (IS_ERR(sa)) {
 		*sa_bo = NULL;
-- 
2.40.1


             reply	other threads:[~2023-09-01 19:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  2:01 Simon Pilkington [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-09-01  7:31 [PATCH] drm/amd: Make fence wait in suballocator uninterruptible Simon Pilkington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230901020115.2442-1-simonp.git@gmail.com \
    --to=simonp.git@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.