From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FF13CA0FEC for ; Fri, 1 Sep 2023 17:01:00 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A59BC3CED39 for ; Fri, 1 Sep 2023 19:00:55 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id EFBC73CBB96 for ; Fri, 1 Sep 2023 19:00:43 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id A6D861400F28 for ; Fri, 1 Sep 2023 19:00:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 679982183A; Fri, 1 Sep 2023 17:00:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1693587641; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=plQzrLNOM0dY7tFNMziRy/aGw7JpLBOeQHRsH/DtKm0=; b=B5paugHj8AESSu8aRATVuBwJSgE0ThMsuXFY6BopwbIkcqe7p7Zv2QYKUe1wX3wy0fQgT/ wvGXVADEFLrVbGbaWrbV5K89p4ZC3hJJzz7ND2CeJCI9KezaJjytrXr9ATwOwaX5Tlbtjd hDLRy6vu2i6A9kWhVwEU3K+oHjWExrc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1693587641; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=plQzrLNOM0dY7tFNMziRy/aGw7JpLBOeQHRsH/DtKm0=; b=gHXbdCCPtYRsPF7uCgRcLGpJrJhK7T8eHz1nsNM9fS/b3zp+NI/JeDMyB/ossps1QM8OES JgG+HtqW69wlYKAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E58481358B; Fri, 1 Sep 2023 17:00:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DEX5L7gY8mQpKwAAMHmgww (envelope-from ); Fri, 01 Sep 2023 17:00:40 +0000 Date: Fri, 1 Sep 2023 19:00:38 +0200 From: Petr Vorel To: Martin Doucha Message-ID: <20230901170038.GA386230@pevik> References: <20230901144407.364630-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 1.0.1 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] clone302: Fix short size test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Martin, > Hi, > On 01. 09. 23 16:44, Petr Vorel wrote: > > Test uses sizeof(struct clone_args)-1 as invalid size. Original struct > > size 64 was suitable (because > 64 results in EINVAL), but unrelated > Nit: <64 Thanks! (I meant that, but fingers wrote the opposite comparator.) > > change in 45f6916ba increased the size to 88, thus test failed to due > > unexpected clone3() pass. > > Depending on struct clone_args size is not good idea, let's use > > arbitrary value 1. > This will work, but we could also define a "minimal" struct clone_args > (without any fields other than the required ones) and use the size of that > (-1 of course). That would give better coverage and leave no untested gap > between 1 and minimal struct size. Very good idea. I'm setting this as changes requested. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp