All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:5.15-2.2.x-imx 627/24604] drivers/clk/imx/clk-imx-acm-utils.c:13: warning: Function parameter or member 'dev' not described in 'clk_imx_acm_attach_pm_domains'
Date: Fri, 1 Sep 2023 18:49:08 +0800	[thread overview]
Message-ID: <202309011838.V5MgfoMq-lkp@intel.com> (raw)

tree:   https://github.com/Freescale/linux-fslc 5.15-2.2.x-imx
head:   7c13adcd3af7dcd541144655102e1cdb941ad538
commit: 67a7f9faba8affeb1633fe5a5020612fdf675ce6 [627/24604] MLK-23618-12: clk: imx: acm: add acm utils function
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20230901/202309011838.V5MgfoMq-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230901/202309011838.V5MgfoMq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309011838.V5MgfoMq-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/clk/imx/clk-imx-acm-utils.c:13: warning: Function parameter or member 'dev' not described in 'clk_imx_acm_attach_pm_domains'
>> drivers/clk/imx/clk-imx-acm-utils.c:13: warning: Function parameter or member 'dev_pm' not described in 'clk_imx_acm_attach_pm_domains'
>> drivers/clk/imx/clk-imx-acm-utils.c:66: warning: Function parameter or member 'dev' not described in 'clk_imx_acm_detach_pm_domains'
>> drivers/clk/imx/clk-imx-acm-utils.c:66: warning: Function parameter or member 'dev_pm' not described in 'clk_imx_acm_detach_pm_domains'
>> drivers/clk/imx/clk-imx-acm-utils.c:66: warning: expecting prototype for fsl_dev_detach_pm_domains(). Prototype was for clk_imx_acm_detach_pm_domains() instead


vim +13 drivers/clk/imx/clk-imx-acm-utils.c

     7	
     8	/**
     9	 * clk_imx_acm_attach_pm_domains
    10	 */
    11	int clk_imx_acm_attach_pm_domains(struct device *dev,
    12					  struct clk_imx_acm_pm_domains *dev_pm)
  > 13	{
    14		int ret;
    15		int i;
    16	
    17		dev_pm->num_domains = of_count_phandle_with_args(dev->of_node, "power-domains",
    18								 "#power-domain-cells");
    19		if (dev_pm->num_domains <= 1)
    20			return 0;
    21	
    22		dev_pm->pd_dev = devm_kmalloc_array(dev, dev_pm->num_domains,
    23						    sizeof(*dev_pm->pd_dev),
    24						    GFP_KERNEL);
    25		if (!dev_pm->pd_dev)
    26			return -ENOMEM;
    27	
    28		dev_pm->pd_dev_link = devm_kmalloc_array(dev,
    29							 dev_pm->num_domains,
    30							 sizeof(*dev_pm->pd_dev_link),
    31							 GFP_KERNEL);
    32		if (!dev_pm->pd_dev_link)
    33			return -ENOMEM;
    34	
    35		for (i = 0; i < dev_pm->num_domains; i++) {
    36			dev_pm->pd_dev[i] = dev_pm_domain_attach_by_id(dev, i);
    37			if (IS_ERR(dev_pm->pd_dev[i]))
    38				return PTR_ERR(dev_pm->pd_dev[i]);
    39	
    40			dev_pm->pd_dev_link[i] = device_link_add(dev,
    41								 dev_pm->pd_dev[i],
    42								 DL_FLAG_STATELESS |
    43								 DL_FLAG_PM_RUNTIME |
    44								 DL_FLAG_RPM_ACTIVE);
    45			if (IS_ERR(dev_pm->pd_dev_link[i])) {
    46				dev_pm_domain_detach(dev_pm->pd_dev[i], false);
    47				ret = PTR_ERR(dev_pm->pd_dev_link[i]);
    48				goto detach_pm;
    49			}
    50		}
    51		return 0;
    52	
    53	detach_pm:
    54		while (--i >= 0) {
    55			device_link_del(dev_pm->pd_dev_link[i]);
    56			dev_pm_domain_detach(dev_pm->pd_dev[i], false);
    57		}
    58		return ret;
    59	}
    60	
    61	/**
    62	 * fsl_dev_detach_pm_domains
    63	 */
    64	int clk_imx_acm_detach_pm_domains(struct device *dev,
    65					  struct clk_imx_acm_pm_domains *dev_pm)
  > 66	{

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-09-01 10:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309011838.V5MgfoMq-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.