All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: 3ad8b469-25db-a297-21f9-75db2d6ad224@linux.alibaba.com,gregkh@linuxfoundation.org,hsiangkao@linux.alibaba.com,keltar.gw@gmail.com,linux-erofs@lists.ozlabs.org
Cc: stable-commits@vger.kernel.org
Subject: Patch "erofs: ensure that the post-EOF tails are all zeroed" has been added to the 5.15-stable tree
Date: Sat, 02 Sep 2023 10:20:06 +0200	[thread overview]
Message-ID: <2023090206-lure-affecting-8532@gregkh> (raw)
In-Reply-To: <20230831112959.99884-6-hsiangkao@linux.alibaba.com>


This is a note to let you know that I've just added the patch titled

    erofs: ensure that the post-EOF tails are all zeroed

to the 5.15-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     erofs-ensure-that-the-post-eof-tails-are-all-zeroed.patch
and it can be found in the queue-5.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From hsiangkao@linux.alibaba.com  Sat Sep  2 09:30:52 2023
From: Gao Xiang <hsiangkao@linux.alibaba.com>
Date: Thu, 31 Aug 2023 19:29:58 +0800
Subject: erofs: ensure that the post-EOF tails are all zeroed
To: stable@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-erofs@lists.ozlabs.org, Gao Xiang <hsiangkao@linux.alibaba.com>, keltargw <keltar.gw@gmail.com>
Message-ID: <20230831112959.99884-6-hsiangkao@linux.alibaba.com>

From: Gao Xiang <hsiangkao@linux.alibaba.com>

commit e4c1cf523d820730a86cae2c6d55924833b6f7ac upstream.

This was accidentally fixed up in commit e4c1cf523d82 but we can't
take the full change due to other dependancy issues, so here is just
the actual bugfix that is needed.

[Background]

keltargw reported an issue [1] that with mmaped I/Os, sometimes the
tail of the last page (after file ends) is not filled with zeroes.

The root cause is that such tail page could be wrongly selected for
inplace I/Os so the zeroed part will then be filled with compressed
data instead of zeroes.

A simple fix is to avoid doing inplace I/Os for such tail parts,
actually that was already fixed upstream in commit e4c1cf523d82
("erofs: tidy up z_erofs_do_read_page()") by accident.

[1] https://lore.kernel.org/r/3ad8b469-25db-a297-21f9-75db2d6ad224@linux.alibaba.com

Reported-by: keltargw <keltar.gw@gmail.com>
Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 fs/erofs/zdata.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -716,6 +716,8 @@ hitted:
 	cur = end - min_t(erofs_off_t, offset + end - map->m_la, end);
 	if (!(map->m_flags & EROFS_MAP_MAPPED)) {
 		zero_user_segment(page, cur, end);
+		++spiltted;
+		tight = false;
 		goto next_part;
 	}
 


Patches currently in stable-queue which might be from hsiangkao@linux.alibaba.com are

queue-5.15/erofs-ensure-that-the-post-eof-tails-are-all-zeroed.patch

  parent reply	other threads:[~2023-09-02  8:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 11:29 [PATCH 6.5.y] erofs: ensure that the post-EOF tails are all zeroed Gao Xiang
2023-08-31 11:29 ` Gao Xiang
2023-08-31 11:29 ` [PATCH 6.4.y] " Gao Xiang
2023-08-31 11:29   ` Gao Xiang
2023-08-31 11:29 ` [PATCH 6.1.y] " Gao Xiang
2023-08-31 11:29   ` Gao Xiang
2023-08-31 11:29 ` [PATCH 5.15.y] " Gao Xiang
2023-08-31 11:29   ` Gao Xiang
2023-08-31 11:29 ` [PATCH 5.10.y] " Gao Xiang
2023-08-31 11:29   ` Gao Xiang
2023-08-31 11:29 ` [PATCH 5.4.y] " Gao Xiang
2023-08-31 11:29   ` Gao Xiang
2023-09-02  8:19   ` Patch "erofs: ensure that the post-EOF tails are all zeroed" has been added to the 5.4-stable tree gregkh
2023-09-02  8:19   ` Patch "erofs: ensure that the post-EOF tails are all zeroed" has been added to the 5.10-stable tree gregkh
2023-09-02  8:20   ` gregkh [this message]
2023-09-02  8:20   ` Patch "erofs: ensure that the post-EOF tails are all zeroed" has been added to the 6.1-stable tree gregkh
2023-09-02  8:20   ` Patch "erofs: ensure that the post-EOF tails are all zeroed" has been added to the 6.4-stable tree gregkh
2023-09-02  8:20   ` Patch "erofs: ensure that the post-EOF tails are all zeroed" has been added to the 6.5-stable tree gregkh
2023-08-31 11:29 ` [PATCH 4.19.y] erofs: ensure that the post-EOF tails are all zeroed Gao Xiang
2023-08-31 11:29   ` Gao Xiang
2023-09-02  8:19   ` Patch "erofs: ensure that the post-EOF tails are all zeroed" has been added to the 4.19-stable tree gregkh
2023-09-02  8:19 ` [PATCH 6.5.y] erofs: ensure that the post-EOF tails are all zeroed Greg Kroah-Hartman
2023-09-02  8:19   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023090206-lure-affecting-8532@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=3ad8b469-25db-a297-21f9-75db2d6ad224@linux.alibaba.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=keltar.gw@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=stable-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.