From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()
Date: Sun, 3 Sep 2023 07:59:59 +0800 [thread overview]
Message-ID: <202309030751.GQvtrZnS-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230902090937.32195-3-biju.das.jz@bp.renesas.com>
References: <20230902090937.32195-3-biju.das.jz@bp.renesas.com>
TO: Biju Das <biju.das.jz@bp.renesas.com>
TO: Linus Walleij <linus.walleij@linaro.org>
CC: Biju Das <biju.das.jz@bp.renesas.com>
CC: linux-gpio@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Hi Biju,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next linus/master v6.5 next-20230831]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Biju-Das/pinctrl-mcp23s08-Extend-match-support-for-OF-tables/20230902-171023
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20230902090937.32195-3-biju.das.jz%40bp.renesas.com
patch subject: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()
:::::: branch date: 15 hours ago
:::::: commit date: 15 hours ago
config: i386-randconfig-141-20230902 (https://download.01.org/0day-ci/archive/20230903/202309030751.GQvtrZnS-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230903/202309030751.GQvtrZnS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202309030751.GQvtrZnS-lkp@intel.com/
smatch warnings:
drivers/pinctrl/pinctrl-mcp23s08_i2c.c:33 mcp230xx_probe() error: we previously assumed 'info' could be null (see line 31)
vim +/info +33 drivers/pinctrl/pinctrl-mcp23s08_i2c.c
b5f259f6fc5912 Biju Das 2023-09-02 18
8bb5811129f9e4 Uwe Kleine-König 2022-11-18 19 static int mcp230xx_probe(struct i2c_client *client)
0f04a81784fe3d Andy Shevchenko 2020-04-07 20 {
b5f259f6fc5912 Biju Das 2023-09-02 21 const struct mcp23s08_i2c_info *info;
0f04a81784fe3d Andy Shevchenko 2020-04-07 22 struct device *dev = &client->dev;
0f04a81784fe3d Andy Shevchenko 2020-04-07 23 struct mcp23s08 *mcp;
0f04a81784fe3d Andy Shevchenko 2020-04-07 24 int ret;
0f04a81784fe3d Andy Shevchenko 2020-04-07 25
0f04a81784fe3d Andy Shevchenko 2020-04-07 26 mcp = devm_kzalloc(dev, sizeof(*mcp), GFP_KERNEL);
0f04a81784fe3d Andy Shevchenko 2020-04-07 27 if (!mcp)
0f04a81784fe3d Andy Shevchenko 2020-04-07 28 return -ENOMEM;
0f04a81784fe3d Andy Shevchenko 2020-04-07 29
b5f259f6fc5912 Biju Das 2023-09-02 30 info = i2c_get_match_data(client);
b5f259f6fc5912 Biju Das 2023-09-02 @31 if (!info)
b5f259f6fc5912 Biju Das 2023-09-02 32 return dev_err_probe(dev, -EINVAL, "invalid device type (%d)\n",
b5f259f6fc5912 Biju Das 2023-09-02 @33 info->type);
0f04a81784fe3d Andy Shevchenko 2020-04-07 34
b5f259f6fc5912 Biju Das 2023-09-02 35 mcp->reg_shift = info->reg_shift;
b5f259f6fc5912 Biju Das 2023-09-02 36 mcp->chip.ngpio = info->ngpio;
b5f259f6fc5912 Biju Das 2023-09-02 37 mcp->chip.label = info->label;
b5f259f6fc5912 Biju Das 2023-09-02 38 mcp->regmap = devm_regmap_init_i2c(client, info->regmap);
0f04a81784fe3d Andy Shevchenko 2020-04-07 39 if (IS_ERR(mcp->regmap))
0f04a81784fe3d Andy Shevchenko 2020-04-07 40 return PTR_ERR(mcp->regmap);
0f04a81784fe3d Andy Shevchenko 2020-04-07 41
0f04a81784fe3d Andy Shevchenko 2020-04-07 42 mcp->irq = client->irq;
0f04a81784fe3d Andy Shevchenko 2020-04-07 43 mcp->pinctrl_desc.name = "mcp23xxx-pinctrl";
0f04a81784fe3d Andy Shevchenko 2020-04-07 44
b5f259f6fc5912 Biju Das 2023-09-02 45 ret = mcp23s08_probe_one(mcp, dev, client->addr, info->type, -1);
0f04a81784fe3d Andy Shevchenko 2020-04-07 46 if (ret)
0f04a81784fe3d Andy Shevchenko 2020-04-07 47 return ret;
0f04a81784fe3d Andy Shevchenko 2020-04-07 48
0f04a81784fe3d Andy Shevchenko 2020-04-07 49 i2c_set_clientdata(client, mcp);
0f04a81784fe3d Andy Shevchenko 2020-04-07 50
0f04a81784fe3d Andy Shevchenko 2020-04-07 51 return 0;
0f04a81784fe3d Andy Shevchenko 2020-04-07 52 }
0f04a81784fe3d Andy Shevchenko 2020-04-07 53
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-09-03 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 23:59 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-02 9:09 [PATCH 0/2] Match data improvements for mcp23s08 driver Biju Das
2023-09-02 9:09 ` [PATCH 2/2] pinctrl: mcp23s08: Simplify probe() Biju Das
2023-09-04 9:12 ` Andy Shevchenko
2023-09-05 11:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309030751.GQvtrZnS-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.