All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Qais Yousef <qyousef@layalina.io>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [qais-yousef:generalized-misfit-lb 6/13] kernel/sched/fair.c:4919:19: error: 'struct rq' has no member named 'misfit_reason'
Date: Sun, 3 Sep 2023 08:54:03 +0800	[thread overview]
Message-ID: <202309030849.5DRFYhRY-lkp@intel.com> (raw)

tree:   https://github.com/qais-yousef/linux generalized-misfit-lb
head:   4a3c3c52f83a7b4cfd5248f4e6b3330e178ec3a7
commit: dda165708a2fe535b362a02123143eae6c0a20e8 [6/13] sched/fair: Add a misfit reason
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230903/202309030849.5DRFYhRY-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230903/202309030849.5DRFYhRY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309030849.5DRFYhRY-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/sched/fair.c:702:6: warning: no previous prototype for 'update_entity_lag' [-Wmissing-prototypes]
     702 | void update_entity_lag(struct cfs_rq *cfs_rq, struct sched_entity *se)
         |      ^~~~~~~~~~~~~~~~~
   kernel/sched/fair.c: In function 'update_misfit_status':
>> kernel/sched/fair.c:4919:19: error: 'struct rq' has no member named 'misfit_reason'
    4919 |                 rq->misfit_reason = -1;
         |                   ^~
   kernel/sched/fair.c:4928:11: error: 'struct rq' has no member named 'misfit_reason'
    4928 |         rq->misfit_reason = reason;
         |           ^~
   kernel/sched/fair.c:4911:14: warning: unused variable 'need_update' [-Wunused-variable]
    4911 |         bool need_update = true;
         |              ^~~~~~~~~~~
   kernel/sched/fair.c: In function 'update_sg_lb_stats':
   kernel/sched/fair.c:9712:62: error: 'struct rq' has no member named 'misfit_reason'
    9712 |                                 sgs->group_misfit_reason = rq->misfit_reason;
         |                                                              ^~


vim +4919 kernel/sched/fair.c

  4908	
  4909	static inline void update_misfit_status(struct task_struct *p, struct rq *rq)
  4910	{
  4911		bool need_update = true;
  4912		misfit_reason_t reason;
  4913	
  4914		if (!sched_asym_cpucap_active())
  4915			return;
  4916	
  4917		if (!is_misfit_task(p, rq, &reason)) {
  4918			rq->misfit_task_load = 0;
> 4919			rq->misfit_reason = -1;
  4920			return;
  4921		}
  4922	
  4923		/*
  4924		 * Make sure that misfit_task_load will not be null even if
  4925		 * task_h_load() returns 0.
  4926		 */
  4927		rq->misfit_task_load = max_t(unsigned long, task_h_load(p), 1);
  4928		rq->misfit_reason = reason;
  4929	}
  4930	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-09-03  0:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309030849.5DRFYhRY-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=qyousef@layalina.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.