From: kernel test robot <lkp@intel.com>
To: Qais Yousef <qyousef@layalina.io>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [qais-yousef:uclamp-max-aggregation 2/2] kernel/sched/cpufreq_schedutil.c:285:10: error: call to undeclared function 'uclamp_util_with'; ISO C99 and later do not support implicit function declarations
Date: Sun, 3 Sep 2023 12:12:40 +0800 [thread overview]
Message-ID: <202309031224.6sucWvg7-lkp@intel.com> (raw)
tree: https://github.com/qais-yousef/linux uclamp-max-aggregation
head: 1c5e789f50e8f3bce19ec226e1971186ab7d35c6
commit: 1c5e789f50e8f3bce19ec226e1971186ab7d35c6 [2/2] sched/uclamp: Remove rq max aggregation
config: i386-buildonly-randconfig-004-20230903 (https://download.01.org/0day-ci/archive/20230903/202309031224.6sucWvg7-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230903/202309031224.6sucWvg7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309031224.6sucWvg7-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from kernel/sched/build_utility.c:69:
>> kernel/sched/cpufreq_schedutil.c:285:10: error: call to undeclared function 'uclamp_util_with'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
boost = uclamp_util_with(boost, cpu_rq(sg_cpu->cpu)->curr);
^
kernel/sched/cpufreq_schedutil.c:285:10: note: did you mean 'uclamp_rq_util_with'?
kernel/sched/sched.h:3029:15: note: 'uclamp_rq_util_with' declared here
unsigned long uclamp_rq_util_with(struct rq *rq, unsigned long util,
^
1 error generated.
vim +/uclamp_util_with +285 kernel/sched/cpufreq_schedutil.c
235
236 /**
237 * sugov_iowait_apply() - Apply the IO boost to a CPU.
238 * @sg_cpu: the sugov data for the cpu to boost
239 * @time: the update time from the caller
240 * @max_cap: the max CPU capacity
241 *
242 * A CPU running a task which woken up after an IO operation can have its
243 * utilization boosted to speed up the completion of those IO operations.
244 * The IO boost value is increased each time a task wakes up from IO, in
245 * sugov_iowait_apply(), and it's instead decreased by this function,
246 * each time an increase has not been requested (!iowait_boost_pending).
247 *
248 * A CPU which also appears to have been idle for at least one tick has also
249 * its IO boost utilization reset.
250 *
251 * This mechanism is designed to boost high frequently IO waiting tasks, while
252 * being more conservative on tasks which does sporadic IO operations.
253 */
254 static void sugov_iowait_apply(struct sugov_cpu *sg_cpu, u64 time,
255 unsigned long max_cap)
256 {
257 unsigned long boost;
258
259 /* No boost currently required */
260 if (!sg_cpu->iowait_boost)
261 return;
262
263 /* Reset boost if the CPU appears to have been idle enough */
264 if (sugov_iowait_reset(sg_cpu, time, false))
265 return;
266
267 if (!sg_cpu->iowait_boost_pending) {
268 /*
269 * No boost pending; reduce the boost value.
270 */
271 sg_cpu->iowait_boost >>= 1;
272 if (sg_cpu->iowait_boost < IOWAIT_BOOST_MIN) {
273 sg_cpu->iowait_boost = 0;
274 return;
275 }
276 }
277
278 sg_cpu->iowait_boost_pending = false;
279
280 /*
281 * sg_cpu->util is already in capacity scale; convert iowait_boost
282 * into the same scale so we can compare.
283 */
284 boost = (sg_cpu->iowait_boost * max_cap) >> SCHED_CAPACITY_SHIFT;
> 285 boost = uclamp_util_with(boost, cpu_rq(sg_cpu->cpu)->curr);
286 if (sg_cpu->util < boost)
287 sg_cpu->util = boost;
288 }
289
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-09-03 4:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309031224.6sucWvg7-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=qyousef@layalina.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.