From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBADBC83F2C for ; Mon, 4 Sep 2023 00:00:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241998AbjIDAAK convert rfc822-to-8bit (ORCPT ); Sun, 3 Sep 2023 20:00:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231361AbjIDAAJ (ORCPT ); Sun, 3 Sep 2023 20:00:09 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B4B21C4; Sun, 3 Sep 2023 17:00:05 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF8CE165C; Sun, 3 Sep 2023 17:00:43 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 072F13F766; Sun, 3 Sep 2023 17:00:03 -0700 (PDT) Date: Mon, 4 Sep 2023 00:58:55 +0100 From: Andre Przywara To: Christophe JAILLET Cc: Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] phy: sun4i-usb: Fix a W=1 compilation failure Message-ID: <20230904005855.658819b3@slackpad.lan> In-Reply-To: <0bc81612171baaa6d5dff58c8e009debc03e1ba8.1693735840.git.christophe.jaillet@wanadoo.fr> References: <0bc81612171baaa6d5dff58c8e009debc03e1ba8.1693735840.git.christophe.jaillet@wanadoo.fr> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Sun, 3 Sep 2023 12:11:06 +0200 Christophe JAILLET wrote: > With gcc 12.3.0, when this file is built, we get errors such as: > > drivers/phy/allwinner/phy-sun4i-usb.c: In function ‘sun4i_usb_phy_probe’: > drivers/phy/allwinner/phy-sun4i-usb.c:790:52: error: ‘_vbus’ directive output may be truncated writing 5 bytes into a region of size between 2 and 12 [-Werror=format-truncation=] > 790 | snprintf(name, sizeof(name), "usb%d_vbus", i); > | ^~~~~ > drivers/phy/allwinner/phy-sun4i-usb.c:790:17: note: ‘snprintf’ output between 10 and 20 bytes into a destination of size 16 > 790 | snprintf(name, sizeof(name), "usb%d_vbus", i); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Because of the possible value of 'i', this can't be an issue in real world Would using "u8 i;" help? After all currently there are only 4 PHYs max, and in general this isn't expected to be more than a "handful", so 8 bits should be plenty. An unsigned is better anyway. It leaves a bit of a bitter taste, though, as we shouldn't do this kind type tweaking, especially not to work around the compiler trying to be clever, but then not seeing the whole picture (that "i" is bounded by compile time constants not exceeding "4"). Cheers, Andre > application, but in order to have "make W=1" work correctly, give more > space for 'name'. > > Signed-off-by: Christophe JAILLET > --- > drivers/phy/allwinner/phy-sun4i-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c > index ec551464dd4f..e53a9a9317bc 100644 > --- a/drivers/phy/allwinner/phy-sun4i-usb.c > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > @@ -782,7 +782,7 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev) > > for (i = 0; i < data->cfg->num_phys; i++) { > struct sun4i_usb_phy *phy = data->phys + i; > - char name[16]; > + char name[32]; > > if (data->cfg->missing_phys & BIT(i)) > continue; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09158C83F2C for ; Mon, 4 Sep 2023 00:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WktUu/vh6n+X6/j8HPsdevB5ftf5igpYl0RCJtuoIxI=; b=Vt5m3KqjdCdfwT 1D7Cqnuyswq9EnQs4KaXBIWwMryAzs+ziUzDVb1n2TNrRRJ7z6Tqf9zk31+mdo1p1jbC4SLuWk3bO FENuWNzuIkRUHQOAYooDJDZRonNtJdAgGYanqqNEHnxu44o1fIamMqF5SVBOWWvBIr8ln0pAgs4en 6x5Bz83J+5a13DzOLhHt12M/kbApxIU2sXq3gjNnpnqZ6vzOrRsfk7D5faStFbanrFmiHVMBjJKsC G06D3N5GoVPqUEHkNXIcgkB7VNqZaV0/2vB4C7eBKv0MpTfSVfmFsbKKfoO18AOXawb5F2fo71eb0 +obxPVB0ntIwQXxrGcsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qcx0q-00336t-21; Mon, 04 Sep 2023 00:00:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qcx0l-00335O-2h; Mon, 04 Sep 2023 00:00:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF8CE165C; Sun, 3 Sep 2023 17:00:43 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 072F13F766; Sun, 3 Sep 2023 17:00:03 -0700 (PDT) Date: Mon, 4 Sep 2023 00:58:55 +0100 From: Andre Przywara To: Christophe JAILLET Cc: Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] phy: sun4i-usb: Fix a W=1 compilation failure Message-ID: <20230904005855.658819b3@slackpad.lan> In-Reply-To: <0bc81612171baaa6d5dff58c8e009debc03e1ba8.1693735840.git.christophe.jaillet@wanadoo.fr> References: <0bc81612171baaa6d5dff58c8e009debc03e1ba8.1693735840.git.christophe.jaillet@wanadoo.fr> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230903_170011_948791_C9DB920F X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gU3VuLCAgMyBTZXAgMjAyMyAxMjoxMTowNiArMDIwMApDaHJpc3RvcGhlIEpBSUxMRVQgPGNo cmlzdG9waGUuamFpbGxldEB3YW5hZG9vLmZyPiB3cm90ZToKCj4gV2l0aCBnY2MgMTIuMy4wLCB3 aGVuIHRoaXMgZmlsZSBpcyBidWlsdCwgd2UgZ2V0IGVycm9ycyBzdWNoIGFzOgo+IAo+IGRyaXZl cnMvcGh5L2FsbHdpbm5lci9waHktc3VuNGktdXNiLmM6IEluIGZ1bmN0aW9uIOKAmHN1bjRpX3Vz Yl9waHlfcHJvYmXigJk6Cj4gZHJpdmVycy9waHkvYWxsd2lubmVyL3BoeS1zdW40aS11c2IuYzo3 OTA6NTI6IGVycm9yOiDigJhfdmJ1c+KAmSBkaXJlY3RpdmUgb3V0cHV0IG1heSBiZSB0cnVuY2F0 ZWQgd3JpdGluZyA1IGJ5dGVzIGludG8gYSByZWdpb24gb2Ygc2l6ZSBiZXR3ZWVuIDIgYW5kIDEy IFstV2Vycm9yPWZvcm1hdC10cnVuY2F0aW9uPV0KPiAgIDc5MCB8ICAgICAgICAgICAgICAgICBz bnByaW50ZihuYW1lLCBzaXplb2YobmFtZSksICJ1c2IlZF92YnVzIiwgaSk7Cj4gICAgICAgfCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fgo+ IGRyaXZlcnMvcGh5L2FsbHdpbm5lci9waHktc3VuNGktdXNiLmM6NzkwOjE3OiBub3RlOiDigJhz bnByaW50ZuKAmSBvdXRwdXQgYmV0d2VlbiAxMCBhbmQgMjAgYnl0ZXMgaW50byBhIGRlc3RpbmF0 aW9uIG9mIHNpemUgMTYKPiAgIDc5MCB8ICAgICAgICAgICAgICAgICBzbnByaW50ZihuYW1lLCBz aXplb2YobmFtZSksICJ1c2IlZF92YnVzIiwgaSk7Cj4gICAgICAgfCAgICAgICAgICAgICAgICAg Xn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gCj4gQmVjYXVz ZSBvZiB0aGUgcG9zc2libGUgdmFsdWUgb2YgJ2knLCB0aGlzIGNhbid0IGJlIGFuIGlzc3VlIGlu IHJlYWwgd29ybGQKCldvdWxkIHVzaW5nICJ1OCBpOyIgaGVscD8gQWZ0ZXIgYWxsIGN1cnJlbnRs eSB0aGVyZSBhcmUgb25seSA0IFBIWXMKbWF4LCBhbmQgaW4gZ2VuZXJhbCB0aGlzIGlzbid0IGV4 cGVjdGVkIHRvIGJlIG1vcmUgdGhhbiBhICJoYW5kZnVsIiwgc28KOCBiaXRzIHNob3VsZCBiZSBw bGVudHkuIEFuIHVuc2lnbmVkIGlzIGJldHRlciBhbnl3YXkuCkl0IGxlYXZlcyBhIGJpdCBvZiBh IGJpdHRlciB0YXN0ZSwgdGhvdWdoLCBhcyB3ZSBzaG91bGRuJ3QgZG8gdGhpcyBraW5kCnR5cGUg dHdlYWtpbmcsIGVzcGVjaWFsbHkgbm90IHRvIHdvcmsgYXJvdW5kIHRoZSBjb21waWxlciB0cnlp bmcgdG8gYmUKY2xldmVyLCBidXQgdGhlbiBub3Qgc2VlaW5nIHRoZSB3aG9sZSBwaWN0dXJlICh0 aGF0ICJpIiBpcyBib3VuZGVkIGJ5CmNvbXBpbGUgdGltZSBjb25zdGFudHMgbm90IGV4Y2VlZGlu ZyAiNCIpLgoKQ2hlZXJzLApBbmRyZQoKPiBhcHBsaWNhdGlvbiwgYnV0IGluIG9yZGVyIHRvIGhh dmUgIm1ha2UgVz0xIiB3b3JrIGNvcnJlY3RseSwgZ2l2ZSBtb3JlCj4gc3BhY2UgZm9yICduYW1l Jy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGhlIEpBSUxMRVQgPGNocmlzdG9waGUuamFp bGxldEB3YW5hZG9vLmZyPgo+IC0tLQo+ICBkcml2ZXJzL3BoeS9hbGx3aW5uZXIvcGh5LXN1bjRp LXVzYi5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvYWxsd2lubmVyL3BoeS1zdW40aS11 c2IuYyBiL2RyaXZlcnMvcGh5L2FsbHdpbm5lci9waHktc3VuNGktdXNiLmMKPiBpbmRleCBlYzU1 MTQ2NGRkNGYuLmU1M2E5YTkzMTdiYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BoeS9hbGx3aW5u ZXIvcGh5LXN1bjRpLXVzYi5jCj4gKysrIGIvZHJpdmVycy9waHkvYWxsd2lubmVyL3BoeS1zdW40 aS11c2IuYwo+IEBAIC03ODIsNyArNzgyLDcgQEAgc3RhdGljIGludCBzdW40aV91c2JfcGh5X3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAo+ICAJZm9yIChpID0gMDsgaSA8 IGRhdGEtPmNmZy0+bnVtX3BoeXM7IGkrKykgewo+ICAJCXN0cnVjdCBzdW40aV91c2JfcGh5ICpw aHkgPSBkYXRhLT5waHlzICsgaTsKPiAtCQljaGFyIG5hbWVbMTZdOwo+ICsJCWNoYXIgbmFtZVsz Ml07Cj4gIAo+ICAJCWlmIChkYXRhLT5jZmctPm1pc3NpbmdfcGh5cyAmIEJJVChpKSkKPiAgCQkJ Y29udGludWU7CgoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 776E4C83F2D for ; Mon, 4 Sep 2023 00:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vIKjWavwf4mxVIYvaxgc6y12+muuQuGMLZvysvbdW3Y=; b=yEcpuBwLuYS7vb JU0Y5XqrBUhN88SpOo1SF0Og2akMBIt0Saq74D7knhLmp3R6p/Y4J+JK6YFyhJQtVihwsRqAvUZ3N kRLZqG4BLnvB93FzbuMkN145oQunHzWQtHD5536HhyPVMRkQSVCzrD/rvzTl/EGHVZg837/E4vgJ8 fmfNRfOyogXjwObN5QWZsqzdbt20cUivZwUZ8thrIZfCyO1sC5UpnlS7WzEcbut36DyGGsQQXD6Dq VVopcd9r0BrdH4PBniS0Q5B3B2tlT3nBRj3FHg3Gd7RTExMzt1iROj+ksVFNFKD29Ahfb9JSaq5M8 wKJZwENKfFQmpFJ1gZoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qcx0q-00336Q-0e; Mon, 04 Sep 2023 00:00:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qcx0l-00335O-2h; Mon, 04 Sep 2023 00:00:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF8CE165C; Sun, 3 Sep 2023 17:00:43 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 072F13F766; Sun, 3 Sep 2023 17:00:03 -0700 (PDT) Date: Mon, 4 Sep 2023 00:58:55 +0100 From: Andre Przywara To: Christophe JAILLET Cc: Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] phy: sun4i-usb: Fix a W=1 compilation failure Message-ID: <20230904005855.658819b3@slackpad.lan> In-Reply-To: <0bc81612171baaa6d5dff58c8e009debc03e1ba8.1693735840.git.christophe.jaillet@wanadoo.fr> References: <0bc81612171baaa6d5dff58c8e009debc03e1ba8.1693735840.git.christophe.jaillet@wanadoo.fr> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230903_170011_948791_C9DB920F X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAgMyBTZXAgMjAyMyAxMjoxMTowNiArMDIwMApDaHJpc3RvcGhlIEpBSUxMRVQgPGNo cmlzdG9waGUuamFpbGxldEB3YW5hZG9vLmZyPiB3cm90ZToKCj4gV2l0aCBnY2MgMTIuMy4wLCB3 aGVuIHRoaXMgZmlsZSBpcyBidWlsdCwgd2UgZ2V0IGVycm9ycyBzdWNoIGFzOgo+IAo+IGRyaXZl cnMvcGh5L2FsbHdpbm5lci9waHktc3VuNGktdXNiLmM6IEluIGZ1bmN0aW9uIOKAmHN1bjRpX3Vz Yl9waHlfcHJvYmXigJk6Cj4gZHJpdmVycy9waHkvYWxsd2lubmVyL3BoeS1zdW40aS11c2IuYzo3 OTA6NTI6IGVycm9yOiDigJhfdmJ1c+KAmSBkaXJlY3RpdmUgb3V0cHV0IG1heSBiZSB0cnVuY2F0 ZWQgd3JpdGluZyA1IGJ5dGVzIGludG8gYSByZWdpb24gb2Ygc2l6ZSBiZXR3ZWVuIDIgYW5kIDEy IFstV2Vycm9yPWZvcm1hdC10cnVuY2F0aW9uPV0KPiAgIDc5MCB8ICAgICAgICAgICAgICAgICBz bnByaW50ZihuYW1lLCBzaXplb2YobmFtZSksICJ1c2IlZF92YnVzIiwgaSk7Cj4gICAgICAgfCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fgo+ IGRyaXZlcnMvcGh5L2FsbHdpbm5lci9waHktc3VuNGktdXNiLmM6NzkwOjE3OiBub3RlOiDigJhz bnByaW50ZuKAmSBvdXRwdXQgYmV0d2VlbiAxMCBhbmQgMjAgYnl0ZXMgaW50byBhIGRlc3RpbmF0 aW9uIG9mIHNpemUgMTYKPiAgIDc5MCB8ICAgICAgICAgICAgICAgICBzbnByaW50ZihuYW1lLCBz aXplb2YobmFtZSksICJ1c2IlZF92YnVzIiwgaSk7Cj4gICAgICAgfCAgICAgICAgICAgICAgICAg Xn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gCj4gQmVjYXVz ZSBvZiB0aGUgcG9zc2libGUgdmFsdWUgb2YgJ2knLCB0aGlzIGNhbid0IGJlIGFuIGlzc3VlIGlu IHJlYWwgd29ybGQKCldvdWxkIHVzaW5nICJ1OCBpOyIgaGVscD8gQWZ0ZXIgYWxsIGN1cnJlbnRs eSB0aGVyZSBhcmUgb25seSA0IFBIWXMKbWF4LCBhbmQgaW4gZ2VuZXJhbCB0aGlzIGlzbid0IGV4 cGVjdGVkIHRvIGJlIG1vcmUgdGhhbiBhICJoYW5kZnVsIiwgc28KOCBiaXRzIHNob3VsZCBiZSBw bGVudHkuIEFuIHVuc2lnbmVkIGlzIGJldHRlciBhbnl3YXkuCkl0IGxlYXZlcyBhIGJpdCBvZiBh IGJpdHRlciB0YXN0ZSwgdGhvdWdoLCBhcyB3ZSBzaG91bGRuJ3QgZG8gdGhpcyBraW5kCnR5cGUg dHdlYWtpbmcsIGVzcGVjaWFsbHkgbm90IHRvIHdvcmsgYXJvdW5kIHRoZSBjb21waWxlciB0cnlp bmcgdG8gYmUKY2xldmVyLCBidXQgdGhlbiBub3Qgc2VlaW5nIHRoZSB3aG9sZSBwaWN0dXJlICh0 aGF0ICJpIiBpcyBib3VuZGVkIGJ5CmNvbXBpbGUgdGltZSBjb25zdGFudHMgbm90IGV4Y2VlZGlu ZyAiNCIpLgoKQ2hlZXJzLApBbmRyZQoKPiBhcHBsaWNhdGlvbiwgYnV0IGluIG9yZGVyIHRvIGhh dmUgIm1ha2UgVz0xIiB3b3JrIGNvcnJlY3RseSwgZ2l2ZSBtb3JlCj4gc3BhY2UgZm9yICduYW1l Jy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGhlIEpBSUxMRVQgPGNocmlzdG9waGUuamFp bGxldEB3YW5hZG9vLmZyPgo+IC0tLQo+ICBkcml2ZXJzL3BoeS9hbGx3aW5uZXIvcGh5LXN1bjRp LXVzYi5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvYWxsd2lubmVyL3BoeS1zdW40aS11 c2IuYyBiL2RyaXZlcnMvcGh5L2FsbHdpbm5lci9waHktc3VuNGktdXNiLmMKPiBpbmRleCBlYzU1 MTQ2NGRkNGYuLmU1M2E5YTkzMTdiYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BoeS9hbGx3aW5u ZXIvcGh5LXN1bjRpLXVzYi5jCj4gKysrIGIvZHJpdmVycy9waHkvYWxsd2lubmVyL3BoeS1zdW40 aS11c2IuYwo+IEBAIC03ODIsNyArNzgyLDcgQEAgc3RhdGljIGludCBzdW40aV91c2JfcGh5X3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAo+ICAJZm9yIChpID0gMDsgaSA8 IGRhdGEtPmNmZy0+bnVtX3BoeXM7IGkrKykgewo+ICAJCXN0cnVjdCBzdW40aV91c2JfcGh5ICpw aHkgPSBkYXRhLT5waHlzICsgaTsKPiAtCQljaGFyIG5hbWVbMTZdOwo+ICsJCWNoYXIgbmFtZVsz Ml07Cj4gIAo+ICAJCWlmIChkYXRhLT5jZmctPm1pc3NpbmdfcGh5cyAmIEJJVChpKSkKPiAgCQkJ Y29udGludWU7CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=