Re: [PATCH 3/3] ARM: boards: Add MyirTech MYD-YA15XC-T development board support

[Sascha Hauer <sha@pengutronix.de>]

Hi Alexander,

On Thu, Aug 31, 2023 at 09:40:16AM +0300, Alexander Shiyan wrote:
> Hello Ahmad.
> 
> > Thanks for your patch. A few comments below.
> ...
> > > +ENTRY_FUNCTION(start_stm32mp15x_myir, r0, r1, r2)
> > > +{
> > > +     void *fdt;
> > > +
> > > +     stm32mp_cpu_lowlevel_init();
> > > +
> > > +     if (IS_ENABLED(CONFIG_DEBUG_LL))
> > > +             setup_uart();
> > > +
> > > +     fdt = __dtb_z_stm32mp15x_myirtech_myd_start + get_runtime_offset();
> > > +
> > > +     stm32mp1_barebox_entry(fdt);
> >
> > Same question: Do you use an old TF-A or why do you need a specific entry
> > point instead of barebox-stm32mp-generic-bl33.img?
> 
> Initially, I used the old version of TF-A, to facilitate the first
> start-up of the board.
> Now I'm using new version and FIP, so yes, this piece of code can be removed.
> 
> Thanks for the comments on the patch, I'll rework some parts of the code.
> 
> 2 Sascha: Is it possible to commit the first two parts of the patch
> now to minimize the overall work?

Just did that.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |