From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5454CA0FF8 for ; Tue, 5 Sep 2023 17:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353168AbjIERFy (ORCPT ); Tue, 5 Sep 2023 13:05:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353775AbjIEIGX (ORCPT ); Tue, 5 Sep 2023 04:06:23 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79703100; Tue, 5 Sep 2023 01:06:18 -0700 (PDT) Date: Tue, 5 Sep 2023 10:06:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1693901176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bsH+RtpEg9vwuvIPoOMrUZaAm44ymKYNQDqVuCFwR1E=; b=uKTJOBK+OTlCoN+U1ji+35EqoHQ8iKidB5lZ6fHgexkjUhNj9bpybKUJMOBEkk8oIoz6l+ 6w6/2A5rqUXvVJfAlJ+QMfaujUNgS214vSw/gRJxS7pMmJUXUy4tk8bP2mkEgxlxm7p9QI g1Hm6pIvWUDsZs73kltrdp+d4XunCZVTbA6EOG87zmOfCL+HsaF5yysX30PApn7zwFlymu XHS2zXCfo2k7qbe91jHJqij//h+0RFYXYTaruOGUshPe0coGK9QZLTFSQwczA6Tn1um+7G lsQFDI+6CEK6oDZQBQnpjABtnaDQ5yuQpJalakzCZ7SmnNhFpxRgrmGIH+8Wng== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1693901176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bsH+RtpEg9vwuvIPoOMrUZaAm44ymKYNQDqVuCFwR1E=; b=oA1okqf9iAhC+/eLtGjdE0wtJjEtyhD8/x1KbNdZJhNq070aOCj91JOMYfEy2iy1hKmVdn U+grph8F1+OgPUDw== From: Sebastian Andrzej Siewior To: Lukasz Majewski Cc: Tristram.Ha@microchip.com, Eric Dumazet , davem@davemloft.net, Andrew Lunn , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Kristian Overskeid , Matthieu Baerts , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Oetken Subject: Re: [PATCH] net: hsr : Provide fix for HSRv1 supervisor frames decoding Message-ID: <20230905080614.ImjTS6iw@linutronix.de> References: <20230825153111.228768-1-lukma@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230825153111.228768-1-lukma@denx.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-08-25 17:31:11 [+0200], Lukasz Majewski wrote: > Provide fix to decode correctly supervisory frames when HSRv1 version of > the HSR protocol is used. >=20 > Without this patch console is polluted with: > ksz-switch spi1.0 lan1: hsr_addr_subst_dest: Unknown node >=20 > as a result of destination node's A MAC address equals to: > 00:00:00:00:00:00. >=20 > cat /sys/kernel/debug/hsr/hsr0/node_table > Node Table entries for (HSR) device > MAC-Address-A, MAC-Address-B, time_in[A], time_in[B], Address-B > 00:00:00:00:00:00 00:10:a1:94:77:30 400bf, 399c, 0 >=20 > It was caused by wrong frames decoding in the hsr_handle_sup_frame(). >=20 > As the supervisor frame is encapsulated in HSRv1 frame: >=20 > SKB_I100000000: 01 15 4e 00 01 2d 00 10 a1 94 77 30 89 2f 00 34 > SKB_I100000010: 02 59 88 fb 00 01 84 15 17 06 00 10 a1 94 77 30 > SKB_I100000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > SKB_I100000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > SKB_I100000040: 00 00 >=20 > The code had to be adjusted accordingly and the MAC-Address-A now > has the proper address (the MAC-Address-B now has all 0's). Was this broken by commit eafaa88b3eb7f ("net: hsr: Add support for redbox supervision frames") ? Is this frame somehow special? I don't remember this=E2=80=A6 > Signed-off-by: Lukasz Majewski Sebastian