From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B29D6C83F3E for ; Tue, 5 Sep 2023 15:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YGNeTD4wc0uiy0pmco52060xm09wKYo/edTUCL1BFsU=; b=a73fmL59x755g7 LcDG1XW4gLz7UoCY++w5zj8Z4Efpo6qnFSi82+ELCEgKsH8NhyEQwOV+lfMOdZpoV3p9CF8WDxntk +SYtIc9T9qXnzwfTe0Y8pgV/dwzxREng6wT0rGzNHRa6sWLrrF2cGkAFw27kLW9EHC/vuPB7T7MN8 4/JRFj3NbSH2m62qGbS/+FE4+R3cWGHrM7FlLrJ25zwem9GHDui0oAds25fpQmy+bnM6Hhg+/CZWe VANWd9TdCOjbVgmzZ1nuulbo/DZmiQvcJufra3LAPOOAC7zArQqllKG8OvkwRHFTzSPXtD0HJ+5v7 1EIJxm+RN83D/Rkj+lFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdY5b-006Gds-2J; Tue, 05 Sep 2023 15:35:39 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdY5Y-006Gd4-2S for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 15:35:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6932ACE10C2; Tue, 5 Sep 2023 15:35:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81D84C433C7; Tue, 5 Sep 2023 15:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693928130; bh=xOSL6yYjiLcHcyG/8cCVGMIG/NpsWnq3fQuWh4NECP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BRLubsjzzO3t7dANy45kF0GwDU0fizq/mRFrtJYJX+vh2UkxKzPmUpG3Xcg2oGbLn b7pK4K3YO6Jgrn7Ei+VLwlp4wmBaP2PPF/pXOnK/XSf5hnA4jvWo/IXFerSpXkysA/ O+Pfgtxe3PVy79GaLtZ5PxWUOArAEKZqoWyxro+11S81thKzaSVaFvc4jOVv2TYqhe 5shVS6Rk1/daJZ0ygMbsDFuGjGvhjeasp8jxt+XoTaxfblZCP2b0gS7HjHVFrecIfN LDM0i0pBxa8BrPrbD8nbpeQA6KdEF8CDtuPsZh7bcqeCMOpp+vhn7sgbh7Yb8pUqYB LiYztYNUw1+/w== Received: (nullmailer pid 3432654 invoked by uid 1000); Tue, 05 Sep 2023 15:35:28 -0000 Date: Tue, 5 Sep 2023 10:35:28 -0500 From: Rob Herring To: Suzuki K Poulose Cc: Linu Cherian , mike.leach@linaro.org, james.clark@arm.com, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, sgoutham@marvell.com, gcherian@marvell.com Subject: Re: [RFC PATCH v3 1/7] dt-bindings: arm: coresight-tmc: Add "memory-region" property Message-ID: <20230905153528.GA3428758-robh@kernel.org> References: <20230904050548.28047-1-lcherian@marvell.com> <20230904050548.28047-2-lcherian@marvell.com> <59bf237d-1645-8c44-94f2-72a0cf229595@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <59bf237d-1645-8c44-94f2-72a0cf229595@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_083537_006259_38A8EFEE X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 04, 2023 at 09:26:49AM +0100, Suzuki K Poulose wrote: > On 04/09/2023 06:05, Linu Cherian wrote: > > memory-region 0: Reserved trace buffer memory > > > > TMC ETR: When available, use this reserved memory region for > > trace data capture. Same region is used for trace data > > retention after a panic or watchdog reset. > > > > TMC ETF: When available, use this reserved memory region for > > trace data retention synced from internal SRAM after a panic or > > watchdog reset. > > > > memory-region 1: Reserved meta data memory > > > > TMC ETR, ETF: When available, use this memory for register > > snapshot retention synced from hardware registers after a panic > > or watchdog reset. > > Instead of having to use a number to map the memory regions, could > we use > > memory-region-names property to describe the index ? That way it > is much easier to read and is less error prone. You can, but the order should still be defined. > Names could be something like: > > tmc-reserved-trace > tmc-reserved-metadata Names are local to the binding. So 'tmc' is redundant. And everything is a reserved region for 'memory-region', so that's redundant too. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F41C83F2C for ; Tue, 5 Sep 2023 16:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348982AbjIEQV0 (ORCPT ); Tue, 5 Sep 2023 12:21:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354896AbjIEPfg (ORCPT ); Tue, 5 Sep 2023 11:35:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A6BB133; Tue, 5 Sep 2023 08:35:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A72660A1D; Tue, 5 Sep 2023 15:35:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81D84C433C7; Tue, 5 Sep 2023 15:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693928130; bh=xOSL6yYjiLcHcyG/8cCVGMIG/NpsWnq3fQuWh4NECP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BRLubsjzzO3t7dANy45kF0GwDU0fizq/mRFrtJYJX+vh2UkxKzPmUpG3Xcg2oGbLn b7pK4K3YO6Jgrn7Ei+VLwlp4wmBaP2PPF/pXOnK/XSf5hnA4jvWo/IXFerSpXkysA/ O+Pfgtxe3PVy79GaLtZ5PxWUOArAEKZqoWyxro+11S81thKzaSVaFvc4jOVv2TYqhe 5shVS6Rk1/daJZ0ygMbsDFuGjGvhjeasp8jxt+XoTaxfblZCP2b0gS7HjHVFrecIfN LDM0i0pBxa8BrPrbD8nbpeQA6KdEF8CDtuPsZh7bcqeCMOpp+vhn7sgbh7Yb8pUqYB LiYztYNUw1+/w== Received: (nullmailer pid 3432654 invoked by uid 1000); Tue, 05 Sep 2023 15:35:28 -0000 Date: Tue, 5 Sep 2023 10:35:28 -0500 From: Rob Herring To: Suzuki K Poulose Cc: Linu Cherian , mike.leach@linaro.org, james.clark@arm.com, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, sgoutham@marvell.com, gcherian@marvell.com Subject: Re: [RFC PATCH v3 1/7] dt-bindings: arm: coresight-tmc: Add "memory-region" property Message-ID: <20230905153528.GA3428758-robh@kernel.org> References: <20230904050548.28047-1-lcherian@marvell.com> <20230904050548.28047-2-lcherian@marvell.com> <59bf237d-1645-8c44-94f2-72a0cf229595@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59bf237d-1645-8c44-94f2-72a0cf229595@arm.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 04, 2023 at 09:26:49AM +0100, Suzuki K Poulose wrote: > On 04/09/2023 06:05, Linu Cherian wrote: > > memory-region 0: Reserved trace buffer memory > > > > TMC ETR: When available, use this reserved memory region for > > trace data capture. Same region is used for trace data > > retention after a panic or watchdog reset. > > > > TMC ETF: When available, use this reserved memory region for > > trace data retention synced from internal SRAM after a panic or > > watchdog reset. > > > > memory-region 1: Reserved meta data memory > > > > TMC ETR, ETF: When available, use this memory for register > > snapshot retention synced from hardware registers after a panic > > or watchdog reset. > > Instead of having to use a number to map the memory regions, could > we use > > memory-region-names property to describe the index ? That way it > is much easier to read and is less error prone. You can, but the order should still be defined. > Names could be something like: > > tmc-reserved-trace > tmc-reserved-metadata Names are local to the binding. So 'tmc' is redundant. And everything is a reserved region for 'memory-region', so that's redundant too. Rob