From: Oleg Nesterov <oleg@redhat.com>
To: Yonghong Song <yonghong.song@linux.dev>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Kui-Feng Lee <sinquersw@gmail.com>,
bpf@vger.kernel.org
Subject: [PATCH bpf-next v2 3/5] bpf: task_group_seq_get_next: fix the skip_if_dup_files check
Date: Tue, 5 Sep 2023 17:46:51 +0200 [thread overview]
Message-ID: <20230905154651.GA24940@redhat.com> (raw)
In-Reply-To: <20230905154612.GA24872@redhat.com>
Unless I am notally confused it is wrong. We are going to return or
skip next_task so we need to check next_task-files, not task->files.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
---
kernel/bpf/task_iter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/task_iter.c b/kernel/bpf/task_iter.c
index 1589ec3faded..2264870ae3fc 100644
--- a/kernel/bpf/task_iter.c
+++ b/kernel/bpf/task_iter.c
@@ -82,7 +82,7 @@ static struct task_struct *task_group_seq_get_next(struct bpf_iter_seq_task_comm
common->pid_visiting = *tid;
- if (skip_if_dup_files && task->files == task->group_leader->files) {
+ if (skip_if_dup_files && next_task->files == next_task->group_leader->files) {
task = next_task;
goto retry;
}
--
2.25.1.362.g51ebf55
next prev parent reply other threads:[~2023-09-05 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 15:46 [PATCH bpf-next v2 0/5] bpf: task_group_seq_get_next: misc cleanups Oleg Nesterov
2023-09-05 15:46 ` [PATCH bpf-next v2 1/5] bpf: task_group_seq_get_next: cleanup the usage of next_thread() Oleg Nesterov
2023-09-05 15:46 ` [PATCH bpf-next v2 2/5] bpf: task_group_seq_get_next: cleanup the usage of get/put_task_struct Oleg Nesterov
2023-09-05 15:46 ` Oleg Nesterov [this message]
2023-09-05 15:46 ` [PATCH bpf-next v2 4/5] bpf: task_group_seq_get_next: kill next_task Oleg Nesterov
2023-09-05 15:46 ` [PATCH bpf-next v2 5/5] bpf: task_group_seq_get_next: simplify the "next tid" logic Oleg Nesterov
2023-09-05 19:58 ` [PATCH bpf-next v2 0/5] bpf: task_group_seq_get_next: misc cleanups Oleg Nesterov
2023-09-06 20:00 ` Alexei Starovoitov
2023-09-07 6:44 ` Oleg Nesterov
2023-09-07 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905154651.GA24940@redhat.com \
--to=oleg@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=sinquersw@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.