All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Milan P. Stanić" <mps@arvanta.net>
To: Tom Rini <triniatkonsulko.com@m1>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] riscv: Correct event usage for riscv_cpu_probe/setup
Date: Tue, 5 Sep 2023 19:20:54 +0200	[thread overview]
Message-ID: <20230905172054.GB29543@m1> (raw)
In-Reply-To: <20230904190635.3896494-2-trini@konsulko.com>

On Mon, 2023-09-04 at 15:06, Tom Rini wrote:
> With having both an EVENT_SPY_SIMPLE setup for both riscv_cpu_probe and
> riscv_cpu_setup we do not need the latter function to call the former
> function as it will already have been done in time.
> 
> Fixes: 1c55d62fb9cc ("riscv: cpu: make riscv_cpu_probe to EVT_DM_POST_INIT_R callback")
> Signed-off-by: Tom Rini <trini at konsulko.com>
Tested-by: Milan P. Stanić <mps@arvanta.net>

> ---
> Cc: Rick Chen <rick at andestech.com>
> Cc: Leo Yu-Chi Liang  <ycliang at andestech.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Nikita Shubin <n.shubin at yadro.com>
> Cc: Chanho Park <chanho61.park at samsung.com>
> Cc: Yu Chien Peter Lin <peterlin at andestech.com>
> ---
>  arch/riscv/cpu/cpu.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/riscv/cpu/cpu.c b/arch/riscv/cpu/cpu.c
> index cfe9fdc9df55..c1a9638c1ab7 100644
> --- a/arch/riscv/cpu/cpu.c
> +++ b/arch/riscv/cpu/cpu.c
> @@ -94,11 +94,7 @@ static void dummy_pending_ipi_clear(ulong hart, ulong arg0, ulong arg1)
>  
>  int riscv_cpu_setup(void)
>  {
> -	int ret;
> -
> -	ret = riscv_cpu_probe(ctx, event);
> -	if (ret)
> -		return ret;
> +	int __maybe_unused ret;
>  
>  	/* Enable FPU */
>  	if (supports_extension('d') || supports_extension('f')) {
> -- 
> 2.34.1
> 

  reply	other threads:[~2023-09-05 17:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 19:06 [PATCH 1/2] riscv: Rework riscv_cpu_probe for current event macros Tom Rini
2023-09-04 19:06 ` [PATCH 2/2] riscv: Correct event usage for riscv_cpu_probe/setup Tom Rini
2023-09-05 17:20   ` Milan P. Stanić [this message]
2023-09-05  3:01 ` [PATCH 1/2] riscv: Rework riscv_cpu_probe for current event macros Leo Liang
2023-09-05  8:58   ` Heinrich Schuchardt
2023-09-05  9:02     ` Leo Liang
2023-09-05 17:17 ` Milan P. Stanić
2023-09-06 17:50 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230905172054.GB29543@m1 \
    --to=mps@arvanta.net \
    --cc=triniatkonsulko.com@m1 \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.