From: Kees Cook <keescook@chromium.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Nathan Chancellor <nathan@kernel.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org
Subject: Re: [GIT PULL] bcachefs
Date: Wed, 6 Sep 2023 17:03:06 -0700 [thread overview]
Message-ID: <202309061658.59013483F@keescook> (raw)
In-Reply-To: <20230906222847.GA230622@dev-arch.thelio-3990X>
On Wed, Sep 06, 2023 at 03:28:47PM -0700, Nathan Chancellor wrote:
> Hi Kent,
>
> On Sat, Sep 02, 2023 at 11:25:55PM -0400, Kent Overstreet wrote:
> > here's the bcachefs pull request, for 6.6. Hopefully everything
> > outstanding from the previous PR thread has been resolved; the block
> > layer prereqs are in now via Jens's tree and the dcache helper has a
> > reviewed-by from Christain.
>
> I pulled this into mainline locally and did an LLVM build, which found
> an immediate issue. It appears the bcachefs codes uses zero length
It looks like this series hasn't been in -next at all? That seems like a
pretty important step.
Also, when I look at the PR, it seems to be a branch history going
back _years_. For this kind of a feature, I'd expect a short series of
"here's the code" in incremental additions (e.g. look at the x86 shstk
series), not the development history from it being out of tree -- this
could easily lead to ugly bisection problems, etc.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2023-09-07 0:03 UTC|newest]
Thread overview: 143+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 3:25 [GIT PULL] bcachefs Kent Overstreet
2023-09-05 13:24 ` Christoph Hellwig
2023-09-06 0:00 ` Kent Overstreet
2023-09-06 0:41 ` Matthew Wilcox
2023-09-06 16:10 ` Kent Overstreet
2023-09-06 17:57 ` Darrick J. Wong
2023-09-08 9:37 ` Christoph Hellwig
2023-09-06 19:36 ` Linus Torvalds
2023-09-06 20:02 ` Linus Torvalds
2023-09-06 20:20 ` Linus Torvalds
2023-09-06 21:55 ` Arnaldo Carvalho de Melo
2023-09-06 23:13 ` David Sterba
2023-09-06 23:34 ` Linus Torvalds
2023-09-06 23:46 ` Arnaldo Carvalho de Melo
2023-09-06 23:53 ` Arnaldo Carvalho de Melo
2023-09-06 23:16 ` Linus Torvalds
2023-09-10 0:53 ` Kent Overstreet
2023-09-07 20:37 ` Kent Overstreet
2023-09-07 20:51 ` Linus Torvalds
2023-09-07 23:40 ` Kent Overstreet
2023-09-08 6:29 ` Martin Steigerwald
2023-09-08 9:11 ` Joshua Ashton
2023-09-06 22:28 ` Nathan Chancellor
2023-09-07 0:03 ` Kees Cook [this message]
2023-09-07 14:29 ` Chris Mason
2023-09-07 20:39 ` Kent Overstreet
2023-09-08 10:50 ` Brian Foster
2023-09-08 23:05 ` Dave Chinner
2023-09-08 10:59 ` Thank you! (was: Re: [GIT PULL] bcachefs) Martin Steigerwald
-- strict thread matches above, loose matches on Subject: below --
2024-11-15 20:35 [GIT PULL] bcachefs Kent Overstreet
2024-11-18 0:54 ` Nathan Chancellor
2023-06-26 21:46 Kent Overstreet
2023-06-26 23:11 ` Jens Axboe
2023-06-27 0:06 ` Kent Overstreet
2023-06-27 1:13 ` Jens Axboe
2023-06-27 2:05 ` Kent Overstreet
2023-06-27 2:59 ` Jens Axboe
2023-06-27 3:10 ` Kent Overstreet
2023-06-27 17:16 ` Jens Axboe
2023-06-27 20:15 ` Kent Overstreet
2023-06-27 22:05 ` Dave Chinner
2023-06-27 22:41 ` Kent Overstreet
2023-06-28 14:40 ` Jens Axboe
2023-06-28 14:48 ` Thomas Weißschuh
2023-06-28 14:58 ` Jens Axboe
2023-06-28 3:16 ` Jens Axboe
2023-06-28 4:01 ` Kent Overstreet
2023-06-28 14:58 ` Jens Axboe
2023-06-28 15:22 ` Jens Axboe
2023-06-28 17:56 ` Kent Overstreet
2023-06-28 20:45 ` Jens Axboe
2023-06-28 16:57 ` Jens Axboe
2023-06-28 17:33 ` Christian Brauner
2023-06-28 17:52 ` Kent Overstreet
2023-06-28 20:44 ` Jens Axboe
2023-06-28 21:17 ` Jens Axboe
2023-06-28 22:13 ` Kent Overstreet
2023-06-28 22:33 ` Jens Axboe
2023-06-28 22:55 ` Kent Overstreet
2023-06-28 23:14 ` Jens Axboe
2023-06-28 23:50 ` Kent Overstreet
2023-06-29 1:00 ` Dave Chinner
2023-06-29 1:33 ` Jens Axboe
2023-06-29 11:18 ` Christian Brauner
2023-06-29 14:17 ` Kent Overstreet
2023-06-29 15:31 ` Kent Overstreet
2023-06-30 9:40 ` Christian Brauner
2023-07-06 15:20 ` Kent Overstreet
2023-07-06 16:26 ` Jens Axboe
2023-07-06 16:34 ` Kent Overstreet
2023-06-29 1:29 ` Jens Axboe
2023-07-06 20:15 ` Kent Overstreet
2023-06-28 17:54 ` Kent Overstreet
2023-06-28 20:54 ` Jens Axboe
2023-06-28 22:14 ` Jens Axboe
2023-06-28 23:04 ` Kent Overstreet
2023-06-28 23:11 ` Jens Axboe
2023-06-27 2:33 ` Kent Overstreet
2023-06-27 2:59 ` Jens Axboe
2023-06-27 3:19 ` Matthew Wilcox
2023-06-27 3:22 ` Kent Overstreet
2023-06-27 3:52 ` Christoph Hellwig
2023-06-27 4:36 ` Kent Overstreet
2023-07-06 15:56 ` Kent Overstreet
2023-07-06 16:40 ` Josef Bacik
2023-07-06 17:38 ` Kent Overstreet
2023-07-06 19:17 ` Eric Sandeen
2023-07-06 19:31 ` Kent Overstreet
2023-07-06 21:19 ` Darrick J. Wong
2023-07-06 22:43 ` Kent Overstreet
2023-07-07 13:13 ` Jan Kara
2023-07-07 13:52 ` Kent Overstreet
2023-07-07 8:48 ` Christian Brauner
2023-07-07 9:18 ` Kent Overstreet
2023-07-07 16:26 ` James Bottomley
2023-07-07 16:48 ` Kent Overstreet
2023-07-07 17:04 ` James Bottomley
2023-07-07 17:26 ` Kent Overstreet
2023-07-08 3:54 ` Matthew Wilcox
2023-07-08 4:10 ` Kent Overstreet
2023-07-08 4:31 ` Kent Overstreet
2023-07-08 15:02 ` Theodore Ts'o
2023-07-08 15:23 ` Kent Overstreet
2023-07-08 16:42 ` James Bottomley
2023-07-09 1:16 ` Kent Overstreet
2023-07-07 9:35 ` Kent Overstreet
2023-07-07 2:04 ` Theodore Ts'o
2023-07-07 12:18 ` Brian Foster
2023-07-07 14:49 ` Kent Overstreet
2023-07-12 2:54 ` Kent Overstreet
2023-07-12 19:48 ` Kees Cook
2023-07-12 19:57 ` Kent Overstreet
2023-07-12 22:10 ` Darrick J. Wong
2023-07-12 23:57 ` Kent Overstreet
2023-08-09 1:27 ` Linus Torvalds
2023-08-10 15:54 ` Kent Overstreet
2023-08-10 16:40 ` Linus Torvalds
2023-08-10 18:02 ` Kent Overstreet
2023-08-10 18:09 ` Linus Torvalds
2023-08-10 17:52 ` Jan Kara
2023-08-11 2:47 ` Kent Overstreet
2023-08-11 8:10 ` Jan Kara
2023-08-11 8:13 ` Christian Brauner
2023-08-10 22:39 ` Darrick J. Wong
2023-08-10 23:47 ` Linus Torvalds
2023-08-11 2:40 ` Jens Axboe
2023-08-11 4:03 ` Kent Overstreet
2023-08-11 5:20 ` Linus Torvalds
2023-08-11 5:29 ` Kent Overstreet
2023-08-11 5:53 ` Linus Torvalds
2023-08-11 7:52 ` Christian Brauner
2023-08-11 14:31 ` Jens Axboe
2023-08-11 3:45 ` Kent Overstreet
2023-08-21 0:09 ` Dave Chinner
2023-08-10 23:07 ` Matthew Wilcox
2023-08-11 10:54 ` Christian Brauner
2023-08-11 12:58 ` Kent Overstreet
2023-08-14 7:25 ` Christian Brauner
2023-08-14 15:23 ` Kent Overstreet
2023-08-11 13:21 ` Kent Overstreet
2023-08-11 22:56 ` Darrick J. Wong
2023-08-14 7:21 ` Christian Brauner
2023-08-14 15:27 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309061658.59013483F@keescook \
--to=keescook@chromium.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.