From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 613ACEE14BB for ; Wed, 6 Sep 2023 17:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694020236; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=O84LOzY0bdAz/gscTMKeF2DXsxfe8OPww6slqBO4kbs=; b=d2jXYjA0WEN56U/UyzfHzw5pClxDVrbXmyO2cU3LtzzxX7Mkc92qdOj+vm5IDMrc6HC9VP WTin+JcGKd0kWKHbnprAcOjKwmJ/ucItq7EDuLOFMWcGJsXYT9Ap3C3LZyGoB3vPaWc7yt YDjH1j9EleVbSFxDm0Y/hqfFx2E3GO4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-354-Yh1VR42EMmSdhTAaX8G-IA-1; Wed, 06 Sep 2023 13:10:33 -0400 X-MC-Unique: Yh1VR42EMmSdhTAaX8G-IA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6FED79498C2; Wed, 6 Sep 2023 17:10:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5DE00568FF; Wed, 6 Sep 2023 17:10:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 39090194658D; Wed, 6 Sep 2023 17:10:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AA8DC194658C for ; Wed, 6 Sep 2023 17:10:29 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 890111121318; Wed, 6 Sep 2023 17:10:29 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80C641121314 for ; Wed, 6 Sep 2023 17:10:29 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 671241C09A48 for ; Wed, 6 Sep 2023 17:10:29 +0000 (UTC) Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-dLLutiznOL6OkgdSC5py0Q-1; Wed, 06 Sep 2023 13:10:25 -0400 X-MC-Unique: dLLutiznOL6OkgdSC5py0Q-1 Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qdw2q-0040cT-0x; Wed, 06 Sep 2023 17:10:24 +0000 Date: Wed, 6 Sep 2023 18:10:24 +0100 From: Al Viro To: Mikulas Patocka Message-ID: <20230906171024.GB800259@ZenIV> References: <59b54cc3-b98b-aff9-14fc-dc25c61111c6@redhat.com> <20230906-launenhaft-kinder-118ea59706c8@brauner> <20230906-aufheben-hagel-9925501b7822@brauner> <60f244be-803b-fa70-665e-b5cba15212e@redhat.com> MIME-Version: 1.0 In-Reply-To: <60f244be-803b-fa70-665e-b5cba15212e@redhat.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Subject: Re: [dm-devel] [PATCH] fix writing to the filesystem after unmount X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Brauner , Jan Kara , linux-kernel@vger.kernel.org, dm-devel@redhat.com, Zdenek Kabelac , linux-fsdevel@vger.kernel.org, Christoph Hellwig Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: zeniv.linux.org.uk Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Sep 06, 2023 at 06:01:06PM +0200, Mikulas Patocka wrote: > Perhaps we could distinguish between FIFREEZE-initiated freezes and > device-mapper initiated freezes as well. And we could change the logic to > return -EBUSY if the freeze was initiated by FIFREEZE and to wait for > unfreeze if it was initiated by the device-mapper. By the time you get to cleanup_mnt() it's far too late to return -EBUSY. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D9EEE14B9 for ; Wed, 6 Sep 2023 17:10:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241426AbjIFRKd (ORCPT ); Wed, 6 Sep 2023 13:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234838AbjIFRKc (ORCPT ); Wed, 6 Sep 2023 13:10:32 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 865C0DD; Wed, 6 Sep 2023 10:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SJz4XT95wezg+B9GJkWziQTgnHcuphiw5Sf/cZrUB04=; b=Ja1eK9E0/smdRgpsTz/bzZdHtM gpXXqy7HhjSZqeVmUec0qjzcRFyZgyI9TI+1M95r8dZYTSRuATUvkomnUhltHVxQwcd+sqKewmiPn X8Ftmt/PFlooAI009AsllSFFgYTLN965B5zknSaIv9sakWlN8OlSK4RPdWMCBEKBnFh4uXp2DM2gj jG1uq8NlZxtDQ4m8JJh0kNLS9C9YN12qiieYALkdlQLzJdmCosnEGAVvOemDCDSDSGl4ZYly+u0yc Szjm03hKTCEYQBKMH2AfcuXzYaCPpl0gQkQMxRM0bRMut0+40kEl7hAmOVBo8aRmwViwqhTBpcj1l 0fgvb1dA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qdw2q-0040cT-0x; Wed, 06 Sep 2023 17:10:24 +0000 Date: Wed, 6 Sep 2023 18:10:24 +0100 From: Al Viro To: Mikulas Patocka Cc: Christian Brauner , Zdenek Kabelac , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, Jan Kara , Christoph Hellwig Subject: Re: [PATCH] fix writing to the filesystem after unmount Message-ID: <20230906171024.GB800259@ZenIV> References: <59b54cc3-b98b-aff9-14fc-dc25c61111c6@redhat.com> <20230906-launenhaft-kinder-118ea59706c8@brauner> <20230906-aufheben-hagel-9925501b7822@brauner> <60f244be-803b-fa70-665e-b5cba15212e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60f244be-803b-fa70-665e-b5cba15212e@redhat.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 06, 2023 at 06:01:06PM +0200, Mikulas Patocka wrote: > Perhaps we could distinguish between FIFREEZE-initiated freezes and > device-mapper initiated freezes as well. And we could change the logic to > return -EBUSY if the freeze was initiated by FIFREEZE and to wait for > unfreeze if it was initiated by the device-mapper. By the time you get to cleanup_mnt() it's far too late to return -EBUSY.