All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Andreas Kemnade" <andreas@kemnade.info>,
	"Patrik Dahlström" <risca@dalakolonin.se>,
	peter.ujfalusi@gmail.com, letux-kernel@openphoenux.org,
	kernel@pyra-handheld.com, linux-omap@vger.kernel.org
Subject: Re: [RFC 4/6] ARM: DTS: omap4-l4-abe: Add McASP configuration
Date: Thu, 7 Sep 2023 08:35:24 +0300	[thread overview]
Message-ID: <20230907053524.GG11676@atomide.com> (raw)
In-Reply-To: <6a4f04d5f977344b168d34029da4402cf37d8f68.1693918214.git.hns@goldelico.com>

* H. Nikolaus Schaller <hns@goldelico.com> [230905 15:58]:
> From: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> 
> OMAP4 has a single McASP instance with single serializer and locked for DIT
> mode.
> To be able to enable the support the following fixes needed:
> - Add the DAT port ranges to the target module's ranges

I think the above has been already done?

> - SIDLE mode must be disabled as it is not working with McASP
>  most likely module integration issue with McASP

Best to keep the dts entry as is and add quirk handling to ti-sysc driver
instead based on mcasp revision register detection. The dts is meant to
describe hardware and the register values exist.. But looking at ti-sysc
we already have mcasp tagged with SYSC_QUIRK_SWSUP_SIDLE.

If this patch is still needed, maybe check the revision register value and
mask in case there are multiple revisions, that's this line in ti-sysc:

SYSC_QUIRK("mcasp", 0, 0, 0x4, -ENODEV, 0x44306302, 0xffffffff,
           SYSC_QUIRK_SWSUP_SIDLE),

Regards,

Tony

  reply	other threads:[~2023-09-07  5:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 12:50 [RFC 0/6] tentative additions to fix ABE/AESS device tree entries for OMAP4&5 H. Nikolaus Schaller
2023-09-05 12:50 ` [RFC 1/6] ARM: DTS: omap5-l4-abe: we do not need separate target-modules for dmem, cmem, smem H. Nikolaus Schaller
2023-09-05 12:50 ` [RFC 2/6] ARM: DTS: omap5-l4-abe: add an aess (audio DSP of OMAP4 and OMAP5) child H. Nikolaus Schaller
2023-09-05 12:50 ` [RFC 3/6] ARM: DTS: omap5-board-common: enable aess, add phandles for aess and mcbsp1/2/3 H. Nikolaus Schaller
2023-09-05 12:50 ` [RFC 4/6] ARM: DTS: omap4-l4-abe: Add McASP configuration H. Nikolaus Schaller
2023-09-07  5:35   ` Tony Lindgren [this message]
2023-09-05 12:50 ` [RFC 5/6] ARM: DTS: omap4-l4-abe: add an aess (audio DSP of OMAP4 and OMAP5) child H. Nikolaus Schaller
2023-09-07  5:29   ` Tony Lindgren
2023-09-05 12:50 ` [RFC 6/6] ARM: DTS: omap4-panda-common: enable aess, add phandles for aess and mcbsp1/2/3 H. Nikolaus Schaller
2023-09-06  0:23   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230907053524.GG11676@atomide.com \
    --to=tony@atomide.com \
    --cc=andreas@kemnade.info \
    --cc=hns@goldelico.com \
    --cc=kernel@pyra-handheld.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@gmail.com \
    --cc=risca@dalakolonin.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.