From: Tony Lindgren <tony@atomide.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Adam Ford" <aford173@gmail.com>,
linux-omap@vger.kernel.org, aford@beaconembedded.com,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Derald D. Woods" <woods.technical@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm:dts: am3517-evm: Fix LED3/4 pinmux
Date: Thu, 7 Sep 2023 09:49:46 +0300 [thread overview]
Message-ID: <20230907064946.GI11676@atomide.com> (raw)
In-Reply-To: <56334793-3d21-1f2c-2f5c-01ba2f306813@linaro.org>
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230907 06:11]:
> On 07/09/2023 03:01, Adam Ford wrote:
> > @@ -355,3 +348,12 @@ OMAP3430_CORE2_IOPAD(0x25e2, PIN_INPUT | MUX_MODE3) /* etk_d3.hsusb1_data7 */
> > >;
> > };
> > };
> > +
> > +&omap3_pmx_wkup {
> > + leds_pins: pinmux_leds_pins {
>
> Come on... why moving it and changing the name to incorrect one? Isn't a
> move cut-paste?
Just wondering/hoping.. Are you now able to automatically catch patches
that produce make dtbs_check warnings for node names for pinctrl-single?
Regards,
Tony
next prev parent reply other threads:[~2023-09-07 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 1:01 [PATCH 1/2] arm:dts: am3517-evm: Fix LED3/4 pinmux Adam Ford
2023-09-07 1:01 ` [PATCH 2/2] arm: dts: am3517-evm: Enable Ethernet PHY Interrupt Adam Ford
2023-09-07 6:11 ` Krzysztof Kozlowski
2023-09-07 6:11 ` [PATCH 1/2] arm:dts: am3517-evm: Fix LED3/4 pinmux Krzysztof Kozlowski
2023-09-07 6:49 ` Tony Lindgren [this message]
2023-09-07 13:06 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907064946.GI11676@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=woods.technical@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.