From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 456DEEC873F for ; Thu, 7 Sep 2023 15:46:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E60BA8336D; Thu, 7 Sep 2023 15:46:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E60BA8336D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1694101609; bh=F5hdBoiQuhkW8GTtHEONW9Leqqh/9SJpzoMzJukB4pA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=oFD28HtBBENKdb8OyZ4Pkb4+mMghxGwx3KdOdc3ehxmnbg21ehuwcziW90Ky1qo8n e59XVVz98zqHceQS+RBNIMLBKuJm86hUxngXBiSD5ZtLpzc8YKvqGx6pJ5Z5zT/hYo Ae4Cd9zBC3rkydhiOoC8yswNOQJEcl/ItSWbO0XN4Uo1V5L1UmjS3iLV/ipMNiFkM7 E0NmgGTRMlr/VO3lUFZ7X8/i5/daNvlVmBE3wu6Lz4ayxF1ZenL3TvGgYF75ji7r19 Rl/DEytPvZE7hp7XaHOR+HuaR3k0pHvxC5ksJLolQ+UDoOodJMilA6mGgY7aMdgiaU Y1+SWr8jiOyag== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xaS3itSomfN2; Thu, 7 Sep 2023 15:46:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 022AD83F56; Thu, 7 Sep 2023 15:46:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 022AD83F56 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 082921BF2CC for ; Thu, 7 Sep 2023 15:32:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D48B06125E for ; Thu, 7 Sep 2023 15:32:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D48B06125E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VC3rXfx9_8z0 for ; Thu, 7 Sep 2023 15:32:14 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 1EB0660AA0 for ; Thu, 7 Sep 2023 15:32:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1EB0660AA0 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D4C15CE1A32; Thu, 7 Sep 2023 15:32:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B26EFC433C9; Thu, 7 Sep 2023 15:32:01 +0000 (UTC) Date: Thu, 7 Sep 2023 17:31:56 +0200 From: Simon Horman To: Petr Oros Message-ID: <20230907153156.GJ434333@kernel.org> References: <20230907150251.224931-1-poros@redhat.com> <20230907150251.224931-2-poros@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230907150251.224931-2-poros@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694100728; bh=4/JKnKNExLGNGv2sCb9eyK1f+7iv+45LcWMfCPifJOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FzYu7q8H4km5gUF2N5v5Qpvt7O6xn42LrO9Ej8XfTRaq8JkQJKQ75LZkXZVh58LG7 RzIz3zz3ZbNBhqr9HTBXuW9FbN5XmRSl8hVVbNuCf+f8mJQEXPU0eFp4iMl4ew3uhU 9yeUW3oXtWsHEbt296hRUkZz6LRPPqfKoH0qzUXuq9eLbWsgFop44ZtBtTRNaCfKdy eQbqd3AOP+9s4tvT/w9Thd1wg8lg6mieUoeBh837n2k8GPM3efEr4tcHd90JL6nD5a M1HmY+xEUMOPRBVkJ9dG5/DbzQugBVdocLuA58kTpUOab7JR7G2NclEhm0hB+xbEXG rOR99XJ7ZB1vg== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FzYu7q8H Subject: Re: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivecera@redhat.com, netdev@vger.kernel.org, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Sep 07, 2023 at 05:02:51PM +0200, Petr Oros wrote: > When the iavf driver wants to reconfigure the VLAN filters > (iavf_add_vlan, iavf_del_vlan), it sets a flag in > aq_required: > adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; > or: > adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; > > This is later processed by the watchdog_task, but it runs periodically > every 2 seconds, so it can be a long time before it processes the request. > > In the worst case, the interface is unable to receive traffic for more > than 2 seconds for no objective reason. > > Signed-off-by: Petr Oros > Co-developed-by: Michal Schmidt > Signed-off-by: Michal Schmidt > Co-developed-by: Ivan Vecera > Signed-off-by: Ivan Vecera > Reviewed-by: Ahmed Zaki Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB9A4EC873E for ; Thu, 7 Sep 2023 16:13:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238455AbjIGQNm (ORCPT ); Thu, 7 Sep 2023 12:13:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241162AbjIGQNH (ORCPT ); Thu, 7 Sep 2023 12:13:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60204BE6C for ; Thu, 7 Sep 2023 08:48:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B26EFC433C9; Thu, 7 Sep 2023 15:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694100728; bh=4/JKnKNExLGNGv2sCb9eyK1f+7iv+45LcWMfCPifJOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FzYu7q8H4km5gUF2N5v5Qpvt7O6xn42LrO9Ej8XfTRaq8JkQJKQ75LZkXZVh58LG7 RzIz3zz3ZbNBhqr9HTBXuW9FbN5XmRSl8hVVbNuCf+f8mJQEXPU0eFp4iMl4ew3uhU 9yeUW3oXtWsHEbt296hRUkZz6LRPPqfKoH0qzUXuq9eLbWsgFop44ZtBtTRNaCfKdy eQbqd3AOP+9s4tvT/w9Thd1wg8lg6mieUoeBh837n2k8GPM3efEr4tcHd90JL6nD5a M1HmY+xEUMOPRBVkJ9dG5/DbzQugBVdocLuA58kTpUOab7JR7G2NclEhm0hB+xbEXG rOR99XJ7ZB1vg== Date: Thu, 7 Sep 2023 17:31:56 +0200 From: Simon Horman To: Petr Oros Cc: netdev@vger.kernel.org, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, mschmidt@redhat.com, ivecera@redhat.com, ahmed.zaki@intel.com Subject: Re: [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan Message-ID: <20230907153156.GJ434333@kernel.org> References: <20230907150251.224931-1-poros@redhat.com> <20230907150251.224931-2-poros@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230907150251.224931-2-poros@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 07, 2023 at 05:02:51PM +0200, Petr Oros wrote: > When the iavf driver wants to reconfigure the VLAN filters > (iavf_add_vlan, iavf_del_vlan), it sets a flag in > aq_required: > adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; > or: > adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; > > This is later processed by the watchdog_task, but it runs periodically > every 2 seconds, so it can be a long time before it processes the request. > > In the worst case, the interface is unable to receive traffic for more > than 2 seconds for no objective reason. > > Signed-off-by: Petr Oros > Co-developed-by: Michal Schmidt > Signed-off-by: Michal Schmidt > Co-developed-by: Ivan Vecera > Signed-off-by: Ivan Vecera > Reviewed-by: Ahmed Zaki Reviewed-by: Simon Horman