From: Jakub Kicinski <kuba@kernel.org>
To: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Cc: <piergiorgio.beruto@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<horatiu.vultur@microchip.com>, <Woojung.Huh@microchip.com>,
<Nicolas.Ferre@microchip.com>,
<Thorsten.Kummermehr@microchip.com>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net v2] ethtool: plca: fix plca enable data type while parsing the value
Date: Thu, 7 Sep 2023 20:44:50 -0700 [thread overview]
Message-ID: <20230907204450.6b9e63df@kernel.org> (raw)
In-Reply-To: <20230908140346.40680-1-Parthiban.Veerasooran@microchip.com>
On Fri, 8 Sep 2023 19:33:46 +0530 Parthiban Veerasooran wrote:
> The ETHTOOL_A_PLCA_ENABLED data type is u8. But while parsing the
> value from the attribute, nla_get_u32() is used in the plca_update_sint()
> function instead of nla_get_u8(). So plca_cfg.enabled variable is updated
> with some garbage value instead of 0 or 1 and always enables plca even
> though plca is disabled through ethtool application. This bug has been
> fixed by parsing the values based on the attributes type in the policy.
>
> Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
One second look you need to fix the date on your system and resend.
The patch came to us with a date 24h in the future it will confuse
patchwork.
next prev parent reply other threads:[~2023-09-08 3:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 14:03 [PATCH net v2] ethtool: plca: fix plca enable data type while parsing the value Parthiban Veerasooran
2023-09-07 17:11 ` Jakub Kicinski
2023-09-08 3:44 ` Jakub Kicinski [this message]
2023-09-08 4:35 ` Parthiban.Veerasooran
-- strict thread matches above, loose matches on Subject: below --
2023-09-08 4:45 Parthiban Veerasooran
2023-09-12 12:07 ` Andrew Lunn
2023-10-03 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907204450.6b9e63df@kernel.org \
--to=kuba@kernel.org \
--cc=Nicolas.Ferre@microchip.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=Thorsten.Kummermehr@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.