From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7C8EEB56C for ; Fri, 8 Sep 2023 18:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241807AbjIHSDj (ORCPT ); Fri, 8 Sep 2023 14:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343506AbjIHSDb (ORCPT ); Fri, 8 Sep 2023 14:03:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 148DF1FF5; Fri, 8 Sep 2023 11:03:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4925FC433AB; Fri, 8 Sep 2023 18:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694196102; bh=HA0290nYjJTra1Fa8i+NOPy4ak9llenwVNo887t/S40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CeBTmy00faU4riUxisebRZ3nMkvolQUB6/N9OQeiBYa6ZxdU8yr/BhIVTEdDF/maM L14ZZjs282eK0w1VR2b5FvLR1pvOldZvXMgkZiolQe+bN4rTu4qygD+rpeipn9g4i0 pLPxo46rFpyGawvk4NDhLw20UwAn5UdDYucMRXu1yWHs8+ie7CSsg6cMG/G196sG+Z C0+ucHBrJI2h73Q1F9fF/GgA86peurjw8fjH/LU8yjdYGaCiXXwhSHbRmRG/+JUm2c gnfra+ftxU4S9oYuCXhc3W81DU020OoFTrBpHOlAWanf8F88zW3M1uX78FVsHUen4r iblv2xr6RC6fw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ding Xiang , Will Deacon , Sasha Levin , catalin.marinas@arm.com, shuah@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 6.4 08/13] kselftest/arm64: fix a memleak in zt_regs_run() Date: Fri, 8 Sep 2023 14:00:54 -0400 Message-Id: <20230908180100.3458151-8-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230908180100.3458151-1-sashal@kernel.org> References: <20230908180100.3458151-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.4.15 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org From: Ding Xiang [ Upstream commit 46862da15e37efedb7d2d21e167f506c0b533772 ] If memcmp() does not return 0, "zeros" need to be freed to prevent memleak Signed-off-by: Ding Xiang Link: https://lore.kernel.org/r/20230815074915.245528-1-dingxiang@cmss.chinamobile.com Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- tools/testing/selftests/arm64/signal/testcases/zt_regs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/arm64/signal/testcases/zt_regs.c b/tools/testing/selftests/arm64/signal/testcases/zt_regs.c index e1eb4d5c027ab..2e384d731618b 100644 --- a/tools/testing/selftests/arm64/signal/testcases/zt_regs.c +++ b/tools/testing/selftests/arm64/signal/testcases/zt_regs.c @@ -65,6 +65,7 @@ int zt_regs_run(struct tdescr *td, siginfo_t *si, ucontext_t *uc) if (memcmp(zeros, (char *)zt + ZT_SIG_REGS_OFFSET, ZT_SIG_REGS_SIZE(zt->nregs)) != 0) { fprintf(stderr, "ZT data invalid\n"); + free(zeros); return 1; } -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75D42EEB562 for ; Fri, 8 Sep 2023 18:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vsoQ4vQ+rONAx3cNjL6T3cGYW/Tnk0iLYMGPCcMRYo8=; b=s6W6mMoLzBjhIa /7qFCSoG6UoUv0J9s28tbnlgGnhCH9M6GmSIloAWRgkTsXgER8d+q4Igmgu92gM4xSvAcF5j+dRa7 9MMWvtFlSFVXWSe9lQlN6MoHB1Y0AnugACy0nNTH8PkzxuS0fVoVBwj+33JRawjzeqeHetKpgI+Cp SZGiqgdG0t0AXRZRaNt4oCZ0cpbSdUOzOn1xjHqS0keP2Qrkfxr4saO3FSQ0qDLpIupJfKGKwOoUy /BJAHydejmCspdTb8kMymI8NOwbHvwWHZAtppP2+nLj3JfXvcY+4msi2MZm3hsPsi+ZJuqKwPDHTs Wv9b6e/v8BvgbkunguFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qefng-00ECYr-18; Fri, 08 Sep 2023 18:01:48 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qefnd-00ECX6-0j for linux-arm-kernel@lists.infradead.org; Fri, 08 Sep 2023 18:01:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3E77B821D7; Fri, 8 Sep 2023 18:01:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4925FC433AB; Fri, 8 Sep 2023 18:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694196102; bh=HA0290nYjJTra1Fa8i+NOPy4ak9llenwVNo887t/S40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CeBTmy00faU4riUxisebRZ3nMkvolQUB6/N9OQeiBYa6ZxdU8yr/BhIVTEdDF/maM L14ZZjs282eK0w1VR2b5FvLR1pvOldZvXMgkZiolQe+bN4rTu4qygD+rpeipn9g4i0 pLPxo46rFpyGawvk4NDhLw20UwAn5UdDYucMRXu1yWHs8+ie7CSsg6cMG/G196sG+Z C0+ucHBrJI2h73Q1F9fF/GgA86peurjw8fjH/LU8yjdYGaCiXXwhSHbRmRG/+JUm2c gnfra+ftxU4S9oYuCXhc3W81DU020OoFTrBpHOlAWanf8F88zW3M1uX78FVsHUen4r iblv2xr6RC6fw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ding Xiang , Will Deacon , Sasha Levin , catalin.marinas@arm.com, shuah@kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 6.4 08/13] kselftest/arm64: fix a memleak in zt_regs_run() Date: Fri, 8 Sep 2023 14:00:54 -0400 Message-Id: <20230908180100.3458151-8-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230908180100.3458151-1-sashal@kernel.org> References: <20230908180100.3458151-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.4.15 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230908_110145_420277_84D89A84 X-CRM114-Status: UNSURE ( 9.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ding Xiang [ Upstream commit 46862da15e37efedb7d2d21e167f506c0b533772 ] If memcmp() does not return 0, "zeros" need to be freed to prevent memleak Signed-off-by: Ding Xiang Link: https://lore.kernel.org/r/20230815074915.245528-1-dingxiang@cmss.chinamobile.com Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- tools/testing/selftests/arm64/signal/testcases/zt_regs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/arm64/signal/testcases/zt_regs.c b/tools/testing/selftests/arm64/signal/testcases/zt_regs.c index e1eb4d5c027ab..2e384d731618b 100644 --- a/tools/testing/selftests/arm64/signal/testcases/zt_regs.c +++ b/tools/testing/selftests/arm64/signal/testcases/zt_regs.c @@ -65,6 +65,7 @@ int zt_regs_run(struct tdescr *td, siginfo_t *si, ucontext_t *uc) if (memcmp(zeros, (char *)zt + ZT_SIG_REGS_OFFSET, ZT_SIG_REGS_SIZE(zt->nregs)) != 0) { fprintf(stderr, "ZT data invalid\n"); + free(zeros); return 1; } -- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel