From: kernel test robot <lkp@intel.com>
To: Linhua Xu <Linhua.xu@unisoc.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
lh xu <xulh0829@gmail.com>, Linhua Xu <Linhua.Xu@unisoc.com>,
Zhirong Qiu <zhirong.qiu@unisoc.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Subject: Re: [PATCH V2 4/6] pinctrl: sprd: Add pinctrl support for UMS512
Date: Sat, 9 Sep 2023 09:56:27 +0800 [thread overview]
Message-ID: <202309090904.PsOH9TGp-lkp@intel.com> (raw)
In-Reply-To: <20230908055146.18347-5-Linhua.xu@unisoc.com>
Hi Linhua,
kernel test robot noticed the following build errors:
[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on linusw-pinctrl/for-next linus/master v6.5 next-20230908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Linhua-Xu/pinctrl-sprd-Modify-the-probe-function-parameters/20230908-135519
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20230908055146.18347-5-Linhua.xu%40unisoc.com
patch subject: [PATCH V2 4/6] pinctrl: sprd: Add pinctrl support for UMS512
config: alpha-randconfig-r011-20230909 (https://download.01.org/0day-ci/archive/20230909/202309090904.PsOH9TGp-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230909/202309090904.PsOH9TGp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309090904.PsOH9TGp-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
>> drivers/pinctrl/sprd/pinctrl-sprd.c:287:15: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]
287 | ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinconf_generic_dump_config
cc1: some warnings being treated as errors
vim +287 drivers/pinctrl/sprd/pinctrl-sprd.c
41d32cfce1ae616 Baolin Wang 2017-08-17 246
41d32cfce1ae616 Baolin Wang 2017-08-17 247 static int sprd_dt_node_to_map(struct pinctrl_dev *pctldev,
41d32cfce1ae616 Baolin Wang 2017-08-17 248 struct device_node *np,
41d32cfce1ae616 Baolin Wang 2017-08-17 249 struct pinctrl_map **map,
41d32cfce1ae616 Baolin Wang 2017-08-17 250 unsigned int *num_maps)
41d32cfce1ae616 Baolin Wang 2017-08-17 251 {
41d32cfce1ae616 Baolin Wang 2017-08-17 252 struct sprd_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
41d32cfce1ae616 Baolin Wang 2017-08-17 253 const struct sprd_pin_group *grp;
41d32cfce1ae616 Baolin Wang 2017-08-17 254 unsigned long *configs = NULL;
41d32cfce1ae616 Baolin Wang 2017-08-17 255 unsigned int num_configs = 0;
41d32cfce1ae616 Baolin Wang 2017-08-17 256 unsigned int reserved_maps = 0;
41d32cfce1ae616 Baolin Wang 2017-08-17 257 unsigned int reserve = 0;
41d32cfce1ae616 Baolin Wang 2017-08-17 258 const char *function;
41d32cfce1ae616 Baolin Wang 2017-08-17 259 enum pinctrl_map_type type;
41d32cfce1ae616 Baolin Wang 2017-08-17 260 int ret;
41d32cfce1ae616 Baolin Wang 2017-08-17 261
41d32cfce1ae616 Baolin Wang 2017-08-17 262 grp = sprd_pinctrl_find_group_by_name(pctl, np->name);
41d32cfce1ae616 Baolin Wang 2017-08-17 263 if (!grp) {
41d32cfce1ae616 Baolin Wang 2017-08-17 264 dev_err(pctl->dev, "unable to find group for node %s\n",
41d32cfce1ae616 Baolin Wang 2017-08-17 265 of_node_full_name(np));
41d32cfce1ae616 Baolin Wang 2017-08-17 266 return -EINVAL;
41d32cfce1ae616 Baolin Wang 2017-08-17 267 }
41d32cfce1ae616 Baolin Wang 2017-08-17 268
41d32cfce1ae616 Baolin Wang 2017-08-17 269 ret = of_property_count_strings(np, "pins");
41d32cfce1ae616 Baolin Wang 2017-08-17 270 if (ret < 0)
41d32cfce1ae616 Baolin Wang 2017-08-17 271 return ret;
41d32cfce1ae616 Baolin Wang 2017-08-17 272
41d32cfce1ae616 Baolin Wang 2017-08-17 273 if (ret == 1)
41d32cfce1ae616 Baolin Wang 2017-08-17 274 type = PIN_MAP_TYPE_CONFIGS_PIN;
41d32cfce1ae616 Baolin Wang 2017-08-17 275 else
41d32cfce1ae616 Baolin Wang 2017-08-17 276 type = PIN_MAP_TYPE_CONFIGS_GROUP;
41d32cfce1ae616 Baolin Wang 2017-08-17 277
41d32cfce1ae616 Baolin Wang 2017-08-17 278 ret = of_property_read_string(np, "function", &function);
41d32cfce1ae616 Baolin Wang 2017-08-17 279 if (ret < 0) {
41d32cfce1ae616 Baolin Wang 2017-08-17 280 if (ret != -EINVAL)
41d32cfce1ae616 Baolin Wang 2017-08-17 281 dev_err(pctl->dev,
41d32cfce1ae616 Baolin Wang 2017-08-17 282 "%s: could not parse property function\n",
41d32cfce1ae616 Baolin Wang 2017-08-17 283 of_node_full_name(np));
41d32cfce1ae616 Baolin Wang 2017-08-17 284 function = NULL;
41d32cfce1ae616 Baolin Wang 2017-08-17 285 }
41d32cfce1ae616 Baolin Wang 2017-08-17 286
41d32cfce1ae616 Baolin Wang 2017-08-17 @287 ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
41d32cfce1ae616 Baolin Wang 2017-08-17 288 &num_configs);
41d32cfce1ae616 Baolin Wang 2017-08-17 289 if (ret < 0) {
41d32cfce1ae616 Baolin Wang 2017-08-17 290 dev_err(pctl->dev, "%s: could not parse node property\n",
41d32cfce1ae616 Baolin Wang 2017-08-17 291 of_node_full_name(np));
41d32cfce1ae616 Baolin Wang 2017-08-17 292 return ret;
41d32cfce1ae616 Baolin Wang 2017-08-17 293 }
41d32cfce1ae616 Baolin Wang 2017-08-17 294
41d32cfce1ae616 Baolin Wang 2017-08-17 295 *map = NULL;
41d32cfce1ae616 Baolin Wang 2017-08-17 296 *num_maps = 0;
41d32cfce1ae616 Baolin Wang 2017-08-17 297
41d32cfce1ae616 Baolin Wang 2017-08-17 298 if (function != NULL)
41d32cfce1ae616 Baolin Wang 2017-08-17 299 reserve++;
41d32cfce1ae616 Baolin Wang 2017-08-17 300 if (num_configs)
41d32cfce1ae616 Baolin Wang 2017-08-17 301 reserve++;
41d32cfce1ae616 Baolin Wang 2017-08-17 302
41d32cfce1ae616 Baolin Wang 2017-08-17 303 ret = pinctrl_utils_reserve_map(pctldev, map, &reserved_maps,
41d32cfce1ae616 Baolin Wang 2017-08-17 304 num_maps, reserve);
41d32cfce1ae616 Baolin Wang 2017-08-17 305 if (ret < 0)
41d32cfce1ae616 Baolin Wang 2017-08-17 306 goto out;
41d32cfce1ae616 Baolin Wang 2017-08-17 307
41d32cfce1ae616 Baolin Wang 2017-08-17 308 if (function) {
41d32cfce1ae616 Baolin Wang 2017-08-17 309 ret = pinctrl_utils_add_map_mux(pctldev, map,
41d32cfce1ae616 Baolin Wang 2017-08-17 310 &reserved_maps, num_maps,
41d32cfce1ae616 Baolin Wang 2017-08-17 311 grp->name, function);
41d32cfce1ae616 Baolin Wang 2017-08-17 312 if (ret < 0)
41d32cfce1ae616 Baolin Wang 2017-08-17 313 goto out;
41d32cfce1ae616 Baolin Wang 2017-08-17 314 }
41d32cfce1ae616 Baolin Wang 2017-08-17 315
41d32cfce1ae616 Baolin Wang 2017-08-17 316 if (num_configs) {
41d32cfce1ae616 Baolin Wang 2017-08-17 317 const char *group_or_pin;
41d32cfce1ae616 Baolin Wang 2017-08-17 318 unsigned int pin_id;
41d32cfce1ae616 Baolin Wang 2017-08-17 319
41d32cfce1ae616 Baolin Wang 2017-08-17 320 if (type == PIN_MAP_TYPE_CONFIGS_PIN) {
41d32cfce1ae616 Baolin Wang 2017-08-17 321 pin_id = grp->pins[0];
41d32cfce1ae616 Baolin Wang 2017-08-17 322 group_or_pin = pin_get_name(pctldev, pin_id);
41d32cfce1ae616 Baolin Wang 2017-08-17 323 } else {
41d32cfce1ae616 Baolin Wang 2017-08-17 324 group_or_pin = grp->name;
41d32cfce1ae616 Baolin Wang 2017-08-17 325 }
41d32cfce1ae616 Baolin Wang 2017-08-17 326
41d32cfce1ae616 Baolin Wang 2017-08-17 327 ret = pinctrl_utils_add_map_configs(pctldev, map,
41d32cfce1ae616 Baolin Wang 2017-08-17 328 &reserved_maps, num_maps,
41d32cfce1ae616 Baolin Wang 2017-08-17 329 group_or_pin, configs,
41d32cfce1ae616 Baolin Wang 2017-08-17 330 num_configs, type);
41d32cfce1ae616 Baolin Wang 2017-08-17 331 }
41d32cfce1ae616 Baolin Wang 2017-08-17 332
41d32cfce1ae616 Baolin Wang 2017-08-17 333 out:
41d32cfce1ae616 Baolin Wang 2017-08-17 334 kfree(configs);
41d32cfce1ae616 Baolin Wang 2017-08-17 335 return ret;
41d32cfce1ae616 Baolin Wang 2017-08-17 336 }
41d32cfce1ae616 Baolin Wang 2017-08-17 337
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-09 1:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 5:51 [PATCH V2 0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver Linhua Xu
2023-09-08 5:51 ` [PATCH V2 1/6] pinctrl: sprd: Modify the probe function parameters Linhua Xu
2023-09-11 9:46 ` Andy Shevchenko
2023-09-12 8:13 ` Baolin Wang
2023-09-08 5:51 ` [PATCH V2 2/6] pinctrl: sprd: Fix the incorrect mask and shift definition Linhua Xu
2023-09-11 9:50 ` Andy Shevchenko
2023-09-12 8:28 ` Baolin Wang
2023-11-13 13:50 ` Linus Walleij
2023-09-08 5:51 ` [PATCH V2 3/6] pinctrl: sprd: Modify pull-up parameters Linhua Xu
2023-09-11 9:51 ` Andy Shevchenko
2023-09-12 8:22 ` Baolin Wang
2023-09-08 5:51 ` [PATCH V2 4/6] pinctrl: sprd: Add pinctrl support for UMS512 Linhua Xu
2023-09-09 1:56 ` kernel test robot [this message]
2023-09-11 9:53 ` Andy Shevchenko
2023-09-08 5:51 ` [PATCH V2 5/6] pinctrl: sprd: Increase the range of register values Linhua Xu
2023-09-11 9:55 ` Andy Shevchenko
2023-09-12 8:37 ` Baolin Wang
[not found] ` <CAPjKKSrs9X2msnDg=9rC8H57Dq8FPd7SWyBsr2MCwL0FMNkHPA@mail.gmail.com>
2023-10-26 2:57 ` Baolin Wang
2023-09-08 5:51 ` [PATCH V2 6/6] pinctrl: sprd: Add pinctrl support for UMS9621 Linhua Xu
2023-09-11 9:56 ` Andy Shevchenko
2023-09-11 13:41 ` [PATCH V2 0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver Linus Walleij
2023-09-12 8:40 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309090904.PsOH9TGp-lkp@intel.com \
--to=lkp@intel.com \
--cc=Linhua.xu@unisoc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=orsonzhai@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=xulh0829@gmail.com \
--cc=zhang.lyra@gmail.com \
--cc=zhirong.qiu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.