From: kernel test robot <lkp@intel.com>
To: Igor Torrente <igormtorrente@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Melissa Wen <melissa.srw@gmail.com>
Subject: drivers/gpu/drm/vkms/vkms_formats.c:91:35: sparse: sparse: cast to restricted __le16
Date: Sun, 10 Sep 2023 07:57:42 +0800 [thread overview]
Message-ID: <202309100731.aKzChvXw-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a3c57ab79a06e333a869ae340420cb3c6f5921d3
commit: 3675d8a1726337bd1e839a185e0a7ce0bc459b6b drm: vkms: Adds XRGB_16161616 and ARGB_1616161616 formats
date: 1 year ago
config: i386-randconfig-061-20230909 (https://download.01.org/0day-ci/archive/20230910/202309100731.aKzChvXw-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230910/202309100731.aKzChvXw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309100731.aKzChvXw-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/vkms/vkms_formats.c:91:35: sparse: sparse: cast to restricted __le16
drivers/gpu/drm/vkms/vkms_formats.c:92:35: sparse: sparse: cast to restricted __le16
drivers/gpu/drm/vkms/vkms_formats.c:93:35: sparse: sparse: cast to restricted __le16
drivers/gpu/drm/vkms/vkms_formats.c:94:35: sparse: sparse: cast to restricted __le16
drivers/gpu/drm/vkms/vkms_formats.c:109:35: sparse: sparse: cast to restricted __le16
drivers/gpu/drm/vkms/vkms_formats.c:110:35: sparse: sparse: cast to restricted __le16
drivers/gpu/drm/vkms/vkms_formats.c:111:35: sparse: sparse: cast to restricted __le16
>> drivers/gpu/drm/vkms/vkms_formats.c:177:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/gpu/drm/vkms/vkms_formats.c:177:31: sparse: expected unsigned short [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:177:31: sparse: got restricted __le16 [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:178:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/gpu/drm/vkms/vkms_formats.c:178:31: sparse: expected unsigned short [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:178:31: sparse: got restricted __le16 [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:179:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/gpu/drm/vkms/vkms_formats.c:179:31: sparse: expected unsigned short [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:179:31: sparse: got restricted __le16 [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:180:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/gpu/drm/vkms/vkms_formats.c:180:31: sparse: expected unsigned short [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:180:31: sparse: got restricted __le16 [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:195:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/gpu/drm/vkms/vkms_formats.c:195:31: sparse: expected unsigned short [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:195:31: sparse: got restricted __le16 [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:196:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/gpu/drm/vkms/vkms_formats.c:196:31: sparse: expected unsigned short [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:196:31: sparse: got restricted __le16 [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:197:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] @@ got restricted __le16 [usertype] @@
drivers/gpu/drm/vkms/vkms_formats.c:197:31: sparse: expected unsigned short [usertype]
drivers/gpu/drm/vkms/vkms_formats.c:197:31: sparse: got restricted __le16 [usertype]
vim +91 drivers/gpu/drm/vkms/vkms_formats.c
80
81 static void ARGB16161616_to_argb_u16(struct line_buffer *stage_buffer,
82 const struct vkms_frame_info *frame_info,
83 int y)
84 {
85 struct pixel_argb_u16 *out_pixels = stage_buffer->pixels;
86 u16 *src_pixels = get_packed_src_addr(frame_info, y);
87 int x_limit = min_t(size_t, drm_rect_width(&frame_info->dst),
88 stage_buffer->n_pixels);
89
90 for (size_t x = 0; x < x_limit; x++, src_pixels += 4) {
> 91 out_pixels[x].a = le16_to_cpu(src_pixels[3]);
92 out_pixels[x].r = le16_to_cpu(src_pixels[2]);
93 out_pixels[x].g = le16_to_cpu(src_pixels[1]);
94 out_pixels[x].b = le16_to_cpu(src_pixels[0]);
95 }
96 }
97
98 static void XRGB16161616_to_argb_u16(struct line_buffer *stage_buffer,
99 const struct vkms_frame_info *frame_info,
100 int y)
101 {
102 struct pixel_argb_u16 *out_pixels = stage_buffer->pixels;
103 u16 *src_pixels = get_packed_src_addr(frame_info, y);
104 int x_limit = min_t(size_t, drm_rect_width(&frame_info->dst),
105 stage_buffer->n_pixels);
106
107 for (size_t x = 0; x < x_limit; x++, src_pixels += 4) {
108 out_pixels[x].a = (u16)0xffff;
109 out_pixels[x].r = le16_to_cpu(src_pixels[2]);
110 out_pixels[x].g = le16_to_cpu(src_pixels[1]);
111 out_pixels[x].b = le16_to_cpu(src_pixels[0]);
112 }
113 }
114
115 /*
116 * The following functions take an line of argb_u16 pixels from the
117 * src_buffer, convert them to a specific format, and store them in the
118 * destination.
119 *
120 * They are used in the `compose_active_planes` to convert and store a line
121 * from the src_buffer to the writeback buffer.
122 */
123 static void argb_u16_to_ARGB8888(struct vkms_frame_info *frame_info,
124 const struct line_buffer *src_buffer, int y)
125 {
126 int x_dst = frame_info->dst.x1;
127 u8 *dst_pixels = packed_pixels_addr(frame_info, x_dst, y);
128 struct pixel_argb_u16 *in_pixels = src_buffer->pixels;
129 int x_limit = min_t(size_t, drm_rect_width(&frame_info->dst),
130 src_buffer->n_pixels);
131
132 for (size_t x = 0; x < x_limit; x++, dst_pixels += 4) {
133 /*
134 * This sequence below is important because the format's byte order is
135 * in little-endian. In the case of the ARGB8888 the memory is
136 * organized this way:
137 *
138 * | Addr | = blue channel
139 * | Addr + 1 | = green channel
140 * | Addr + 2 | = Red channel
141 * | Addr + 3 | = Alpha channel
142 */
143 dst_pixels[3] = DIV_ROUND_CLOSEST(in_pixels[x].a, 257);
144 dst_pixels[2] = DIV_ROUND_CLOSEST(in_pixels[x].r, 257);
145 dst_pixels[1] = DIV_ROUND_CLOSEST(in_pixels[x].g, 257);
146 dst_pixels[0] = DIV_ROUND_CLOSEST(in_pixels[x].b, 257);
147 }
148 }
149
150 static void argb_u16_to_XRGB8888(struct vkms_frame_info *frame_info,
151 const struct line_buffer *src_buffer, int y)
152 {
153 int x_dst = frame_info->dst.x1;
154 u8 *dst_pixels = packed_pixels_addr(frame_info, x_dst, y);
155 struct pixel_argb_u16 *in_pixels = src_buffer->pixels;
156 int x_limit = min_t(size_t, drm_rect_width(&frame_info->dst),
157 src_buffer->n_pixels);
158
159 for (size_t x = 0; x < x_limit; x++, dst_pixels += 4) {
160 dst_pixels[3] = 0xff;
161 dst_pixels[2] = DIV_ROUND_CLOSEST(in_pixels[x].r, 257);
162 dst_pixels[1] = DIV_ROUND_CLOSEST(in_pixels[x].g, 257);
163 dst_pixels[0] = DIV_ROUND_CLOSEST(in_pixels[x].b, 257);
164 }
165 }
166
167 static void argb_u16_to_ARGB16161616(struct vkms_frame_info *frame_info,
168 const struct line_buffer *src_buffer, int y)
169 {
170 int x_dst = frame_info->dst.x1;
171 u16 *dst_pixels = packed_pixels_addr(frame_info, x_dst, y);
172 struct pixel_argb_u16 *in_pixels = src_buffer->pixels;
173 int x_limit = min_t(size_t, drm_rect_width(&frame_info->dst),
174 src_buffer->n_pixels);
175
176 for (size_t x = 0; x < x_limit; x++, dst_pixels += 4) {
> 177 dst_pixels[3] = cpu_to_le16(in_pixels[x].a);
178 dst_pixels[2] = cpu_to_le16(in_pixels[x].r);
179 dst_pixels[1] = cpu_to_le16(in_pixels[x].g);
180 dst_pixels[0] = cpu_to_le16(in_pixels[x].b);
181 }
182 }
183
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-09-09 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 23:57 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-12 4:31 drivers/gpu/drm/vkms/vkms_formats.c:91:35: sparse: sparse: cast to restricted __le16 kernel test robot
2023-10-31 13:11 kernel test robot
2023-10-28 1:27 kernel test robot
2023-10-10 0:41 kernel test robot
2023-09-13 12:30 kernel test robot
2023-09-10 13:16 kernel test robot
2023-09-09 11:45 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309100731.aKzChvXw-lkp@intel.com \
--to=lkp@intel.com \
--cc=igormtorrente@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.