From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7507CEEB57D for ; Sun, 10 Sep 2023 14:57:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EFDC5408A7; Sun, 10 Sep 2023 14:57:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EFDC5408A7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1694357847; bh=nhW10A2XB2bF4vZ3947qXN4IROQtqGCQ8YzPdc5xFcQ=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=qN7B57KEVCxxf4C9r+SrK9FaXDCgPNUqOPR86J9OL/69njLPQt7+0sGi1X6uuGKeS YcAFje5LjoH4lPSJV85UKXCX+uixtBdYcAi8HtNPlYKV0DnbTdwFEGfDRWKzoDfS7K t1OPluYTcUiikUlw1jpcVuzHLgL6+rwCAfE+wAKVo9poJ8kIJ9f/kcZq0+sNAjAN9M w7qludt58FsZqnCZdCkYLja0qKtvamZX3G45/xfk1ty0xQlWS8CwWZmV2otBw4Emyr LtA9EP+vKbcKTPbaUKO098xQO+WEZ3PXTD1MNibJscwkHKBWeeCGwQ+i5E5Ibru/QC 0YApYNZLpoipA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y8Y3-LUSGpad; Sun, 10 Sep 2023 14:57:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id C4D5A409A2; Sun, 10 Sep 2023 14:57:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C4D5A409A2 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 50E6A1BF255 for ; Sun, 10 Sep 2023 14:57:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 348A9409A2 for ; Sun, 10 Sep 2023 14:57:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 348A9409A2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id az63p7mODtif for ; Sun, 10 Sep 2023 14:57:23 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 472D2408A7 for ; Sun, 10 Sep 2023 14:57:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 472D2408A7 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 56020B80A4C; Sun, 10 Sep 2023 14:57:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E267C433C8; Sun, 10 Sep 2023 14:57:18 +0000 (UTC) Date: Sun, 10 Sep 2023 16:57:16 +0200 From: Simon Horman To: Andrii Staikov Message-ID: <20230910145716.GG775887@kernel.org> References: <20230908124201.1836101-1-andrii.staikov@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230908124201.1836101-1-andrii.staikov@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694357840; bh=B6xci8mz2Oq6u/KskiGLXgJ/4fXTBxSYPFZDVhTcXB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ElP2EUjEnKxAlXIjojqpQ2WhzzDSDf73/8fawcCcSCdfM8TC3OjnAfHnagu/QL6f3 4lOntSn3d6hWC/e1PV251M0frRqYNRv2mRHJZwDjrWvVQZIHRrAxg/0kUJ2WuFrsiM MIZeviYkQu4Y+bjIbrlc0Mr9BsavSRqgVAX60kp357CsJmgRbiNyiWdo48nQl62jER w94SqidpA8KvLgqLejFz1aoKj7n+/r5P61pAjIQMegnWILy8XUkt1vVDwTpCFP211G 6/MNdVGxgUlCf75FseF1ydt4D0dZI2Yq39TVDXNF4z6BgjGw1dsGp2PYksUwAHaPc+ x2nnp2vFdKTAQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ElP2EUjE Subject: Re: [Intel-wired-lan] [PATCH iwl-net v4] i40e: fix potential memory leaks in i40e_remove() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandr Loktionov , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Sep 08, 2023 at 02:42:01PM +0200, Andrii Staikov wrote: > Instead of freeing memory of a single VSI, make sure > the memory for all VSIs is cleared before releasing VSIs. > Add releasing of their resources in a loop with the iteration > number equal to the number of allocated VSIs. > > Fixes: 41c445ff0f48 ("i40e: main driver core") > Signed-off-by: Andrii Staikov > Signed-off-by: Aleksandr Loktionov Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C3A257E for ; Sun, 10 Sep 2023 14:57:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E267C433C8; Sun, 10 Sep 2023 14:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694357840; bh=B6xci8mz2Oq6u/KskiGLXgJ/4fXTBxSYPFZDVhTcXB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ElP2EUjEnKxAlXIjojqpQ2WhzzDSDf73/8fawcCcSCdfM8TC3OjnAfHnagu/QL6f3 4lOntSn3d6hWC/e1PV251M0frRqYNRv2mRHJZwDjrWvVQZIHRrAxg/0kUJ2WuFrsiM MIZeviYkQu4Y+bjIbrlc0Mr9BsavSRqgVAX60kp357CsJmgRbiNyiWdo48nQl62jER w94SqidpA8KvLgqLejFz1aoKj7n+/r5P61pAjIQMegnWILy8XUkt1vVDwTpCFP211G 6/MNdVGxgUlCf75FseF1ydt4D0dZI2Yq39TVDXNF4z6BgjGw1dsGp2PYksUwAHaPc+ x2nnp2vFdKTAQ== Date: Sun, 10 Sep 2023 16:57:16 +0200 From: Simon Horman To: Andrii Staikov Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Aleksandr Loktionov Subject: Re: [PATCH iwl-net v4] i40e: fix potential memory leaks in i40e_remove() Message-ID: <20230910145716.GG775887@kernel.org> References: <20230908124201.1836101-1-andrii.staikov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908124201.1836101-1-andrii.staikov@intel.com> On Fri, Sep 08, 2023 at 02:42:01PM +0200, Andrii Staikov wrote: > Instead of freeing memory of a single VSI, make sure > the memory for all VSIs is cleared before releasing VSIs. > Add releasing of their resources in a loop with the iteration > number equal to the number of allocated VSIs. > > Fixes: 41c445ff0f48 ("i40e: main driver core") > Signed-off-by: Andrii Staikov > Signed-off-by: Aleksandr Loktionov Reviewed-by: Simon Horman