From: Simon Horman <horms@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Yanan Yang <yanan.yang@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/5] Fixes for SJA1105 DSA FDB regressions
Date: Sun, 10 Sep 2023 17:18:08 +0200 [thread overview]
Message-ID: <20230910151808.GI775887@kernel.org> (raw)
In-Reply-To: <20230908133352.2007218-1-vladimir.oltean@nxp.com>
On Fri, Sep 08, 2023 at 04:33:47PM +0300, Vladimir Oltean wrote:
> A report by Yanan Yang has prompted an investigation into the sja1105
> driver's behavior w.r.t. multicast. The report states that when adding
> multicast L2 addresses with "bridge mdb add", only the most recently
> added address works - the others seem to be overwritten. This is solved
> by patch 3/5 (with patch 2/5 as a dependency for it).
>
> Patches 4/5 and 5/5 fix a series of race conditions introduced during
> the same patch set as the bug above, namely this one:
> https://patchwork.kernel.org/project/netdevbpf/cover/20211024171757.3753288-1-vladimir.oltean@nxp.com/
>
> Finally, patch 1/5 fixes an issue found ever since the introduction of
> multicast forwarding offload in sja1105, which is that the multicast
> addresses are visible (with the "self" flag) in "bridge fdb show".
For series,
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2023-09-10 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 13:33 [PATCH net 0/5] Fixes for SJA1105 DSA FDB regressions Vladimir Oltean
2023-09-08 13:33 ` [PATCH net 1/5] net: dsa: sja1105: hide all multicast addresses from "bridge fdb show" Vladimir Oltean
2023-09-08 13:33 ` [PATCH net 2/5] net: dsa: sja1105: propagate exact error code from sja1105_dynamic_config_poll_valid() Vladimir Oltean
2023-09-08 13:33 ` [PATCH net 3/5] net: dsa: sja1105: fix multicast forwarding working only for last added mdb entry Vladimir Oltean
2023-09-08 13:33 ` [PATCH net 4/5] net: dsa: sja1105: serialize sja1105_port_mcast_flood() with other FDB accesses Vladimir Oltean
2023-09-08 13:33 ` [PATCH net 5/5] net: dsa: sja1105: block FDB accesses that are concurrent with a switch reset Vladimir Oltean
2023-09-10 15:18 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230910151808.GI775887@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yanan.yang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.