All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	corbet@lwn.net, steen.hegelund@microchip.com,
	rdunlap@infradead.org, casper.casan@gmail.com, andrew@lunn.ch,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	horatiu.vultur@microchip.com, Woojung.Huh@microchip.com,
	Nicolas.Ferre@microchip.com, UNGLinuxDriver@microchip.com,
	Thorsten.Kummermehr@microchip.com
Subject: Re: [RFC PATCH net-next 4/6] net: ethernet: implement data transaction interface
Date: Sun, 10 Sep 2023 19:58:24 +0200	[thread overview]
Message-ID: <20230910175824.GL775887@kernel.org> (raw)
In-Reply-To: <20230908142919.14849-5-Parthiban.Veerasooran@microchip.com>

On Fri, Sep 08, 2023 at 07:59:17PM +0530, Parthiban Veerasooran wrote:
> The ethernet frame to be sent to MAC-PHY is converted into multiple
> transmit data chunks. A transmit data chunk consists of a 4-byte data
> header followed by the transmit data chunk payload.
> 
> The received ethernet frame from the network is converted into multiple
> receive data chunks by the MAC-PHY and a receive data chunk consists of
> the receive data chunk payload followed by a 4-byte data footer at the
> end.
> 
> The MAC-PHY shall support a default data chunk payload size of 64 bytes.
> Data chunk payload sizes of 32, 16, or 8 bytes may also be supported. The
> data chunk payload is always a multiple of 4 bytes.
> 
> The 4-byte data header occurs at the beginning of each transmit data
> chunk on MOSI and the 4-byte data footer occurs at the end of each
> receive data chunk on MISO. The data header and footer contain the
> information needed to determine the validity and location of the transmit
> and receive frame data within the data chunk payload. Ethernet frames
> shall be aligned to a 32-bit boundary within the data chunk payload.
> 
> Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>

Hi Parthiban,

this patch seems to introduce new Sparse warnings.
Please consider addressing those, and ideally the warnings
flagged in the existing oa_tc6.c code.

Thanks in advance!

  reply	other threads:[~2023-09-10 17:58 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 14:29 [RFC PATCH net-next 0/6] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface Parthiban Veerasooran
2023-09-08 14:29 ` [RFC PATCH net-next 1/6] net: ethernet: implement OPEN Alliance control transaction interface Parthiban Veerasooran
2023-09-09 12:49   ` kernel test robot
2023-09-09 13:33   ` Andrew Lunn
2023-09-12 13:03     ` Parthiban.Veerasooran
2023-09-13  1:32       ` Andrew Lunn
2023-09-21 12:27         ` Parthiban.Veerasooran
2023-09-21 19:16           ` Andrew Lunn
2023-09-22  4:31             ` Parthiban.Veerasooran
2023-09-13  1:36   ` Andrew Lunn
2023-09-19 11:40     ` Parthiban.Veerasooran
2023-09-13  2:11   ` Andrew Lunn
2023-09-19 11:38     ` Parthiban.Veerasooran
2023-09-19 15:13       ` Andrew Lunn
2023-09-20 12:40         ` Parthiban.Veerasooran
2023-09-20 13:37           ` Andrew Lunn
2023-09-21  9:15             ` Parthiban.Veerasooran
2023-09-13  2:16   ` Andrew Lunn
2023-09-19 11:13     ` Parthiban.Veerasooran
2023-09-19 12:58       ` Andrew Lunn
2023-09-21 12:36         ` Parthiban.Veerasooran
2023-09-21 19:19           ` Andrew Lunn
2023-09-22  4:39             ` Parthiban.Veerasooran
2023-09-26 12:54               ` Fwd: " Parthiban.Veerasooran
2023-09-08 14:29 ` [RFC PATCH net-next 2/6] net: ethernet: add mac-phy interrupt support with reset complete handling Parthiban Veerasooran
2023-09-09 13:39   ` Andrew Lunn
2023-09-12 12:44     ` Parthiban.Veerasooran
2023-09-13  2:19       ` Andrew Lunn
2023-09-19 11:04         ` Parthiban.Veerasooran
2023-09-11 12:51   ` Ziyang Xuan (William)
2023-09-12 12:10     ` Andrew Lunn
2023-09-12 12:28     ` Parthiban.Veerasooran
2023-09-13  2:39   ` Andrew Lunn
2023-09-19 13:07     ` Parthiban.Veerasooran
2023-09-19 13:21       ` Lukasz Majewski
2023-09-13  8:44   ` Lukasz Majewski
2023-09-13 12:36     ` Andrew Lunn
2023-09-13 13:26       ` Lukasz Majewski
2023-09-19 13:40         ` Parthiban.Veerasooran
2023-09-19 13:51           ` Lukasz Majewski
2023-09-08 14:29 ` [RFC PATCH net-next 3/6] net: ethernet: implement OA TC6 configuration function Parthiban Veerasooran
2023-09-14  0:46   ` Andrew Lunn
2023-09-19 10:57     ` Parthiban.Veerasooran
2023-09-19 12:54       ` Andrew Lunn
2023-09-20 12:42         ` Parthiban.Veerasooran
2023-09-08 14:29 ` [RFC PATCH net-next 4/6] net: ethernet: implement data transaction interface Parthiban Veerasooran
2023-09-10 17:58   ` Simon Horman [this message]
2023-09-12 13:47     ` Parthiban.Veerasooran
2023-09-11 12:59   ` Ziyang Xuan (William)
2023-09-12 10:32     ` Parthiban.Veerasooran
2023-09-14  1:18   ` Andrew Lunn
2023-09-18 10:02     ` Parthiban.Veerasooran
2023-09-18 13:01       ` Andrew Lunn
2023-09-19 10:12         ` Parthiban.Veerasooran
2023-09-08 14:29 ` [RFC PATCH net-next 5/6] microchip: lan865x: add driver support for Microchip's LAN865X MACPHY Parthiban Veerasooran
2023-09-08 17:56   ` kernel test robot
2023-09-10 17:44   ` Simon Horman
2023-09-12 10:53     ` Parthiban.Veerasooran
2023-09-11 13:17   ` Ziyang Xuan (William)
2023-09-12 11:41     ` Parthiban.Veerasooran
2023-09-11 22:40   ` kernel test robot
2023-09-14  1:51   ` Andrew Lunn
2023-09-19  9:18     ` Parthiban.Veerasooran
2023-09-19 12:50       ` Andrew Lunn
2023-09-20 12:53         ` Parthiban.Veerasooran
2023-09-14  1:55   ` Andrew Lunn
2023-09-18 11:23     ` Parthiban.Veerasooran
2023-09-15 13:01   ` David Wretman
2023-09-18 11:22     ` Parthiban.Veerasooran
2023-09-08 14:29 ` [RFC PATCH net-next 6/6] microchip: lan865x: add device-tree " Parthiban Veerasooran
2023-09-10 10:55   ` Krzysztof Kozlowski
2023-09-12 12:15     ` Parthiban.Veerasooran
2023-09-12 13:17       ` Krzysztof Kozlowski
2023-09-19 10:51         ` Parthiban.Veerasooran
2023-09-14  2:07   ` Andrew Lunn
2023-09-19 10:40     ` Parthiban.Veerasooran
2023-09-10 10:55 ` [RFC PATCH net-next 0/6] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface Krzysztof Kozlowski
2023-09-13 13:26   ` Parthiban.Veerasooran
2023-09-13 15:45     ` Krzysztof Kozlowski
2023-09-18  9:23       ` Parthiban.Veerasooran
2023-09-15 13:56 ` Alexander Dahl
2023-09-15 14:22   ` Andrew Lunn
2023-09-18  6:16     ` Parthiban.Veerasooran
2023-09-18  6:12   ` Parthiban.Veerasooran
2023-09-18  9:02     ` Fwd: " Parthiban.Veerasooran
2023-09-19  9:03       ` Parthiban.Veerasooran
2023-09-19 16:23         ` Jay Monkman
2023-09-19 18:09         ` Hennerich, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230910175824.GL775887@kernel.org \
    --to=horms@kernel.org \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=Parthiban.Veerasooran@microchip.com \
    --cc=Thorsten.Kummermehr@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=casper.casan@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=steen.hegelund@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.