From: Tony Lindgren <tony@atomide.com>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Merlijn Wajer <merlijn@wizzup.org>,
Miaoqian Lin <linmq006@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>,
linux-phy@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: [PATCH 2/3] phy: mapphone-mdm6600: Fix runtime PM for remove
Date: Mon, 11 Sep 2023 06:54:56 +0300 [thread overview]
Message-ID: <20230911035501.36706-2-tony@atomide.com> (raw)
In-Reply-To: <20230911035501.36706-1-tony@atomide.com>
Otherwise we will get an underflow on remove.
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Fixes: f7f50b2a7b05 ("phy: mapphone-mdm6600: Add runtime PM support for n_gsm on USB suspend")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/phy/motorola/phy-mapphone-mdm6600.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
--- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
+++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
@@ -640,6 +640,11 @@ static void phy_mdm6600_remove(struct platform_device *pdev)
{
struct phy_mdm6600 *ddata = platform_get_drvdata(pdev);
struct gpio_desc *reset_gpio = ddata->ctrl_gpios[PHY_MDM6600_RESET];
+ int error;
+
+ error = pm_runtime_resume_and_get(ddata->dev);
+ if (error)
+ return;
pm_runtime_dont_use_autosuspend(ddata->dev);
pm_runtime_put_sync(ddata->dev);
--
2.42.0
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-09-11 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 3:54 [PATCH 1/3] phy: mapphone-mdm6600: Fix runtime disable on probe Tony Lindgren
2023-09-11 3:54 ` Tony Lindgren [this message]
2023-09-12 15:00 ` [PATCH 2/3] phy: mapphone-mdm6600: Fix runtime PM for remove Sebastian Reichel
2023-09-13 4:36 ` Tony Lindgren
2023-09-11 3:54 ` [PATCH 3/3] phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins Tony Lindgren
2023-09-12 15:14 ` Sebastian Reichel
2023-09-13 4:59 ` Tony Lindgren
2023-09-12 15:00 ` [PATCH 1/3] phy: mapphone-mdm6600: Fix runtime disable on probe Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911035501.36706-2-tony@atomide.com \
--to=tony@atomide.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=kishon@kernel.org \
--cc=kishon@ti.com \
--cc=linmq006@gmail.com \
--cc=linux-phy@lists.infradead.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.