From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org, mcgrof@kernel.org,
keescook@chromium.org, jeffxu@google.com, frederic@kernel.org,
cyphar@cyphar.com, brauner@kernel.org, rongtao@cestc.cn,
akpm@linux-foundation.org
Subject: + pid-pid_ns_ctl_handler-remove-useless-comment.patch added to mm-nonmm-unstable branch
Date: Mon, 11 Sep 2023 11:35:29 -0700 [thread overview]
Message-ID: <20230911183530.3E2D2C433C7@smtp.kernel.org> (raw)
The patch titled
Subject: pid: pid_ns_ctl_handler: remove useless comment
has been added to the -mm mm-nonmm-unstable branch. Its filename is
pid-pid_ns_ctl_handler-remove-useless-comment.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/pid-pid_ns_ctl_handler-remove-useless-comment.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Rong Tao <rongtao@cestc.cn>
Subject: pid: pid_ns_ctl_handler: remove useless comment
Date: Mon, 11 Sep 2023 22:55:09 +0800
commit 95846ecf9dac("pid: replace pid bitmap implementation with IDR API")
removes 'last_pid' element, and use the idr_get_cursor-idr_set_cursor pair
to set the value of idr, so useless comments should be removed.
Link: https://lkml.kernel.org/r/tencent_157A2A1CAF19A3F5885F0687426159A19708@qq.com
Signed-off-by: Rong Tao <rongtao@cestc.cn>
Cc: Aleksa Sarai <cyphar@cyphar.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
Cc: Jeff Xu <jeffxu@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
kernel/pid_namespace.c | 6 ------
1 file changed, 6 deletions(-)
--- a/kernel/pid_namespace.c~pid-pid_ns_ctl_handler-remove-useless-comment
+++ a/kernel/pid_namespace.c
@@ -286,12 +286,6 @@ static int pid_ns_ctl_handler(struct ctl
if (write && !checkpoint_restore_ns_capable(pid_ns->user_ns))
return -EPERM;
- /*
- * Writing directly to ns' last_pid field is OK, since this field
- * is volatile in a living namespace anyway and a code writing to
- * it should synchronize its usage with external means.
- */
-
next = idr_get_cursor(&pid_ns->idr) - 1;
tmp.data = &next;
_
Patches currently in -mm which might be from rongtao@cestc.cn are
pid-pid_ns_ctl_handler-remove-useless-comment.patch
reply other threads:[~2023-09-11 22:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911183530.3E2D2C433C7@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=frederic@kernel.org \
--cc=jeffxu@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=rongtao@cestc.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.