From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9A6CA0EC8 for ; Mon, 11 Sep 2023 22:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239457AbjIKWW6 (ORCPT ); Mon, 11 Sep 2023 18:22:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244013AbjIKSlX (ORCPT ); Mon, 11 Sep 2023 14:41:23 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD64C1AB for ; Mon, 11 Sep 2023 11:41:18 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62153C433C7; Mon, 11 Sep 2023 18:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1694457678; bh=1KzxMkO7EpMaWlodoQgvMjcwhT/vYo6Y1O3c63HEPxQ=; h=Date:To:From:Subject:From; b=dcuRaHHqiUVb8YCszO+u0f99KcdBK09CG0eCOaUntyvwANcRZ43JmaDePWDL6wNVo z3YVkdf/GbcwRkzIocqZ4cNYJkWi3tizXxHV8EwKGruWXB+7GCGfAUNwscfuTEbPWn uSc/li2GxEb+HIyEFk3N+/+quN5fOx1jm/77Lqm0= Date: Mon, 11 Sep 2023 11:41:17 -0700 To: mm-commits@vger.kernel.org, wsa+renesas@sang-engineering.com, loic.poulain@linaro.org, justin.he@arm.com, brauner@kernel.org, axboe@kernel.dk, jianyong.wu@arm.com, akpm@linux-foundation.org From: Andrew Morton Subject: [merged] init-mount-print-pretty-name-of-root-device-when-panics.patch removed from -mm tree Message-Id: <20230911184118.62153C433C7@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The quilt patch titled Subject: init/mount: print pretty name of root device when panicing has been removed from the -mm tree. Its filename was init-mount-print-pretty-name-of-root-device-when-panics.patch This patch was dropped because it was merged into mainline or a subsystem tree ------------------------------------------------------ From: Jianyong Wu Subject: init/mount: print pretty name of root device when panicing Date: Thu, 7 Sep 2023 09:10:25 +0000 Given a wrong root device, current log may not give the pretty name which is useful to locate root cause. For example, there are 2 blk devs in a VM, /dev/vda which has 2 partitials /dev/vda1 and /dev/vda2 and /dev/vdb which is blank. /dev/vda2 is the right root dev. When set "root=/dev/vdb", we get error log: [ 0.635575] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(254,16) It's not straightforward to find out the root cause as there is lack of the root devive name therefore hard for people to get those info from the device number, in the example, (254,16). It is more comprehensive way to hint the root cause if pretty name is given here, like: [ 0.559887] Kernel panic - not syncing: VFS: Unable to mount root fs on "/dev/vdb" or unknown-block(254,16) Link: https://lkml.kernel.org/r/20230907091025.3436878-1-jianyong.wu@arm.com Signed-off-by: Jianyong Wu Cc: Christian Brauner Cc: Jens Axboe Cc: Justin He Cc: Loic Poulain Cc: Wolfram Sang Signed-off-by: Andrew Morton --- init/do_mounts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/init/do_mounts.c~init-mount-print-pretty-name-of-root-device-when-panics +++ a/init/do_mounts.c @@ -244,7 +244,7 @@ retry: for (i = 0, p = fs_names; i < num_fs; i++, p += strlen(p)+1) printk(" %s", p); printk("\n"); - panic("VFS: Unable to mount root fs on %s", b); + panic("VFS: Unable to mount root fs on \"%s\" or %s", pretty_name, b); out: put_page(page); } _ Patches currently in -mm which might be from jianyong.wu@arm.com are