From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/gcc: fix missing .note.GNU-stack section
Date: Mon, 11 Sep 2023 22:57:52 +0200 [thread overview]
Message-ID: <20230911225752.42be61cc@windsurf> (raw)
In-Reply-To: <ZPQ2zZ1dgo6K2mdO@waldemar-brodkorb.de>
On Sun, 3 Sep 2023 09:33:33 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> Shellinabox configure fails to detect ptsname_r, because of the following warning
> binutils 2.39+ emits:
> ld: warning: crtend.o: missing .note.GNU-stack section implies executable stack
> ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
>
> Then the build errors out with:
> shellinabox/launcher.c:772:12: error: static declaration of 'ptsname_r' follows non-static declaration
>
> The same issue exist for cairo 1.16.0 and the detection of pthreads.
>
> Fixes:
> - http://autobuild.buildroot.net/results/3e4/3e478d22e820703ddfd11d1491e631ef8ed6b29b
> - http://autobuild.buildroot.net/results/f60/f602ea17d5938a5beb81d07e13de75ba41d5f6a1
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> ...add-.note.GNU-stack-section-on-linux.patch | 105 ++++++++++++++++++
> ...add-.note.GNU-stack-section-on-linux.patch | 105 ++++++++++++++++++
> 2 files changed, 210 insertions(+)
> create mode 100644 package/gcc/11.4.0/0007-xtensa-add-.note.GNU-stack-section-on-linux.patch
> create mode 100644 package/gcc/12.3.0/0003-xtensa-add-.note.GNU-stack-section-on-linux.patch
Thanks a *LOT* for getting to the bottom of this. This is really what I
was looking for: the real fix, not some ugly workaround in all packages
that are affected. Really great work, much appreciated!
Applied to master, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-11 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 7:33 [Buildroot] [PATCH] package/gcc: fix missing .note.GNU-stack section Waldemar Brodkorb
2023-09-11 20:57 ` Thomas Petazzoni via buildroot [this message]
2023-09-17 6:30 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911225752.42be61cc@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.