From: Beau Belgrave <beaub@linux.microsoft.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mark Brown <broonie@kernel.org>,
shuah@kernel.org, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
naresh.kamboju@linaro.org, anders.roxell@linaro.org,
arnd@arndb.de
Subject: Re: [PATCH v2] selftests/user_events: Fix failures when user_events is not installed
Date: Tue, 12 Sep 2023 10:12:34 -0700 [thread overview]
Message-ID: <20230912171234.GA3704-beaub@linux.microsoft.com> (raw)
In-Reply-To: <20230908212712.211a4964@gandalf.local.home>
On Fri, Sep 08, 2023 at 09:27:12PM -0400, Steven Rostedt wrote:
> On Sat, 9 Sep 2023 00:33:05 +0100
> Mark Brown <broonie@kernel.org> wrote:
>
> > On Fri, Sep 08, 2023 at 08:19:16PM +0000, Beau Belgrave wrote:
> >
> > > Add common methods to detect if tracefs and user_events is enabled. If
> > > either is not enabled skip the test. If tracefs is enabled, but is not
> > > mounted, mount tracefs and fail if there were any errors. Fail if not
> > > run as root.
> >
> > This will leave tracefs mounted if it was not already mounted which is a
> > change to the system configuration. While that may happen if things go
> > wrong during a test we should probably avoid actively doing this and
> > either only skip or try to umount at the end of the test if we mounted
> > ourselves.
>
> LOL! Beau just asked me yesterday if anyone would care if the test mounted
> tracefs and left it mounted. I told him "no" as ftracetest in the selftests
> already do that.
>
> I guess I was wrong and some people do care ;-)
>
> -- Steve
It looks like this change got applied [1] to the fixes branch of
linux-kselftest. I can either send a V3 with this addressed or build a
patch based upon the fixes branch on top of this one to address it.
Which way do you all prefer?
Thanks,
-Beau
1. https://git.kernel.org/shuah/linux-kselftest/c/a06023a8f78d
next prev parent reply other threads:[~2023-09-12 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 20:19 [PATCH v2] selftests/user_events: Fix failures when user_events is not installed Beau Belgrave
2023-09-08 23:33 ` Mark Brown
2023-09-09 1:27 ` Steven Rostedt
2023-09-12 17:12 ` Beau Belgrave [this message]
2023-09-12 17:46 ` Steven Rostedt
2023-09-15 15:54 ` Shuah Khan
2023-09-15 16:02 ` Shuah Khan
2023-09-09 1:57 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912171234.GA3704-beaub@linux.microsoft.com \
--to=beaub@linux.microsoft.com \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.