From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5064ACA5501 for ; Wed, 13 Sep 2023 07:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238419AbjIMHPq (ORCPT ); Wed, 13 Sep 2023 03:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238367AbjIMHPp (ORCPT ); Wed, 13 Sep 2023 03:15:45 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C3D171727; Wed, 13 Sep 2023 00:15:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E0BB78088; Wed, 13 Sep 2023 07:15:40 +0000 (UTC) Date: Wed, 13 Sep 2023 10:15:39 +0300 From: Tony Lindgren To: Andreas Kemnade , Sebastian Reichel Cc: tomi.valkeinen@ideasonboard.com, airlied@gmail.com, daniel@ffwll.ch, u.kleine-koenig@pengutronix.de, arnd@arndb.de, laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4 Message-ID: <20230913071539.GD5285@atomide.com> References: <20230913065911.1551166-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913065911.1551166-1-andreas@kemnade.info> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Andreas Kemnade [230913 06:59]: > Some 3.0 source has it set behind a if (omap4). > Maybe it is helpful maybe not, at least in the omap4460 > trm these bits are marked as reserved. > But maybe some dsi video mode panel starts magically working. Interesting. So Andreas mentioned that dsi video mode works on omap5 but not on omap4. Adding Sebastian to the list too. Regards, Tony > > Signed-off-by: Andreas Kemnade > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 60189a23506a1..e2f576cd9f63c 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -4505,7 +4505,7 @@ static const struct dss_pll_hw dss_omap4_dsi_pll_hw = { > .has_stopmode = true, > .has_freqsel = false, > .has_selfreqdco = false, > - .has_refsel = false, > + .has_refsel = true, > }; > > static const struct dss_pll_hw dss_omap5_dsi_pll_hw = { > -- > 2.39.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 052EBCA5500 for ; Wed, 13 Sep 2023 07:25:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 38F0110E46E; Wed, 13 Sep 2023 07:25:40 +0000 (UTC) X-Greylist: delayed 596 seconds by postgrey-1.36 at gabe; Wed, 13 Sep 2023 07:25:38 UTC Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 9382A10E46E for ; Wed, 13 Sep 2023 07:25:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E0BB78088; Wed, 13 Sep 2023 07:15:40 +0000 (UTC) Date: Wed, 13 Sep 2023 10:15:39 +0300 From: Tony Lindgren To: Andreas Kemnade , Sebastian Reichel Subject: Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4 Message-ID: <20230913071539.GD5285@atomide.com> References: <20230913065911.1551166-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913065911.1551166-1-andreas@kemnade.info> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, tomi.valkeinen@ideasonboard.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, u.kleine-koenig@pengutronix.de, linux-omap@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Andreas Kemnade [230913 06:59]: > Some 3.0 source has it set behind a if (omap4). > Maybe it is helpful maybe not, at least in the omap4460 > trm these bits are marked as reserved. > But maybe some dsi video mode panel starts magically working. Interesting. So Andreas mentioned that dsi video mode works on omap5 but not on omap4. Adding Sebastian to the list too. Regards, Tony > > Signed-off-by: Andreas Kemnade > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 60189a23506a1..e2f576cd9f63c 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -4505,7 +4505,7 @@ static const struct dss_pll_hw dss_omap4_dsi_pll_hw = { > .has_stopmode = true, > .has_freqsel = false, > .has_selfreqdco = false, > - .has_refsel = false, > + .has_refsel = true, > }; > > static const struct dss_pll_hw dss_omap5_dsi_pll_hw = { > -- > 2.39.2 >