All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-omap@vger.kernel.org, aford@beaconembedded.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] bus: ti-sysc: Fix missing AM35xx SoC matching
Date: Wed, 13 Sep 2023 11:25:51 +0300	[thread overview]
Message-ID: <20230913082551.GF5285@atomide.com> (raw)
In-Reply-To: <20230906233442.270835-1-aford173@gmail.com>

* Adam Ford <aford173@gmail.com> [230907 02:34]:
> Commit feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling")
> created a list of SoC types searching for strings based on names
> and wildcards which associates the SoC to different families.
> 
> The OMAP34xx and OMAP35xx are treated as SOC_3430 while
> OMAP36xx and OMAP37xx are treated as SOC_3630, but the AM35xx
> isn't listed.
> 
> The AM35xx is mostly an OMAP3430, and a later commit a12315d6d270
> ("bus: ti-sysc: Make omap3 gpt12 quirk handling SoC specific") looks
> for the SOC type and behaves in a certain way if it's SOC_3430.
> 
> This caused a regression on the AM3517 causing it to return two
> errors:
> 
>  ti-sysc: probe of 48318000.target-module failed with error -16
>  ti-sysc: probe of 49032000.target-module failed with error -16
> 
> Fix this by treating the creating SOC_AM35 and inserting it between
> the SOC_3430 and SOC_3630.  If it is treaed the same way as the
> SOC_3430 when checking the status of sysc_check_active_timer,
> the error conditions will disappear.
> 
> Fixes: a12315d6d270 ("bus: ti-sysc: Make omap3 gpt12 quirk handling SoC specific")
> Fixes: feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling")

Applied into fixes now, thanks

Tony

      reply	other threads:[~2023-09-13  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 23:34 [PATCH V2] bus: ti-sysc: Fix missing AM35xx SoC matching Adam Ford
2023-09-13  8:25 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230913082551.GF5285@atomide.com \
    --to=tony@atomide.com \
    --cc=aford173@gmail.com \
    --cc=aford@beaconembedded.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.