Re: [RFC PATCH 1/4] mm/compaction: add support for >0 order folio memory compaction.

[kernel test robot <lkp@intel.com>]

Hi Zi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.6-rc1 next-20230912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zi-Yan/mm-compaction-add-support-for-0-order-folio-memory-compaction/20230913-003027
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230912162815.440749-2-zi.yan%40sent.com
patch subject: [RFC PATCH 1/4] mm/compaction: add support for >0 order folio memory compaction.
config: i386-randconfig-r006-20230913 (https://download.01.org/0day-ci/archive/20230913/202309131044.fMW8Zabt-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230913/202309131044.fMW8Zabt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309131044.fMW8Zabt-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/compaction.c:135:13: warning: 'sort_free_pages' defined but not used [-Wunused-function]
     135 | static void sort_free_pages(struct list_head *src, struct free_list *dst)
         |             ^~~~~~~~~~~~~~~
>> mm/compaction.c:110:22: warning: 'release_free_list' defined but not used [-Wunused-function]
     110 | static unsigned long release_free_list(struct free_list *freepages)
         |                      ^~~~~~~~~~~~~~~~~


vim +/sort_free_pages +135 mm/compaction.c

   109	
 > 110	static unsigned long release_free_list(struct free_list *freepages)
   111	{
   112		int order;
   113		unsigned long high_pfn = 0;
   114	
   115		for (order = 0; order <= MAX_ORDER; order++) {
   116			struct page *page, *next;
   117	
   118			list_for_each_entry_safe(page, next, &freepages[order].pages, lru) {
   119				unsigned long pfn = page_to_pfn(page);
   120	
   121				list_del(&page->lru);
   122				/*
   123				 * Convert free pages into post allocation pages, so
   124				 * that we can free them via __free_page.
   125				 */
   126				post_alloc_hook(page, order, __GFP_MOVABLE);
   127				__free_pages(page, order);
   128				if (pfn > high_pfn)
   129					high_pfn = pfn;
   130			}
   131		}
   132		return high_pfn;
   133	}
   134	
 > 135	static void sort_free_pages(struct list_head *src, struct free_list *dst)
   136	{
   137		unsigned int order;
   138		struct page *page, *next;
   139	
   140		list_for_each_entry_safe(page, next, src, lru) {
   141			order = buddy_order(page);
   142	
   143			list_move(&page->lru, &dst[order].pages);
   144			dst[order].nr_free++;
   145		}
   146	}
   147	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki