* [nbd168-wireless:mt76 10/10] drivers/net/wireless/mediatek/mt76/mt7915/main.c:498:17: sparse: sparse: dubious: x & !y
@ 2023-09-13 16:45 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-09-13 16:45 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/net/wireless/mediatek/mt76/mt7915/main.c:498:17: sparse: sparse: dubious: x & !y"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Felix Fietkau <nbd@nbd.name>
tree: https://github.com/nbd168/wireless mt76
head: c04c9589d3f0574da76b8439b2478485ed0af4df
commit: c04c9589d3f0574da76b8439b2478485ed0af4df [10/10] wifi: mt76: mt7915: fix monitor mode issues
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: i386-randconfig-062-20230913 (https://download.01.org/0day-ci/archive/20230914/202309140010.HPVRwN61-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309140010.HPVRwN61-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202309140010.HPVRwN61-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/net/wireless/mediatek/mt76/mt7915/main.c:498:17: sparse: sparse: dubious: x & !y
vim +498 drivers/net/wireless/mediatek/mt76/mt7915/main.c
2c70627b09aced Lorenzo Bianconi 2021-11-23 452
e57b7901469fc0 Ryder Lee 2020-04-25 453 static int mt7915_config(struct ieee80211_hw *hw, u32 changed)
e57b7901469fc0 Ryder Lee 2020-04-25 454 {
e57b7901469fc0 Ryder Lee 2020-04-25 455 struct mt7915_dev *dev = mt7915_hw_dev(hw);
e57b7901469fc0 Ryder Lee 2020-04-25 456 struct mt7915_phy *phy = mt7915_hw_phy(hw);
e57b7901469fc0 Ryder Lee 2020-04-25 457 int ret;
e57b7901469fc0 Ryder Lee 2020-04-25 458
e57b7901469fc0 Ryder Lee 2020-04-25 459 if (changed & IEEE80211_CONF_CHANGE_CHANNEL) {
aadf09537c575d Shayne Chen 2020-10-22 460 #ifdef CONFIG_NL80211_TESTMODE
c918c74d06457e Shayne Chen 2020-12-04 461 if (phy->mt76->test.state != MT76_TM_STATE_OFF) {
aadf09537c575d Shayne Chen 2020-10-22 462 mutex_lock(&dev->mt76.mutex);
c918c74d06457e Shayne Chen 2020-12-04 463 mt76_testmode_reset(phy->mt76, false);
aadf09537c575d Shayne Chen 2020-10-22 464 mutex_unlock(&dev->mt76.mutex);
aadf09537c575d Shayne Chen 2020-10-22 465 }
aadf09537c575d Shayne Chen 2020-10-22 466 #endif
e57b7901469fc0 Ryder Lee 2020-04-25 467 ieee80211_stop_queues(hw);
e57b7901469fc0 Ryder Lee 2020-04-25 468 ret = mt7915_set_channel(phy);
e57b7901469fc0 Ryder Lee 2020-04-25 469 if (ret)
e57b7901469fc0 Ryder Lee 2020-04-25 470 return ret;
e57b7901469fc0 Ryder Lee 2020-04-25 471 ieee80211_wake_queues(hw);
e57b7901469fc0 Ryder Lee 2020-04-25 472 }
e57b7901469fc0 Ryder Lee 2020-04-25 473
6c0570bc21ec20 Ryder Lee 2023-07-27 474 if (changed & (IEEE80211_CONF_CHANGE_POWER |
6c0570bc21ec20 Ryder Lee 2023-07-27 475 IEEE80211_CONF_CHANGE_CHANNEL)) {
ecb187a74e1846 Shayne Chen 2021-04-17 476 ret = mt7915_mcu_set_txpower_sku(phy);
f1d962369d5687 Ryder Lee 2020-04-25 477 if (ret)
f1d962369d5687 Ryder Lee 2020-04-25 478 return ret;
f1d962369d5687 Ryder Lee 2020-04-25 479 }
f1d962369d5687 Ryder Lee 2020-04-25 480
e57b7901469fc0 Ryder Lee 2020-04-25 481 mutex_lock(&dev->mt76.mutex);
e57b7901469fc0 Ryder Lee 2020-04-25 482
e57b7901469fc0 Ryder Lee 2020-04-25 483 if (changed & IEEE80211_CONF_CHANGE_MONITOR) {
11553d88d0b99b Felix Fietkau 2020-09-30 484 bool enabled = !!(hw->conf.flags & IEEE80211_CONF_MONITOR);
3eb50cc9053437 Ryder Lee 2022-12-01 485 bool band = phy->mt76->band_idx;
c04c9589d3f057 Felix Fietkau 2023-08-31 486 u32 rxfilter = phy->rxfilter;
11553d88d0b99b Felix Fietkau 2020-09-30 487
c04c9589d3f057 Felix Fietkau 2023-08-31 488 if (!enabled) {
c04c9589d3f057 Felix Fietkau 2023-08-31 489 rxfilter |= MT_WF_RFCR_DROP_OTHER_UC;
c04c9589d3f057 Felix Fietkau 2023-08-31 490 dev->monitor_mask &= ~BIT(band);
c04c9589d3f057 Felix Fietkau 2023-08-31 491 } else {
c04c9589d3f057 Felix Fietkau 2023-08-31 492 rxfilter &= ~MT_WF_RFCR_DROP_OTHER_UC;
c04c9589d3f057 Felix Fietkau 2023-08-31 493 dev->monitor_mask |= BIT(band);
c04c9589d3f057 Felix Fietkau 2023-08-31 494 }
e57b7901469fc0 Ryder Lee 2020-04-25 495
4c430774e01b06 Lorenzo Bianconi 2020-11-13 496 mt76_rmw_field(dev, MT_DMA_DCR0(band), MT_DMA_DCR0_RXD_G5_EN,
4c430774e01b06 Lorenzo Bianconi 2020-11-13 497 enabled);
c04c9589d3f057 Felix Fietkau 2023-08-31 @498 mt76_rmw_field(dev, MT_DMA_DCR0(band), MT_MDP_DCR0_RX_HDR_TRANS_EN,
c04c9589d3f057 Felix Fietkau 2023-08-31 499 !dev->monitor_mask);
c918c74d06457e Shayne Chen 2020-12-04 500 mt76_testmode_reset(phy->mt76, true);
c04c9589d3f057 Felix Fietkau 2023-08-31 501 mt76_wr(dev, MT_WF_RFCR(band), rxfilter);
e57b7901469fc0 Ryder Lee 2020-04-25 502 }
e57b7901469fc0 Ryder Lee 2020-04-25 503
e57b7901469fc0 Ryder Lee 2020-04-25 504 mutex_unlock(&dev->mt76.mutex);
e57b7901469fc0 Ryder Lee 2020-04-25 505
e57b7901469fc0 Ryder Lee 2020-04-25 506 return 0;
e57b7901469fc0 Ryder Lee 2020-04-25 507 }
e57b7901469fc0 Ryder Lee 2020-04-25 508
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-09-13 16:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 16:45 [nbd168-wireless:mt76 10/10] drivers/net/wireless/mediatek/mt76/mt7915/main.c:498:17: sparse: sparse: dubious: x & !y kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.