diff for duplicates of <20230914160646.GA101038@cmpxchg.org> diff --git a/a/1.txt b/N1/1.txt index f853ba7..0de0fe4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ On Wed, Sep 13, 2023 at 09:26:21AM -0700, Yosry Ahmed wrote: -> On Wed, Sep 13, 2023 at 8:38 AM Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> wrote: +> On Wed, Sep 13, 2023 at 8:38 AM Johannes Weiner <hannes@cmpxchg.org> wrote: > > > > On Wed, Sep 13, 2023 at 07:38:46AM +0000, Yosry Ahmed wrote: > > > Stats flushing for memcg currently follows the following rules: @@ -65,14 +65,14 @@ On Wed, Sep 13, 2023 at 09:26:21AM -0700, Yosry Ahmed wrote: > > > - 8.8% of reads take 10ms to 100ms. > > > - Almost no reads take more than 100ms. > > > -> > > [1] https://lore.kernel.org/lkml/CABWYdi0c6__rh-K7dcM_pkf9BJdTRtAU08M43KO9ME4-dsgfoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/ -> > > [2] https://lore.kernel.org/lkml/CAJD7tka13M-zVZTyQJYL1iUAYvuQ1fcHbCjcOBZcz6POYTV-4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/ -> > > [3] https://lore.kernel.org/lkml/CAAPL-u9D2b=iF5Lf_cRnKxUfkiEe0AMDTu6yhrUAzX0b6a6rDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/ +> > > [1] https://lore.kernel.org/lkml/CABWYdi0c6__rh-K7dcM_pkf9BJdTRtAU08M43KO9ME4-dsgfoQ@mail.gmail.com/ +> > > [2] https://lore.kernel.org/lkml/CAJD7tka13M-zVZTyQJYL1iUAYvuQ1fcHbCjcOBZcz6POYTV-4g@mail.gmail.com/ +> > > [3] https://lore.kernel.org/lkml/CAAPL-u9D2b=iF5Lf_cRnKxUfkiEe0AMDTu6yhrUAzX0b6a6rDg@mail.gmail.com/ > > > -> > > [weixugc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org: suggested the fallback logic and bounding the +> > > [weixugc@google.com: suggested the fallback logic and bounding the > > > number of waiters] > > > -> > > Signed-off-by: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> +> > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com> > > > > > /* > > > + * Opportunistically try to only flush the requested subtree. Otherwise @@ -122,7 +122,7 @@ Hm, how is that different than a mutex / sleepable lock? > > This was changed in the following commit: > > > > commit fd25a9e0e23b995fd0ba5e2f00a1099452cbc3cf -> > Author: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> +> > Author: Shakeel Butt <shakeelb@google.com> > > Date: Fri Nov 5 13:37:34 2021 -0700 > > > > memcg: unify memcg stat flushing @@ -137,13 +137,13 @@ Hm, how is that different than a mutex / sleepable lock? > > stats") the kernel periodically flush the memcg stats from the root, so, > > the other flushers will potentially have much less work to do. > > -> > Link: https://lkml.kernel.org/r/20211001190040.48086-2-shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org -> > Signed-off-by: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> -> > Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> -> > Cc: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -> > Cc: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org> -> > Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> -> > Signed-off-by: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> +> > Link: https://lkml.kernel.org/r/20211001190040.48086-2-shakeelb@google.com +> > Signed-off-by: Shakeel Butt <shakeelb@google.com> +> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> +> > Cc: Michal Hocko <mhocko@kernel.org> +> > Cc: "Michal Koutný" <mkoutny@suse.com> +> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> +> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > > > The idea was that we can avoid lock contention if somebody is already > > doing the flushing. However, you're now bringing global serialization. diff --git a/a/content_digest b/N1/content_digest index 56d70c3..0e31596 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,30 +2,29 @@ "ref\020230913073846.1528938-4-yosryahmed@google.com\0" "ref\020230913153758.GB45543@cmpxchg.org\0" "ref\0CAJD7tka20+zB1aFfmdEBX5a3bLDTbGHuZP7sV3cvLvT8dvvaAA@mail.gmail.com\0" - "ref\0CAJD7tka20+zB1aFfmdEBX5a3bLDTbGHuZP7sV3cvLvT8dvvaAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org\0" - "From\0Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>\0" + "From\0Johannes Weiner <hannes@cmpxchg.org>\0" "Subject\0Re: [PATCH 3/3] mm: memcg: optimize stats flushing for latency and accuracy\0" "Date\0Thu, 14 Sep 2023 12:06:46 -0400\0" - "To\0Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\0" - "Cc\0Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>" - Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> - Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org> - Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> - Muchun Song <muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org> - Ivan Babrou <ivan-lDpJ742SOEtZroRs9YW3xA@public.gmane.org> - Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> - " Michal Koutn\303\275 <mkoutny-IBi9RG/b67k@public.gmane.org>" - Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - kernel-team-lDpJ742SOEtZroRs9YW3xA@public.gmane.org - Wei Xu <weixugc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> - Greg Thelen <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> - linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org - cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "To\0Yosry Ahmed <yosryahmed@google.com>\0" + "Cc\0Andrew Morton <akpm@linux-foundation.org>" + Michal Hocko <mhocko@kernel.org> + Roman Gushchin <roman.gushchin@linux.dev> + Shakeel Butt <shakeelb@google.com> + Muchun Song <muchun.song@linux.dev> + Ivan Babrou <ivan@cloudflare.com> + Tejun Heo <tj@kernel.org> + " Michal Koutn\303\275 <mkoutny@suse.com>" + Waiman Long <longman@redhat.com> + kernel-team@cloudflare.com + Wei Xu <weixugc@google.com> + Greg Thelen <gthelen@google.com> + linux-mm@kvack.org + cgroups@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Wed, Sep 13, 2023 at 09:26:21AM -0700, Yosry Ahmed wrote:\n" - "> On Wed, Sep 13, 2023 at 8:38\342\200\257AM Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> wrote:\n" + "> On Wed, Sep 13, 2023 at 8:38\342\200\257AM Johannes Weiner <hannes@cmpxchg.org> wrote:\n" "> >\n" "> > On Wed, Sep 13, 2023 at 07:38:46AM +0000, Yosry Ahmed wrote:\n" "> > > Stats flushing for memcg currently follows the following rules:\n" @@ -91,14 +90,14 @@ "> > > - 8.8% of reads take 10ms to 100ms.\n" "> > > - Almost no reads take more than 100ms.\n" "> > >\n" - "> > > [1] https://lore.kernel.org/lkml/CABWYdi0c6__rh-K7dcM_pkf9BJdTRtAU08M43KO9ME4-dsgfoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/\n" - "> > > [2] https://lore.kernel.org/lkml/CAJD7tka13M-zVZTyQJYL1iUAYvuQ1fcHbCjcOBZcz6POYTV-4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/\n" - "> > > [3] https://lore.kernel.org/lkml/CAAPL-u9D2b=iF5Lf_cRnKxUfkiEe0AMDTu6yhrUAzX0b6a6rDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/\n" + "> > > [1] https://lore.kernel.org/lkml/CABWYdi0c6__rh-K7dcM_pkf9BJdTRtAU08M43KO9ME4-dsgfoQ@mail.gmail.com/\n" + "> > > [2] https://lore.kernel.org/lkml/CAJD7tka13M-zVZTyQJYL1iUAYvuQ1fcHbCjcOBZcz6POYTV-4g@mail.gmail.com/\n" + "> > > [3] https://lore.kernel.org/lkml/CAAPL-u9D2b=iF5Lf_cRnKxUfkiEe0AMDTu6yhrUAzX0b6a6rDg@mail.gmail.com/\n" "> > >\n" - "> > > [weixugc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org: suggested the fallback logic and bounding the\n" + "> > > [weixugc@google.com: suggested the fallback logic and bounding the\n" "> > > number of waiters]\n" "> > >\n" - "> > > Signed-off-by: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\n" + "> > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>\n" "> >\n" "> > > /*\n" "> > > + * Opportunistically try to only flush the requested subtree. Otherwise\n" @@ -148,7 +147,7 @@ "> > This was changed in the following commit:\n" "> >\n" "> > commit fd25a9e0e23b995fd0ba5e2f00a1099452cbc3cf\n" - "> > Author: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\n" + "> > Author: Shakeel Butt <shakeelb@google.com>\n" "> > Date: Fri Nov 5 13:37:34 2021 -0700\n" "> >\n" "> > memcg: unify memcg stat flushing\n" @@ -163,13 +162,13 @@ "> > stats\") the kernel periodically flush the memcg stats from the root, so,\n" "> > the other flushers will potentially have much less work to do.\n" "> >\n" - "> > Link: https://lkml.kernel.org/r/20211001190040.48086-2-shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org\n" - "> > Signed-off-by: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\n" - "> > Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>\n" - "> > Cc: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\n" - "> > Cc: \"Michal Koutn\303\275\" <mkoutny-IBi9RG/b67k@public.gmane.org>\n" - "> > Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>\n" - "> > Signed-off-by: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>\n" + "> > Link: https://lkml.kernel.org/r/20211001190040.48086-2-shakeelb@google.com\n" + "> > Signed-off-by: Shakeel Butt <shakeelb@google.com>\n" + "> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>\n" + "> > Cc: Michal Hocko <mhocko@kernel.org>\n" + "> > Cc: \"Michal Koutn\303\275\" <mkoutny@suse.com>\n" + "> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>\n" + "> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>\n" "> >\n" "> > The idea was that we can avoid lock contention if somebody is already\n" "> > doing the flushing. However, you're now bringing global serialization.\n" @@ -283,4 +282,4 @@ "\n" Let me know if I'm missing something blatant here. -d17a24117fc469bcf442a761de77d683fe1468303b0670e7f25ada63d455310e +b68ee208c8d941625dfee85572ebef3f50c997ae6484c92554a04a01ff4f9263
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.