All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: oe-kbuild-all@lists.linux.dev, vigneshr@ti.com, nm@ti.com,
	Georgi Vlaev <g-vlaev@ti.com>
Subject: [ti:ti-rt-linux-6.1.y-cicd 217/382] drivers/dma/ti/k3-udma.c:5551:12: warning: 'udma_pm_resume' defined but not used
Date: Thu, 14 Sep 2023 21:34:38 +0800	[thread overview]
Message-ID: <202309142146.euQethmd-lkp@intel.com> (raw)

tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-6.1.y-cicd
head:   67baeccff6749ac4362307312cdf2f68175dabb7
commit: 5f0c27386ed3c8d9408d9c5a9fb79981e05199a7 [217/382] dmaengine: ti: k3-udma: Add system suspend/resume support
config: arm64-randconfig-002-20230914 (https://download.01.org/0day-ci/archive/20230914/202309142146.euQethmd-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309142146.euQethmd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309142146.euQethmd-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/dma/ti/k3-udma.c:5551:12: warning: 'udma_pm_resume' defined but not used [-Wunused-function]
    5551 | static int udma_pm_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~
>> drivers/dma/ti/k3-udma.c:5529:12: warning: 'udma_pm_suspend' defined but not used [-Wunused-function]
    5529 | static int udma_pm_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~


vim +/udma_pm_resume +5551 drivers/dma/ti/k3-udma.c

  5528	
> 5529	static int udma_pm_suspend(struct device *dev)
  5530	{
  5531		struct udma_dev *ud = dev_get_drvdata(dev);
  5532		struct dma_device *dma_dev = &ud->ddev;
  5533		struct dma_chan *chan;
  5534		struct udma_chan *uc;
  5535	
  5536		list_for_each_entry(chan, &dma_dev->channels, device_node) {
  5537			if (chan->client_count) {
  5538				uc = to_udma_chan(chan);
  5539				/* backup the channel configuration */
  5540				memcpy(&uc->backup_config, &uc->config,
  5541				       sizeof(struct udma_chan_config));
  5542				dev_dbg(dev, "Suspending channel %s\n",
  5543					dma_chan_name(chan));
  5544				ud->ddev.device_free_chan_resources(chan);
  5545			}
  5546		}
  5547	
  5548		return 0;
  5549	}
  5550	
> 5551	static int udma_pm_resume(struct device *dev)
  5552	{
  5553		struct udma_dev *ud = dev_get_drvdata(dev);
  5554		struct dma_device *dma_dev = &ud->ddev;
  5555		struct dma_chan *chan;
  5556		struct udma_chan *uc;
  5557		int ret;
  5558	
  5559		list_for_each_entry(chan, &dma_dev->channels, device_node) {
  5560			if (chan->client_count) {
  5561				uc = to_udma_chan(chan);
  5562				/* restore the channel configuration */
  5563				memcpy(&uc->config, &uc->backup_config,
  5564				       sizeof(struct udma_chan_config));
  5565				dev_dbg(dev, "Resuming channel %s\n",
  5566					dma_chan_name(chan));
  5567				ret = ud->ddev.device_alloc_chan_resources(chan);
  5568				if (ret)
  5569					return ret;
  5570			}
  5571		}
  5572	
  5573		return 0;
  5574	}
  5575	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-09-14 13:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309142146.euQethmd-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=g-vlaev@ti.com \
    --cc=nm@ti.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.