Re: [PATCH v2] rfkill: sync before userspace visibility/changes

[kernel test robot <lkp@intel.com>]

Hi Johannes,

kernel test robot noticed the following build errors:

[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master v6.6-rc1 next-20230914]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/rfkill-sync-before-userspace-visibility-changes/20230914-221103
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20230914153604.9d1ce0f43ac8.If977317d8f6a0f557090defcd6aef67628f62ff7%40changeid
patch subject: [PATCH v2] rfkill: sync before userspace visibility/changes
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230915/202309150719.OIX0u8eK-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230915/202309150719.OIX0u8eK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309150719.OIX0u8eK-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/rfkill/core.c:735:2: error: call to undeclared function 'rfkill_sync'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
           rfkill_sync(rfkill);
           ^
   net/rfkill/core.c:759:2: error: call to undeclared function 'rfkill_sync'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
           rfkill_sync(rfkill);
           ^
   net/rfkill/core.c:793:2: error: call to undeclared function 'rfkill_sync'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
           rfkill_sync(rfkill);
           ^
   net/rfkill/core.c:818:2: error: call to undeclared function 'rfkill_sync'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
           rfkill_sync(rfkill);
           ^
   net/rfkill/core.c:1044:13: error: static declaration of 'rfkill_sync' follows non-static declaration
   static void rfkill_sync(struct rfkill *rfkill)
               ^
   net/rfkill/core.c:735:2: note: previous implicit declaration is here
           rfkill_sync(rfkill);
           ^
   5 errors generated.


vim +/rfkill_sync +735 net/rfkill/core.c

   728	
   729	static ssize_t soft_show(struct device *dev, struct device_attribute *attr,
   730				 char *buf)
   731	{
   732		struct rfkill *rfkill = to_rfkill(dev);
   733	
   734		mutex_lock(&rfkill_global_mutex);
 > 735		rfkill_sync(rfkill);
   736		mutex_unlock(&rfkill_global_mutex);
   737	
   738		return sysfs_emit(buf, "%d\n", (rfkill->state & RFKILL_BLOCK_SW) ? 1 : 0);
   739	}
   740	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki