All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamal Heib <kheib@redhat.com>
To: linux-rdma@vger.kernel.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	Kamal Heib <kheib@redhat.com>
Subject: [PATCH for-next v1] RDMA/nldev: Add support for reporting ipoib netdev
Date: Fri, 15 Sep 2023 14:37:57 -0400	[thread overview]
Message-ID: <20230915183757.510557-1-kheib@redhat.com> (raw)

This patch adds support for reporting the ipoib net device for a given
RDMA device by calling ib_get_net_dev_by_params() when filling the
port's info.

$ rdma link show mlx5_0/1
link mlx5_0/1 subnet_prefix fe80:0000:0000:0000 lid 66 sm_lid 3 lmc 0
	state ACTIVE physical_state LINK_UP netdev ibp196s0f0

Signed-off-by: Kamal Heib <kheib@redhat.com>
---
v1: Check namespace and query pkey.
---
 drivers/infiniband/core/nldev.c | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
index d5d3e4f0de77..f3fa8143cdc7 100644
--- a/drivers/infiniband/core/nldev.c
+++ b/drivers/infiniband/core/nldev.c
@@ -308,10 +308,12 @@ static int fill_port_info(struct sk_buff *msg,
 			  struct ib_device *device, u32 port,
 			  const struct net *net)
 {
+	struct net_device *ipoib_netdev = NULL;
 	struct net_device *netdev = NULL;
 	struct ib_port_attr attr;
-	int ret;
 	u64 cap_flags = 0;
+	u16 pkey;
+	int ret;
 
 	if (fill_nldev_handle(msg, device))
 		return -EMSGSIZE;
@@ -340,6 +342,26 @@ static int fill_port_info(struct sk_buff *msg,
 			return -EMSGSIZE;
 		if (nla_put_u8(msg, RDMA_NLDEV_ATTR_LMC, attr.lmc))
 			return -EMSGSIZE;
+
+		ret = ib_query_pkey(device, port, 0, &pkey);
+		if (ret)
+			goto out;
+
+		ipoib_netdev = ib_get_net_dev_by_params(device, port,
+							pkey,
+							NULL, NULL);
+		if (ipoib_netdev && net_eq(dev_net(ipoib_netdev), net)) {
+			ret = nla_put_u32(msg,
+					  RDMA_NLDEV_ATTR_NDEV_INDEX,
+					  ipoib_netdev->ifindex);
+			if (ret)
+				goto out;
+			ret = nla_put_string(msg,
+					     RDMA_NLDEV_ATTR_NDEV_NAME,
+					     ipoib_netdev->name);
+			if (ret)
+				goto out;
+		}
 	}
 	if (nla_put_u8(msg, RDMA_NLDEV_ATTR_PORT_STATE, attr.state))
 		return -EMSGSIZE;
@@ -357,6 +379,9 @@ static int fill_port_info(struct sk_buff *msg,
 	}
 
 out:
+	if (ipoib_netdev)
+		dev_put(ipoib_netdev);
+
 	if (netdev)
 		dev_put(netdev);
 	return ret;
-- 
2.41.0


             reply	other threads:[~2023-09-15 18:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 18:37 Kamal Heib [this message]
2023-09-18 11:52 ` [PATCH for-next v1] RDMA/nldev: Add support for reporting ipoib netdev Leon Romanovsky
2023-09-18 12:30 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915183757.510557-1-kheib@redhat.com \
    --to=kheib@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.