From: Kees Cook <keescook@chromium.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: John Ogness <john.ogness@linutronix.de>,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: fix duplicate wq_update_pod_attrs_buf allocation
Date: Fri, 15 Sep 2023 20:14:12 -0700 [thread overview]
Message-ID: <202309152011.EAFC890@keescook> (raw)
In-Reply-To: <CAMuHMdWts9NKU=DfPujTKAQNU6T3uawVtejwiTkp=usMu0rH-A@mail.gmail.com>
On Fri, Sep 15, 2023 at 01:24:25PM +0200, Geert Uytterhoeven wrote:
> On Wed, Sep 13, 2023 at 8:05 PM John Ogness <john.ogness@linutronix.de> wrote:
> > One of the hunks for the patch resulting in
> > commit 84193c07105c ("workqueue: Generalize unbound CPU pods") was
> > applied incorrectly. This resulted in @wq_update_pod_attrs_buf
> > being allocated twice.
> >
> > From the kmemleak detector:
> >
> > unreferenced object 0xc0000000040074c0 (size 64):
> > comm "swapper/0", pid 0, jiffies 4294937296 (age 1936.580s)
> > hex dump (first 32 bytes):
> > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 03 ................
> > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > backtrace:
> > [<0000000076b83a6e>] .kmalloc_trace+0x54/0x190
> > [<00000000898f2356>] .alloc_workqueue_attrs+0x2c/0x60
> > [<0000000063365e1f>] .workqueue_init_early+0xe4/0x4b8
> > [<00000000ca97ff39>] .start_kernel+0x8d0/0xba4
> > [<000000002ee12080>] start_here_common+0x1c/0x20
> >
> > Remove the redundant allocation.
> >
> > Signed-off-by: John Ogness <john.ogness@linutronix.de>
>
> Stephen posted a similar patch before:
> https://lore.kernel.org/all/20230905174935.2d75feab@gandalf.local.home
I tripped over this kmemleak report too. It'd be nice to get this into
-rc2. Tejun, are able to get this or the Sep 5th patch to Linus soon?
-Kees
--
Kees Cook
next prev parent reply other threads:[~2023-09-16 3:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 10:16 [PATCH] workqueue: fix duplicate wq_update_pod_attrs_buf allocation John Ogness
2023-09-15 11:24 ` Geert Uytterhoeven
2023-09-16 3:14 ` Kees Cook [this message]
2023-09-18 18:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309152011.EAFC890@keescook \
--to=keescook@chromium.org \
--cc=geert@linux-m68k.org \
--cc=jiangshanlai@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.