All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses
Date: Sat, 16 Sep 2023 02:09:37 +0000	[thread overview]
Message-ID: <20230916020945.47296-2-sj@kernel.org> (raw)
In-Reply-To: <20230916020945.47296-1-sj@kernel.org>

DAMON provides nr_accesses_bp, which becomes same to nr_accesses * 10000
for every aggregation interval, but updated every sampling interval with
a reasonable accuracy.  Since DAMON-based operation schemes are applied
in every aggregation interval using nr_accesses, using nr_accesses_bp
instead will make no difference to users.  Meanwhile, it allows DAMOS to
apply the schemes in a time interval that less than the aggregation
interval.  It could be useful and more flexible for some cases.  Do it.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index b15cf47d2d29..79fef5145a4b 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -770,12 +770,13 @@ static void damon_split_region_at(struct damon_target *t,
 static bool __damos_valid_target(struct damon_region *r, struct damos *s)
 {
 	unsigned long sz;
+	unsigned int nr_accesses = r->nr_accesses_bp / 10000;
 
 	sz = damon_sz_region(r);
 	return s->pattern.min_sz_region <= sz &&
 		sz <= s->pattern.max_sz_region &&
-		s->pattern.min_nr_accesses <= r->nr_accesses &&
-		r->nr_accesses <= s->pattern.max_nr_accesses &&
+		s->pattern.min_nr_accesses <= nr_accesses &&
+		nr_accesses <= s->pattern.max_nr_accesses &&
 		s->pattern.min_age_region <= r->age &&
 		r->age <= s->pattern.max_age_region;
 }
-- 
2.25.1


  reply	other threads:[~2023-09-16  2:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-16  2:09 [PATCH 0/9] mm/damon: implement DAMOS apply intervals SeongJae Park
2023-09-16  2:09 ` SeongJae Park [this message]
2023-09-16  2:09 ` [PATCH 2/9] mm/damon/sysfs-schemes: use nr_accesses_bp as the source of tried_regions/<N>/nr_accesses SeongJae Park
2023-09-16  2:09 ` [PATCH 3/9] mm/damon/core: use nr_accesses_bp as a source of damos_before_apply tracepoint SeongJae Park
2023-09-16  2:09 ` [PATCH 4/9] mm/damon/core: implement scheme-specific apply interval SeongJae Park
2023-09-16  2:09 ` [PATCH 5/9] Docs/mm/damon/design: document DAMOS apply intervals SeongJae Park
2023-09-16  2:09 ` [PATCH 6/9] mm/damon/sysfs-schemes: support DAMOS apply interval SeongJae Park
2023-09-16  2:09 ` [PATCH 7/9] selftests/damon/sysfs: test DAMOS apply intervals SeongJae Park
2023-09-16  2:09 ` [PATCH 8/9] Docs/admin-guide/mm/damon/usage: update for " SeongJae Park
2023-09-16  2:09 ` [PATCH 9/9] Docs/ABI/damon: " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230916020945.47296-2-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.