From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com,
liuyonglong@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 5/5] net: hns3: add 5ms delay before clear firmware reset irq source
Date: Sat, 16 Sep 2023 17:31:06 +0200 [thread overview]
Message-ID: <20230916153106.GE1125562@kernel.org> (raw)
In-Reply-To: <20230915095305.422328-6-shaojijie@huawei.com>
On Fri, Sep 15, 2023 at 05:53:05PM +0800, Jijie Shao wrote:
> From: Jie Wang <wangjie125@huawei.com>
>
> Currently the reset process in hns3 and firmware watchdog init process is
> asynchronous. we think firmware watchdog initialization is completed
> before hns3 clear the firmware interrupt source. However, firmware
> initialization may not complete early.
>
> so we add delay before hns3 clear firmware interrupt source and 5 ms delay
> is enough to avoid second firmware reset interrupt.
>
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Hi Jijie Shao,
is it appropriate to add the following tag?
Fixes: c1a81619d73a ("net: hns3: Add mailbox interrupt handling to PF driver")
prev parent reply other threads:[~2023-09-16 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 9:53 [PATCH net 0/5] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2023-09-15 9:53 ` [PATCH net 1/5] net: hns3: add cmdq check for vf periodic service task Jijie Shao
2023-09-16 15:34 ` Simon Horman
2023-09-15 9:53 ` [PATCH net 2/5] net: hns3: fix GRE checksum offload issue Jijie Shao
2023-09-15 9:53 ` [PATCH net 3/5] net: hns3: only enable unicast promisc when mac table full Jijie Shao
2023-09-15 9:53 ` [PATCH net 4/5] net: hns3: fix fail to delete tc flower rules during reset issue Jijie Shao
2023-09-15 9:53 ` [PATCH net 5/5] net: hns3: add 5ms delay before clear firmware reset irq source Jijie Shao
2023-09-16 15:31 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230916153106.GE1125562@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.