From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linyu Yuan <quic_linyyuan@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 /3] usb: dwc3: trace: reduce buffer usage of trace event
Date: Sun, 17 Sep 2023 10:00:00 +0200 [thread overview]
Message-ID: <2023091714-outer-deem-fb64@gregkh> (raw)
In-Reply-To: <20230915052716.28540-4-quic_linyyuan@quicinc.com>
On Fri, Sep 15, 2023 at 01:27:16PM +0800, Linyu Yuan wrote:
> Save u32 members in __le32 format into trace event ring buffer and parse
> it for possible bit fields.
>
> Use new common trace event macro in gadget.h for output stage.
>
> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
> ---
> drivers/usb/dwc3/trace.h | 63 ++++++++++++++++++----------------------
> 1 file changed, 29 insertions(+), 34 deletions(-)
Your subject line is broken.
Stop, take some time and rethink this series, and get someone in your
group/company to review it before submitting it again. You seem to be
ignoring our review comments which just makes me want to ignore the
patches entirely, which I do not think you want to have happen :(
greg k-h
next prev parent reply other threads:[~2023-09-17 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 5:27 [PATCH v6 0/3] usb: gadget: reduce usb gadget trace event buffer usage Linyu Yuan
2023-09-15 5:27 ` [PATCH v6 1/3] usb: gadget: add anonymous definition in some struct for trace purpose Linyu Yuan
2023-09-17 8:01 ` Greg Kroah-Hartman
2023-09-15 5:27 ` [PATCH v6 2/3] usb: udc: trace: reduce buffer usage of trace event Linyu Yuan
2023-09-15 5:27 ` [PATCH v6 /3] usb: dwc3: " Linyu Yuan
2023-09-17 8:00 ` Greg Kroah-Hartman [this message]
2023-09-15 14:13 ` [PATCH v6 0/3] usb: gadget: reduce usb gadget trace event buffer usage Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091714-outer-deem-fb64@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=quic_linyyuan@quicinc.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.