From: Petr Vorel <pvorel@suse.cz>
To: Marius Kittler <mkittler@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 1/2] Refactor ioctl02.c to use the new test API
Date: Mon, 18 Sep 2023 12:07:49 +0200 [thread overview]
Message-ID: <20230918100749.GC30304@pevik> (raw)
In-Reply-To: <20230918085502.17091-2-mkittler@suse.de>
Hi Marius,
Could you please fix formatting and other common errors?
$ make check-getxattr01
CHECK testcases/kernel/syscalls/getxattr/getxattr01.c
getxattr01.c:81: WARNING: Missing a blank line after declarations
getxattr01.c:83: WARNING: Missing a blank line after declarations
getxattr01.c:106: WARNING: braces {} are not necessary for single statement
blocks
getxattr01.c:127: WARNING: Missing a blank line after declarations
make: [../../../../include/mk/rules.mk:56: check-getxattr01] Error 1 (ignored)
getxattr01.c:50:3: warning: Symbol 'tcases' has no prototype or library ('tst_')
prefix. Should it be static?
Also (very nit), backticks (`) are good for github formatting, but they look
strange in git commits. Could you avoid using it in git subject?
(e.g. "Port `getxattr01.c` to new test API" should be "Port getxattr01.c to
new test API").
> Related issue: https://github.com/linux-test-project/ltp/issues/583
We use:
Fixes: #583
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-18 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:55 [LTP] [PATCH v4 0/2] Improve ioctl02.c Marius Kittler
2023-09-18 8:55 ` [LTP] [PATCH v4 1/2] Refactor ioctl02.c to use the new test API Marius Kittler
2023-09-18 10:07 ` Petr Vorel [this message]
2023-09-18 13:14 ` Petr Vorel
2023-09-18 15:37 ` Martin Doucha
2023-09-18 8:55 ` [LTP] [PATCH v4 2/2] Make checks for termio flags more strict Marius Kittler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918100749.GC30304@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mkittler@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.