Re: [LTP] [PATCH v3 2/2] Add Linux Test eXecutor inside tools

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > This works, but why we don't use approach used for sparc, i.e.

> > $(MAKE) -C ltx-src

> > That way we would not have to redefine the default rules.

> Unfortunately this does not work well either because the ltx does not
> have install targed and trying to install a file from a subdirectory is
> not possible with the LTP build system. I've tried that and it didn't
> work.

> Let's merge this version that works, we can try to do make things better
> later on.

Sure. BTW I prefer v4, which replaces runltp-ng instead of keeping it.

> > Also it detects missing git clone and runs
> > git submodule update --init if needed.

> > I'm asking for a same approach, not only because later we can unify and reuse
> > the code in some make helper, but also because it'd be more user friendly if our
> > new git submodules work the same way.

> Now this needs to be discussed first. Currently the submodule is
> installed when user writes make check. That means that it's not
> triggered in default build and the default build works without network
> connection. I do not think that we should attempt to download additional
> repositories on default build.

Make sense.

> > But if there is not enough time before release I would not be against this.

> I'm would say that there is not enough time for a proper discussion, so
> I would really keep things as they are in the latest patchset and leave
> the discussion for later.

Sure.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp