From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Mon, 18 Sep 2023 12:16:37 -0300 Subject: [PATCH 01/26] vfio: Wrap KVM helpers with CONFIG_KVM instead of CONFIG_HAVE_KVM In-Reply-To: <20230916003118.2540661-2-seanjc@google.com> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-2-seanjc@google.com> Message-ID: <20230918151637.GF13795@ziepe.ca> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Sep 15, 2023 at 05:30:53PM -0700, Sean Christopherson wrote: > Wrap the helpers for getting references to KVM instances with a check on > CONFIG_KVM being enabled, not on CONFIG_HAVE_KVM being defined. PPC does > NOT select HAVE_KVM, despite obviously supporting KVM, and guarding code > to get references to KVM based on whether or not the architecture supports > KVM is nonsensical. > > Drop the guard around linux/kvm_host.h entirely, conditionally including a > generic headers is completely unnecessary. > > Signed-off-by: Sean Christopherson > --- > drivers/vfio/vfio.h | 2 +- > drivers/vfio/vfio_main.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7CE31170A for ; Mon, 18 Sep 2023 15:16:40 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-41214998fc2so27335321cf.0 for ; Mon, 18 Sep 2023 08:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695050199; x=1695654999; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=Es+VaBjpGDjxjUTVB5qVZUr0MDx/EZB3yS03V0tRcrOwKuoB4a8kj5gcJILXMA/hxj JrccQpqn6tR5WHI+Ft1zWYUQjuNrQtsapTTmegJb50N2vkplGY1yDQbPTh+utOD9sdgx 9wbQ9A8b04uh6IhYGssahvPRDsVB2ShjHR5zVhVvtT49B/eNENR20lMwnlNpIVuG1Ctd nJRIPDESqVJpclt5w9FT+cktQ/XiVZN+OBMaLu1uWp+AqxhPPr5Z1MvzzEMnTFA3+N21 N/npxxQOxzVGgjLX+JhAaEVkIYjZ9hTp067wwSVgT9U3mR3egPWl6dE51Gykouju9ZBp Hdfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050199; x=1695654999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=npYDzQWh0meaDZGtrnuGeldMgAjKTubOsLOXWpmtz6e6shCu5RBgR2jvXaBhSo915u 6zIt9+dvsUVZAfvaSKaCq8gV2gFQeFmJDN2pGjchCveWyCJOiQjpLiryxpkfOJcnVMbg I9vjmgADYwP9WGEnCr0Qupr/UmsizCKf0QelqN32ZrskkTvwZ7g/p1MMFgltH3FCgsn2 XsLmztwczv5/2zYSLlqX/meM5rVpTBkBBlHz4A+RkEeCO5xhRBgQaClqt7LHkq4EXkJn YFhygF1r5Q3a4vpntuvlTojT7keLVOOVFJ0HQAcuVR86uXLoFo73GICGz+f4D59TJPy0 DJ9Q== X-Gm-Message-State: AOJu0YzZO7XNOjn3L+V/yyj5YnEVXp2/TQ1tHhmLOOI7CeEBAjfE2lrT iWpcchSj8QozeSoyq4rhbIJt4Q== X-Google-Smtp-Source: AGHT+IE1nILLKPaFxe5im/MfVjUE0HuRytyibnYnzCmrjBnu/bqUhqldLHu9krEWO371lIWoHdHJrg== X-Received: by 2002:ac8:5ac9:0:b0:403:ef0a:ac69 with SMTP id d9-20020ac85ac9000000b00403ef0aac69mr11892621qtd.62.1695050199490; Mon, 18 Sep 2023 08:16:39 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id z22-20020ac87116000000b004108f6788a6sm3081779qto.41.2023.09.18.08.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:16:38 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qiFzJ-0005Nh-7L; Mon, 18 Sep 2023 12:16:37 -0300 Date: Mon, 18 Sep 2023 12:16:37 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Alex Williamson , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Anish Ghulati , Venkatesh Srinivas , Andrew Thornton Subject: Re: [PATCH 01/26] vfio: Wrap KVM helpers with CONFIG_KVM instead of CONFIG_HAVE_KVM Message-ID: <20230918151637.GF13795@ziepe.ca> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-2-seanjc@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230916003118.2540661-2-seanjc@google.com> On Fri, Sep 15, 2023 at 05:30:53PM -0700, Sean Christopherson wrote: > Wrap the helpers for getting references to KVM instances with a check on > CONFIG_KVM being enabled, not on CONFIG_HAVE_KVM being defined. PPC does > NOT select HAVE_KVM, despite obviously supporting KVM, and guarding code > to get references to KVM based on whether or not the architecture supports > KVM is nonsensical. > > Drop the guard around linux/kvm_host.h entirely, conditionally including a > generic headers is completely unnecessary. > > Signed-off-by: Sean Christopherson > --- > drivers/vfio/vfio.h | 2 +- > drivers/vfio/vfio_main.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1B79CD13D2 for ; Mon, 18 Sep 2023 15:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JQhZTKxJAqhJWJipJ9aywwkjrzHl4Zx05YpbD1SKkI4=; b=dpt/2dlcnPHk4t tvPYPTwOEzyKogDr74+Kv1TwfLe+eTnAM27bcfdd/kKoyFbOEnnV8xgxGfd+USBgZT9sIbYO5Jrek KxhhLYGAe8hDNCW77RpxaonNaPkdGRWWDHOjkAdJn1HLO0VjtiZlNzw27gs1Bf+n6gaOD9JHXiBBj rFjaoiu2XB7ooMd/KG48eEH9kzdN72oinVZTCSTR9+fD/JH6vxjfAC4mnCfex3lWujRqm5tKE3/AJ Ujw+8Vme5E2gTgnqW07abh4aBryDZlXzpFpyXkUCrltNj+l4e6pJzuriQ9/BABXJR7+KjWV8CNpNh ME0VnNrjDw32vIVj0rag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiFzR-00FjIK-0d; Mon, 18 Sep 2023 15:16:45 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiFzN-00FjGW-14 for linux-riscv@lists.infradead.org; Mon, 18 Sep 2023 15:16:42 +0000 Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-41214998fc2so27335291cf.0 for ; Mon, 18 Sep 2023 08:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695050199; x=1695654999; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=CE2ilZ2CdTbLkucy4FZOZwvja7km59zILbpwqONkIZO2IVPL3RnyaI+AQd+cV5Cp+/ OfMaY+HCyuXoYbeJJkt+RuHfYf5bm0XAzB9LqJM3oOnagW3M11VbU6ov1phLOXce14Oi FJSqkwcJX8A2aPEx0ykgu++DelVLATagx4R/blDHWY5nW08NCkwQQcmEtS6qLzV7l118 Oknuzl3YcclOqJa2J5B+ABp4flq89hOA6Eu3gT9IRcZ4KjXQAG1Hoe970SjDccFL6s1m X6nJg+owJIQDqCsS4R0pxDjpZd2Kkf21fATaldUdbF7mISaS3JknVfl8u3XEepHB5S2M h0jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050199; x=1695654999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=ZiuBZYgSYYDavGXLjqw0QzXzD3LEau0d6JD7w2Kgrycg6l7L9f6WXH4WaOHYtx6lPR Wi0sLtx1SKRQI+MbYwQiGpc6kBSREiOCbmzdMIfW+au8IkxO8gOreD+P1VDSINFlsIkt N8GJys+xy0NZX4WC52BpreAkWRrEZqwTTYwDob8p0snZyZe2xSmKVENM6R45WEc8YasJ tAtssE2jk8J/VCgzeje/aziVhXBjqry+h+WwEhnDaKEB1QwCF6UKjdE9AdgT9vxjEDTw BLL7eYiEvBDEBbcUCBhmFfMGAHIDKKQ9gQ6EtzAkwg5CV//rIdFfKVPL9yniR1pii4zz SMvw== X-Gm-Message-State: AOJu0YzQs9XuRwxF7zGuYht2rET9OKJ3n0sRbXm0QMIhs0lHPrRSxLKS Q46tHCguDzeRgSrpUqQeB/g+Gg== X-Google-Smtp-Source: AGHT+IE1nILLKPaFxe5im/MfVjUE0HuRytyibnYnzCmrjBnu/bqUhqldLHu9krEWO371lIWoHdHJrg== X-Received: by 2002:ac8:5ac9:0:b0:403:ef0a:ac69 with SMTP id d9-20020ac85ac9000000b00403ef0aac69mr11892621qtd.62.1695050199490; Mon, 18 Sep 2023 08:16:39 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id z22-20020ac87116000000b004108f6788a6sm3081779qto.41.2023.09.18.08.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:16:38 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qiFzJ-0005Nh-7L; Mon, 18 Sep 2023 12:16:37 -0300 Date: Mon, 18 Sep 2023 12:16:37 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Alex Williamson , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Anish Ghulati , Venkatesh Srinivas , Andrew Thornton Subject: Re: [PATCH 01/26] vfio: Wrap KVM helpers with CONFIG_KVM instead of CONFIG_HAVE_KVM Message-ID: <20230918151637.GF13795@ziepe.ca> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-2-seanjc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230916003118.2540661-2-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_081641_578356_C497A39D X-CRM114-Status: GOOD ( 13.33 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Sep 15, 2023 at 05:30:53PM -0700, Sean Christopherson wrote: > Wrap the helpers for getting references to KVM instances with a check on > CONFIG_KVM being enabled, not on CONFIG_HAVE_KVM being defined. PPC does > NOT select HAVE_KVM, despite obviously supporting KVM, and guarding code > to get references to KVM based on whether or not the architecture supports > KVM is nonsensical. > > Drop the guard around linux/kvm_host.h entirely, conditionally including a > generic headers is completely unnecessary. > > Signed-off-by: Sean Christopherson > --- > drivers/vfio/vfio.h | 2 +- > drivers/vfio/vfio_main.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 093EDCD13D2 for ; Mon, 18 Sep 2023 15:17:44 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=P40gAJhu; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Rq7hR1QJMz3cDg for ; Tue, 19 Sep 2023 01:17:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=P40gAJhu; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ziepe.ca (client-ip=2607:f8b0:4864:20::834; helo=mail-qt1-x834.google.com; envelope-from=jgg@ziepe.ca; receiver=lists.ozlabs.org) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Rq7gL67Czz30PY for ; Tue, 19 Sep 2023 01:16:45 +1000 (AEST) Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-4121f006c30so27235771cf.2 for ; Mon, 18 Sep 2023 08:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695050199; x=1695654999; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=P40gAJhuauVBSp345Kwo5VzhdhFDkbJ1QNqIk2WG1MM60BpKHsaPKQRqAqbR9bQmUx rDXL1T8/4cXWQF5JAfwedLSGYBr0gIhnvRcRhEVVf+ZAxMHR4DClkwT+uA6rvwiiIoBL FMMJ7bcQPrjpqwa+t/ZXIiY/NGpeH9KYyJX1xFOgAhYOxz/axShKApcbccMIY6pXO2XE QiZ2Ky2qpW9Lhy0XbIZ4/AvpC8wRSEI0Y4l1ffzo6giQnA3ZKuUU85b5X/EnDrhORTER ogloP2WnzKkEGCiG/bc3LXrF4ahOdZzqXNH5vDuAQx0RS5R1sA4y5YFqDljU/SuMwS1E FujA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050199; x=1695654999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=Gu1LsW295nw4HZjF7QoqySg6/ZLQ6zLbHTl/YkBEX2+Vf/D/2Io2Z8IiMFcea0Zu1I 9RpAQA4TOLubod42jAkfgNlA4+IFg9X70N8H0OJhL/mofbh7v21mvh0/kN0N6HUKDhZy IQYwEbfmATXeauDC2qG1qOGbyHnrb0tK+UtWOX36I9n4+QTx7zTXavuGfZPQQAX4hsPG 37TLBJl2aJxfrzmmnvymPeIiX1e6L1yFDa0Rm+m5E7aAUVCNpSBnp02/XT3a/rZzBOxS RFSyXUqEknV8Pvq9oqD7EA/XV3GwKyL+S8Zs9VaKl8HQitDP6vXOirYCdlrYLNa64iq7 tD4w== X-Gm-Message-State: AOJu0YyT1ib4YwpARIE2GmoGbhaO80ylr67qsuXMD0TXM4MQrNqB4tfH ElzGDm5z2ehvwWq+k3yPY1lF+w== X-Google-Smtp-Source: AGHT+IE1nILLKPaFxe5im/MfVjUE0HuRytyibnYnzCmrjBnu/bqUhqldLHu9krEWO371lIWoHdHJrg== X-Received: by 2002:ac8:5ac9:0:b0:403:ef0a:ac69 with SMTP id d9-20020ac85ac9000000b00403ef0aac69mr11892621qtd.62.1695050199490; Mon, 18 Sep 2023 08:16:39 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id z22-20020ac87116000000b004108f6788a6sm3081779qto.41.2023.09.18.08.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:16:38 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qiFzJ-0005Nh-7L; Mon, 18 Sep 2023 12:16:37 -0300 Date: Mon, 18 Sep 2023 12:16:37 -0300 From: Jason Gunthorpe To: Sean Christopherson Subject: Re: [PATCH 01/26] vfio: Wrap KVM helpers with CONFIG_KVM instead of CONFIG_HAVE_KVM Message-ID: <20230918151637.GF13795@ziepe.ca> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-2-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230916003118.2540661-2-seanjc@google.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, kvm@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-kernel@vger.kernel.org, Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Janosch Frank , Harald Freudenberger , Marc Zyngier , Huacai Chen , Halil Pasic , Andrew Thornton , Ingo Molnar , Christian Borntraeger , Jason Herne , Albert Ou , Vasily Gorbik , Venkatesh Srinivas , Heiko Carstens , Arnaldo Carvalho de Melo , Alex Williamson , Borislav Petkov , And y Lutomirski , Paul Walmsley , kvmarm@lists.linux.dev, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Tony Krowiak , Anish Ghulati , linux-mips@vger.kernel.org, Oliver Upton , linux-perf-users@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 15, 2023 at 05:30:53PM -0700, Sean Christopherson wrote: > Wrap the helpers for getting references to KVM instances with a check on > CONFIG_KVM being enabled, not on CONFIG_HAVE_KVM being defined. PPC does > NOT select HAVE_KVM, despite obviously supporting KVM, and guarding code > to get references to KVM based on whether or not the architecture supports > KVM is nonsensical. > > Drop the guard around linux/kvm_host.h entirely, conditionally including a > generic headers is completely unnecessary. > > Signed-off-by: Sean Christopherson > --- > drivers/vfio/vfio.h | 2 +- > drivers/vfio/vfio_main.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67E26CD37B0 for ; Mon, 18 Sep 2023 15:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IUz/k6OZhD6hJlQqBEif7wvcLcKAa3+ybaGBbqBWshU=; b=0PsKG4G8kfrR64 1Fc6BTAtnmRnzKxixdxExWg2nZOVUJkVlQKs5dBTkE5OgK+JCd2TA2Xc293Y7gyL7tKYOFGVrPSB0 gne9brbuJKRo5PL6pS/RjyX2RSyoUOF3inGgsM88DtVCe2qe9kmo/Teg5xaNg2+Ia//BP6uIgMQ5S ELpGWLVbOxPyftGKNAHEuWqcRBMJcnUz09UK+K9ysR1cs7an5OHYdrBFILrXMW2bnKN/1SgiFuR13 J0j6ui3WVQAIzaQ5NRnpW6pOn0fh+EUHvp1uZBZmDp0efEHIPkqUhFlcvpEKR78RcolFu8PRDETxt R5OQ60joa89CSygr8RvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiFzQ-00FjI4-2B; Mon, 18 Sep 2023 15:16:44 +0000 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiFzN-00FjGZ-10 for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 15:16:42 +0000 Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-413636c6d6aso27198841cf.3 for ; Mon, 18 Sep 2023 08:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695050199; x=1695654999; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=CE2ilZ2CdTbLkucy4FZOZwvja7km59zILbpwqONkIZO2IVPL3RnyaI+AQd+cV5Cp+/ OfMaY+HCyuXoYbeJJkt+RuHfYf5bm0XAzB9LqJM3oOnagW3M11VbU6ov1phLOXce14Oi FJSqkwcJX8A2aPEx0ykgu++DelVLATagx4R/blDHWY5nW08NCkwQQcmEtS6qLzV7l118 Oknuzl3YcclOqJa2J5B+ABp4flq89hOA6Eu3gT9IRcZ4KjXQAG1Hoe970SjDccFL6s1m X6nJg+owJIQDqCsS4R0pxDjpZd2Kkf21fATaldUdbF7mISaS3JknVfl8u3XEepHB5S2M h0jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050199; x=1695654999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6Ucvab0+WYvq4UufE5S4SV2ca9jdWUsP9GGHLs6BCgo=; b=u+Xqua7JvLv8upRwpduIpwMwC2sRFV6wJNiG75ZA9d+h54ReMm/vETiTaeZuzPDfbD /sKn9RqFy6SDi6b05rk1TL77oUR02Jph2A48vnG9YpFc/VrEHpRkhEgHWMqJRGehE7yh Ys4WMLrzVXBG39sFT0Ttdp3AsH+7X7jFoZtDY0Rn+3wl6Bxd/TP8F3JCrb8D23QvbDub Fk7L4sbUGTNx3uQWb4FuKnb15JNdfcqsPWEWGgCPM+AsCwETP6XMT7i3Kgdol6TDMK6R 4D0KSSNQf5Nh2E95OlyhY+GhLCOyVzJF1TItoOFFtBXdKv3T/gCLLkdf6ak6OwxDfogZ /7wA== X-Gm-Message-State: AOJu0YzEjjyAfzNmLPBII0493g4rBSue4HwGAeS/dDQ8pPh8gklFk5i6 grBhjrl2aiuL/O1H7S1oT9crDQ== X-Google-Smtp-Source: AGHT+IE1nILLKPaFxe5im/MfVjUE0HuRytyibnYnzCmrjBnu/bqUhqldLHu9krEWO371lIWoHdHJrg== X-Received: by 2002:ac8:5ac9:0:b0:403:ef0a:ac69 with SMTP id d9-20020ac85ac9000000b00403ef0aac69mr11892621qtd.62.1695050199490; Mon, 18 Sep 2023 08:16:39 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id z22-20020ac87116000000b004108f6788a6sm3081779qto.41.2023.09.18.08.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:16:38 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qiFzJ-0005Nh-7L; Mon, 18 Sep 2023 12:16:37 -0300 Date: Mon, 18 Sep 2023 12:16:37 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Alex Williamson , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Anish Ghulati , Venkatesh Srinivas , Andrew Thornton Subject: Re: [PATCH 01/26] vfio: Wrap KVM helpers with CONFIG_KVM instead of CONFIG_HAVE_KVM Message-ID: <20230918151637.GF13795@ziepe.ca> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-2-seanjc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230916003118.2540661-2-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_081641_578362_85CDBBE2 X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 15, 2023 at 05:30:53PM -0700, Sean Christopherson wrote: > Wrap the helpers for getting references to KVM instances with a check on > CONFIG_KVM being enabled, not on CONFIG_HAVE_KVM being defined. PPC does > NOT select HAVE_KVM, despite obviously supporting KVM, and guarding code > to get references to KVM based on whether or not the architecture supports > KVM is nonsensical. > > Drop the guard around linux/kvm_host.h entirely, conditionally including a > generic headers is completely unnecessary. > > Signed-off-by: Sean Christopherson > --- > drivers/vfio/vfio.h | 2 +- > drivers/vfio/vfio_main.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel