From: Mike Rapoport <rppt@kernel.org>
To: Usama Arif <usama.arif@bytedance.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, sfr@canb.auug.org.au,
muchun.song@linux.dev, mike.kravetz@oracle.com,
songmuchun@bytedance.com, fam.zheng@bytedance.com,
liangma@liangbit.com, punit.agrawal@bytedance.com
Subject: Re: [PATCH] memblock: add missing argument definition
Date: Mon, 18 Sep 2023 18:56:07 +0300 [thread overview]
Message-ID: <20230918155607.GD3303@kernel.org> (raw)
In-Reply-To: <20230918090657.220463-1-usama.arif@bytedance.com>
On Mon, Sep 18, 2023 at 10:06:57AM +0100, Usama Arif wrote:
> Description of argument memblock_type was missing in the commit
> that introduced it.
>
> Fixes: 70083e1c8ab4 ("memblock: pass memblock_type to memblock_setclr_flag")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Usama Arif <usama.arif@bytedance.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
Andrew, the commit being fixed is in mm-unstable, can you please pick it
up?
> ---
> mm/memblock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 8f7a0cb668d4..fd492e5bbdbc 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -892,6 +892,7 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size)
>
> /**
> * memblock_setclr_flag - set or clear flag for a memory region
> + * @type: memblock type to set/clear flag for
> * @base: base address of the region
> * @size: size of the region
> * @set: set or clear the flag
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2023-09-18 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 9:06 [PATCH] memblock: add missing argument definition Usama Arif
2023-09-18 15:56 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918155607.GD3303@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=fam.zheng@bytedance.com \
--cc=liangma@liangbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=punit.agrawal@bytedance.com \
--cc=sfr@canb.auug.org.au \
--cc=songmuchun@bytedance.com \
--cc=usama.arif@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.