All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org
Cc: "Marek Behún" <kabel@kernel.org>
Subject: [PATCH v4 0/4] leds: turris-omnia: updates
Date: Mon, 18 Sep 2023 18:11:00 +0200	[thread overview]
Message-ID: <20230918161104.20860-1-kabel@kernel.org> (raw)

Hello Lee,

I am sending version 4 of Turris Omnia's LED controller updates.
I tried to address the issues you mentioned:
- I made the omnia_cmd_read_raw() function to return the number of read
  bytes on success
- I have renamed omnia_cmd_read() to omnia_cmd_read_u8() since it always
  reads one byte. The function returns the read byte on success and
  a negative errno on failure
- accordingly, I have renamed omnia_cmd_write() to omnia_cmd_write_u8(),
  and made it so that it returns the number of written bytes on success
- the newly added comments now start with a capital letter

Marek

Marek Behún (4):
  leds: turris-omnia: do not use SMBUS calls
  leds: turris-omnia: make set_brightness() more efficient
  leds: turris-omnia: support HW controlled mode via private trigger
  leds: turris-omnia: add support for enabling/disabling HW gamma
    correction

 .../sysfs-class-led-driver-turris-omnia       |  14 +
 drivers/leds/Kconfig                          |   1 +
 drivers/leds/leds-turris-omnia.c              | 352 ++++++++++++++++--
 3 files changed, 329 insertions(+), 38 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-09-18 16:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 16:11 Marek Behún [this message]
2023-09-18 16:11 ` [PATCH v4 1/4] leds: turris-omnia: do not use SMBUS calls Marek Behún
2023-09-18 16:11 ` [PATCH v4 2/4] leds: turris-omnia: make set_brightness() more efficient Marek Behún
2023-09-18 16:11 ` [PATCH v4 3/4] leds: turris-omnia: support HW controlled mode via private trigger Marek Behún
2023-09-18 16:11 ` [PATCH v4 4/4] leds: turris-omnia: add support for enabling/disabling HW gamma correction Marek Behún
2023-09-21 10:51 ` [PATCH v4 0/4] leds: turris-omnia: updates Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918161104.20860-1-kabel@kernel.org \
    --to=kabel@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.